From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14C78C4167B for ; Thu, 30 Nov 2023 16:43:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345507AbjK3Qng (ORCPT ); Thu, 30 Nov 2023 11:43:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbjK3Qnf (ORCPT ); Thu, 30 Nov 2023 11:43:35 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88FE110DE for ; Thu, 30 Nov 2023 08:43:41 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15E27C433C7; Thu, 30 Nov 2023 16:43:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701362621; bh=Y4sgZDhs4wynPu47QMjQjQHfSY0fT9c/kB/u77jBAg0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XWmkzBCcc03gYkV1g/4ZMIMtNwjz8M8v20ER1M80R/lbHM3FMU6q/uOuSCweHsyCt i9B1Q5/QsNYeJEm50I/mcZO8F6+dURkViHUWGV99uMg/lzVCpGdYXAonMMvirJeOeX PzHwSe+jzSNwLF02Qc6OgwFWGE2WbHgBm3IC+S+nauyTpZORqTYW5mn89ikFgZOSJY 6/joQKMbn3Mc7+WBZ9v+be2BEsyDQmS0IxOiVoDg8jNyMaOmNZZfbel6yVXtExBvLl rswEj7+T8NbulbipMkNtf0n1Kk98brwqIXbz6sFbEHoXmFyU5WfkyqwtXXGw72IlZ5 rj/aFVcvYlO2A== Date: Thu, 30 Nov 2023 10:43:40 -0600 From: "Seth Forshee (DigitalOcean)" To: Amir Goldstein Cc: Christian Brauner , Serge Hallyn , Paul Moore , Eric Paris , James Morris , Alexander Viro , Miklos Szeredi , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, audit@vger.kernel.org, linux-unionfs@vger.kernel.org Subject: Re: [PATCH 12/16] ovl: use vfs_{get,set}_fscaps() for copy-up Message-ID: References: <20231129-idmap-fscap-refactor-v1-0-da5a26058a5b@kernel.org> <20231129-idmap-fscap-refactor-v1-12-da5a26058a5b@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 30, 2023 at 08:23:28AM +0200, Amir Goldstein wrote: > On Wed, Nov 29, 2023 at 11:50 PM Seth Forshee (DigitalOcean) > wrote: > > > > Using vfs_{get,set}xattr() for fscaps will be blocked in a future > > commit, so convert ovl to use the new interfaces. Also remove the now > > unused ovl_getxattr_value(). > > > > Signed-off-by: Seth Forshee (DigitalOcean) > > You may add: > > Reviewed-by: Amir Goldstein Thanks! > I am assuming that this work is destined to be merged via the vfs tree? > Note that there is already a (non-conflicting) patch to copy_up.c on > Christian's vfs.rw branch. I'll leave that up to Christian. There are also other mnt_idmapping.h changes on vfs.misc which could cause (probably minor) conflicts.