From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E14C4167B for ; Fri, 8 Dec 2023 12:21:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233532AbjLHMVM (ORCPT ); Fri, 8 Dec 2023 07:21:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235881AbjLHMVH (ORCPT ); Fri, 8 Dec 2023 07:21:07 -0500 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60E9719A5; Fri, 8 Dec 2023 04:21:13 -0800 (PST) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6ce26a03d9eso1511475b3a.0; Fri, 08 Dec 2023 04:21:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702038073; x=1702642873; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HBylJguRLtCHJTwufQYDaqjtAAVjosYGjLO6kCTyNVk=; b=LuT/58I1mwKjxmk524Z8WM/1YmKuvxHt5/LbppJYNCas+jLMgwmdz8/R+4QMU2V+VM 5iFLbYqhWAvF2BPhglGA2VeUN6ai1WAggcP3eL7N0CTc8dViW00xIRmZ7bZslZUBx/G6 IlgPQ5Op1k2M2nLRFVqRtUnx7pm8rVs9cEJREwRzYEhSeFvipBnhVYb9MwcatPpx3VeH uZiq/gNxdCcgIBU2xYd+fvzVNzDxuynBS4sKKGxkf+iTklF1mrERABEZ3+JyUSWdGPU/ +M+LEGxAT5Wn3IrxMFOcgaUh2ITm3OC4fao9wiYmTT7AjioHRmJxGB1ciw2fh7+d4VHs On+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702038073; x=1702642873; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HBylJguRLtCHJTwufQYDaqjtAAVjosYGjLO6kCTyNVk=; b=AKN2P5o80cybba3rMd8mU3hRtD6kDnsXyePROwYQuslyB29yEtzhBJUiPv9Yuv/hv4 Grx9rGTVVfE3PxHLzYT9hzZ4iaixneJ4lOwz27zVbysKA68uqvufEk1tLTj8XVuoC35e 4J1khic2r54sUOJgdj2kWs9AudP+5PR6udWl7Z8OGHLLvJdIsF2tPQJop+qIDpJPl1qR 7mY2Ml2jzyIFxNXwtc3xuhRz1KRekNDQdtCSvyEpmLxf2Y5ZL5O59Dzj5x3IsPccu0/p 7Aw9Bb2luRgmfiSv2Q61/EQCU86ITC3rcEpJspdZizATV5n5tfViJDz+AgaXPBC4/unN 17/A== X-Gm-Message-State: AOJu0YxqbCP51TXmlU4dKKQXqZw7Px/USgr1sunHCj/Mt0t4gn/AM/nD iyi1nX6Pfh8FxlqRhCcU0nY= X-Google-Smtp-Source: AGHT+IG9q/TwR3OEzg/OABKdlXCvWeyF224LiGWiBOg7ST2oapE9nW1A/gpab/BOiiu2ftWDyLkrCw== X-Received: by 2002:a05:6a20:2618:b0:18b:31eb:8b66 with SMTP id i24-20020a056a20261800b0018b31eb8b66mr3058841pze.50.1702038072764; Fri, 08 Dec 2023 04:21:12 -0800 (PST) Received: from localhost ([2804:30c:95c:8600:5b2d:e35b:5f45:dc84]) by smtp.gmail.com with ESMTPSA id e14-20020a056a001a8e00b006ce6bd9703csm1436765pfv.194.2023.12.08.04.21.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 04:21:12 -0800 (PST) Date: Fri, 8 Dec 2023 09:21:00 -0300 From: Marcelo Schmitt To: Joe Perches Cc: Marcelo Schmitt , apw@canonical.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, paul.cercueil@analog.com, Michael.Hennerich@analog.com, lars@metafoo.de, jic23@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, dan.carpenter@linaro.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 01/13] scripts: checkpatch: Add __aligned to the list of attribute notes Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/07, Joe Perches wrote: > On Thu, 2023-12-07 at 15:37 -0300, Marcelo Schmitt wrote: > > Checkpatch presumes attributes marked with __aligned(alignment) are part > > of a function declaration and throws a warning stating that those > > compiler attributes should have an identifier name which is not correct. > > Add __aligned compiler attributes to the list of attribute notes > > so they don't cause warnings anymore. > > > > Signed-off-by: Marcelo Schmitt > > --- > > The patch that would trigger the mentioned checkpatch warning in this series is > > patch number 12 (iio: adc: Add support for AD7091R-8). > > > > scripts/checkpatch.pl | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > index 25fdb7fda112..e6773ae0ad08 100755 > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -512,6 +512,7 @@ our $Attribute = qr{ > > __ro_after_init| > > __kprobes| > > $InitAttribute| > > + __aligned| > > __aligned takes an argument so I think there needs > to have something like the use of __alloc_size below > this addition > __alloc_size\s*\(\s*\d+\s*(?:,\s*\d+\s*)?\) > > maybe > > __aligned\s*\([^\)]*\) > > though even that would work well with most uses it > would not work with things like > > drivers/crypto/inside-secure/safexcel_hash.c: u8 cache[HASH_CACHE_SIZE] __aligned(sizeof(u32)); > Will think of something that may work for all cases and include in v4. Thanks