From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BDE1C4332F for ; Tue, 12 Dec 2023 17:26:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235130AbjLLR0A (ORCPT ); Tue, 12 Dec 2023 12:26:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376732AbjLLRZv (ORCPT ); Tue, 12 Dec 2023 12:25:51 -0500 Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB0108F; Tue, 12 Dec 2023 09:25:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=2994; q=dns/txt; s=iport; t=1702401957; x=1703611557; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=lcKefbUwqipuZf7j3/0KQGnDnwTO9UpSOeTCzsa59T0=; b=WjdF2cvk8p+2Bt+A/jyEFRY6JxMrCHr7ssmnKrWZqeM8yOqi801nMfp5 +LzpEWf2xRm8V7mi5PiTGu1o4QQzq0KWgOVp/S/XbUV02nR4ql5kCTTBg qfeJFOaTA5Sfa0Y7YvO1PcYI7NbtIcJewqKD7QPmvkYrzhmLewOqf+Fks 4=; X-CSE-ConnectionGUID: cTriDFrrR9u6mpTvBXvF8A== X-CSE-MsgGUID: 8yaLO3mwTDCYR5v75Uch+Q== X-IPAS-Result: =?us-ascii?q?A0AkAAABl3hlmJFdJa1aHQEBAQEJARIBBQUBQCWBFggBC?= =?us-ascii?q?wGBZlJ5XDxIiB4DhE5fiEodA4V6jF+LJYElA1YPAQEBDQEBRAQBAYUGAocuA?= =?us-ascii?q?iY0CQ4BAgQBAQEBAwIDAQEBAQEBAQEGAQEFAQEBAgEHBBQBAQEBAQEBAR4ZB?= =?us-ascii?q?Q4QJ4V1hkYBAQEDEig/EAIBCBgeEBAiJQIEDgUigl6CXwMBoV8BgUACiih4g?= =?us-ascii?q?TSBAYIVBbJ5GIEwAYgVAYogJxuBSUSEPz6EQ4ZDBIkaBzKCIYNRkR9bIkZwG?= =?us-ascii?q?wMHA38PKwcELRsHBgkUGBUjBlEEKCEJExJAgV6BUgp+Pw8OEYI+IgIHNjYZS?= =?us-ascii?q?IJaFQw0SnUQKgQUF4ERBGobEh43ERIXDQMIdB0CMjwDBQMEMwoSDQshBRRCA?= =?us-ascii?q?0IGSQsDAhoFAwMEgTMFDR4CEBoGDCcDAxJJAhAUAx4dAwMGAwoxAzCBGQxPA?= =?us-ascii?q?2wfNAk8DwwdAjkNJyMCLFYFEgIWAyQaNhEJCygDLwY4AhMMBgYJXiYWCQQnA?= =?us-ascii?q?wgEA1QDI30RAwQPA0QdQAN4PTUUGwZnpWUGPhyBAQKBI05kkiwcgyABrUyBO?= =?us-ascii?q?AqED54Hg2apdJhDoxeFGAIEAgQFAg4BAQaBYzqBW3AVgyJSGQ+OOZNYdjsCB?= =?us-ascii?q?wsBAQMJimEBAQ?= IronPort-PHdr: A9a23:RxmOdhXpYAmHt8hAuWvR6R5I52jV8K0yAWYlg6HPw5pHdqClupP6M 1OaubNmjUTCWsPQ7PcXw+bVsqW1QWUb+t7Bq3ENdpVQSgUIwdsbhQ0uAcOJSAX7IffmYjZ8H ZFqX15+9Hb9Ok9QS47lf1OHmnSp9nYJHwnncw98J+D7AInX2si+0eG//4LaSw5JnzG6J7h1K Ub+oQDYrMJDmYJ5Me5x0k7Qv3JScuJKxGVlbV6ShEP64cG9vdZvpi9RoPkmscVHVM3H IronPort-Data: A9a23:Zob5Y63ltEPT2oN1PvbD5RZxkn2cJEfYwER7XKvMYLTBsI5bp2QEy 2VKWGiDafiIYGDzL94lb4nl8xwGu5ODy9IxHgM63Hw8FHgiRegpqji6wuYcGwvIc6UvmWo+t 512huHodZ1yFjmE4E71btANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq8wIDqtYAbeORXUXV5 bsen+WFYAX+gmQtaDpNg06+gEoHUMra6WtwUmMWPZinjHeG/1EJAZQWI72GLneQauG4ycbjG o4vZJnglo/o109F5uGNy94XQWVWKlLmBjViv1INM0SUbreukQRpukozHKJ0hU66EFxllfgpo DlGncTYpQvEosQglcxFOyS0HR2SMoVNxKXGDValq/bC0hPDa0fy6cVwIhEfaNhwFuZfWQmi9 NQCIzwLKxuEne/zkfSwS/JngYIoK8yD0IE34y47i2qGS6d9B8mfHs0m5vcAtNs0rsxHG/fTY 9UQQTFudx/HJRZIPz/7Dbpnzbz52CGmL2AwRFS99bs+x0+IyRNN/JPcCofLJYG3TsUWpxPNz o7B1z+kWk5BboP3JSC+2natgPLf2CD2QoQfEJWm+fNwxl6e3GoeDFsRT1TTif24jFOuHt9RK mQK9Sc066s/7kqmSp/6RRLQiHqFuAMMHt9RC/YS9g6A0OzX7hyfC2xCSSROAOHKr+csTjAsk 1SOhd6sVHpksaaeTjSW8bL8QS6O1TY9JlMYZAMqVxE/ssS9pZkPkDj/UPgzOfvg5jHqIg3Yz zePpSk4orwci88Xyqm2lWwrZRry/vAlqSZrvm3qsnKZ0+9vWGKyi2WVBbXz9/1MKsOSSUOM+ SlCkMmF5+dIBpaI/MBsfAnvNO/0jxpmGGSA6bKKI3XH32j1k5JEVdwJiAyS3G8zbq45lcbBO Sc/Qz956p5JJ2eNZqRqeY+3AMlC5fG/TY6+D6GIPoEfMsEZmOq7EMdGOxf4M4fFzhFErE3DE c7CGSpRJS9DVvs5lGLeqxk1i+96mEjSOl8/tbigkkz4iuDBDJJkYbwEK1CJJvso97+JpR6d8 tBUcaO3J+Z3DoXDjt3s2ddLdzgidCFjbbiv8pA/XrDYeGJORjp+Y8I9NJt8IeSJaYwPyLeRl px8M2cFoGfCaYrvdVzbMSk4Ne61Av6SbxsTZEQRALph4FB6Ca6H56YEfJxxdr4inNGPB9YtJ xXZU61s2shydwk= IronPort-HdrOrdr: A9a23:qkswZq/ia0dZKNsbYv1uk+Gkdr1zdoMgy1knxilNoENuA6+lfp GV/MjziyWUtN9IYgBfpTnhAsW9qXO1z+8S3WGIVY3SEjUOy1HYXb2KirGSggEIeheOudK1up 0QCZSWZOeAaWSSyPyKnzVQcOxQgOVvkprY+Ns2pk0FJWoFGsMQijuRSDzrbnGeLzM2fKbRYa Dsnfav0ADQAUj/AP7LYUXtdtKz1OHjpdbNWzJDLRgh7wWFkDOv75DHMzXw5H0jegIK640PtU zenSLExojLiZyGIxnnuFP73tBzop/M29FDDMuDhow+MTP3kDulY4xnRvmroC01iPvH0idprP D85zMbe+hj4XLYeW+45TH33RP77Too43j+jXeFnHrYp9DjTj5SMbsFuWsZSGqc16MThqA77E t55RPBi3ORN2KZoM3J3amOa/itrDvunZNtq59Is5UVa/pvVFYYl/1swKoSKuZCIMo/g7pXTN WHy6rnlatrWELfYHbDsmZ1xtuwGnw1AxedW0AH/teYyj5MgRlCvgElLeEk7z89HagGOtJ5zv WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCYhv22tLKyaRw4PvvdI0DzZM0lp iEWFREtXQqc0arDcGVxpVE/h3EXW34VzXwzcNV4YR/p9THNffWGDzGTEprn9qrov0ZDMGeU/ GvOIhOC/umNmfqEZYh5Xy2Z3CTEwhpbCQ4gKdNZ7vVmLO/FmTDjJ2uTMru X-Talos-CUID: =?us-ascii?q?9a23=3AiU86sWunyYFlzljiiC0EIZZ46IsuTmfc4FnKOXX?= =?us-ascii?q?pFDhsUIGLY2+O1vNNxp8=3D?= X-Talos-MUID: 9a23:8glWTAbqSu8NPuBT5y7loBY5MdhUz4+fMh0Tzsg7sMnHDHkl X-IronPort-Anti-Spam-Filtered: true Received: from rcdn-core-9.cisco.com ([173.37.93.145]) by alln-iport-7.cisco.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2023 17:25:54 +0000 Received: from alln-opgw-4.cisco.com (alln-opgw-4.cisco.com [173.37.147.252]) by rcdn-core-9.cisco.com (8.15.2/8.15.2) with ESMTPS id 3BCHPsAD024147 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Dec 2023 17:25:54 GMT X-CSE-ConnectionGUID: qcEnrU0oQVqlDKj6m+DMWw== X-CSE-MsgGUID: /gWcXM2jQhmSlnbROAUAxA== Authentication-Results: alln-opgw-4.cisco.com; dkim=pass (signature verified) header.i=@cisco.com; spf=Pass smtp.mailfrom=danielwa@cisco.com; dmarc=pass (p=quarantine dis=none) d=cisco.com X-IronPort-AV: E=Sophos;i="6.04,270,1695686400"; d="scan'208";a="14841524" Received: from mail-bn8nam04lp2041.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.41]) by alln-opgw-4.cisco.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2023 17:25:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GPNj+vIvdfT9J44rLoROZi8KI712DvfysMP2QHwAI7Ls7VmNmi6utGuRc8Q34VBu/ReN96cYokJHXmkVpMHL8CrPebPrKYbCxdTk1FRRAWSBHiDpJGS6R6RIU9BnWvzlTgzRedwdM+XOxLzS3+P5FB36vo3/T01aGT1swfkn2RHXCa1ZKr14omqJzgjDDfFq8yLC2mAxiQb3okF16lEzI01x5iZ/vZN7N0uQf7ezdzJRQyhqen7qRGZNj1YVAyOgC8tVyw1W2JNdjMM78DABxZp9dSgOrih7oM7M2P7UgBDlLn12T5VBECVoQDGfWMyMSqjRN6faLBGyNXHXQBRNFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lcKefbUwqipuZf7j3/0KQGnDnwTO9UpSOeTCzsa59T0=; b=HxxT87d+XpsI9R2YlvkPAI37i71u14mHo7DBPDawEJJTYmswGQr5MBgvcKREDXwsGjkG83fJgcZmL+M5aY+FBB2hodKUHk0fnTh+dJPUAqjgr2A4AuQaL4nzOW/YDB/Gb+oSy6NMvyB2cMcPzgKXPTK2FnHa/vnTtEhyg8ESkFsOLh/SVcbncQoo1NwIZ18rh7ls2icLlqkj6+YezQhr4WJ+N/j3ELEQzgeVz/qAOuav8cYxCWQR65LRT/AarvTvuCF5gosuia+QP/u81NwdoV/jKTaXTjXCxcfKx8KQY79gcEuTESkzoavj4vYLSaqp3axl/sRk7NT5Pjol3xepdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none Received: from SJ0PR11MB5790.namprd11.prod.outlook.com (2603:10b6:a03:422::15) by MW3PR11MB4618.namprd11.prod.outlook.com (2603:10b6:303:5f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.33; Tue, 12 Dec 2023 17:25:50 +0000 Received: from SJ0PR11MB5790.namprd11.prod.outlook.com ([fe80::a59:2fb9:3446:4f8]) by SJ0PR11MB5790.namprd11.prod.outlook.com ([fe80::a59:2fb9:3446:4f8%7]) with mapi id 15.20.7091.022; Tue, 12 Dec 2023 17:25:50 +0000 From: "Daniel Walker (danielwa)" To: Ard Biesheuvel CC: Will Deacon , Christophe Leroy , Rob Herring , Daniel Gimpelevich , Andrew Morton , Pratyush Brahma , Tomas Mudrunka , Sean Anderson , "x86@kernel.org" , "linux-mips@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "xe-linux-external(mailer list)" , "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 5/8] drivers: firmware: efi: libstub: enable generic commandline Thread-Topic: [PATCH 5/8] drivers: firmware: efi: libstub: enable generic commandline Thread-Index: AQHaLSBAuqfhbaf+SEOR4+cpctXs3A== Date: Tue, 12 Dec 2023 17:25:50 +0000 Message-ID: References: <20231110013817.2378507-1-danielwa@cisco.com> <20231110013817.2378507-6-danielwa@cisco.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, OOF, AutoReply X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5790:EE_|MW3PR11MB4618:EE_ x-ms-office365-filtering-correlation-id: 048a9a98-880b-48d0-50be-08dbfb3762bc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qMrMaeDaZ9tF4aWb+ki2Ilm5JkEdZzoeEvbhaR0Ikv1qhDN4qInUeu+pL+Xy+7/0EF1/glDSOANV268YxjlCNVCrWElqBkiZQ0qdakdf/RdN8HIeZNY+7P9vZlhMyM0TDBrihmeV8eQNcoybLv+KmzJ95YO+I407XbBjKPAMU3IHBMGto80CaDMcujpPggMAp7e+KFYLpVm+v3ah+gU6kCQGwG+W9OMBGLQOuJ7g1OpOvldqSNgqm0UN1hTruINORO5rSR1DLKnVHtNA5b5F7dRuspCZ5+XovdOOjoh0FGouz+8yMg3tizbwmNMxrkitfTOi1Qfjwh8Yygx2A2pa4/gul3xsJJGa/LcUmQp0yGX9fPLT+toZxFJROs3KgGJxdn3Qev4tYKWYjfRHrlIK+bQgmLjVXal5+1/tKb2sGsZkxpwJgilKpy/JEjsh104rWXOweDJzf2/S/gv+zB98UfC+0Z+ea5KmdvFnAB4QjHMRi0ITuH2VUvH38PAzg409LK1cBLOKurN7QVJiqAEStGtBEXuogYGB74T5ZDFSZCQ2Oi4qAEGIvGccipAERKQPOn9H15qShBnbICW0Rr9Vvyao2EUCSogL6+Mqx9B/5aiWiwDDIDCJpbeAqPXA9yoUfx3KpVIhFNWnp+PtmaYJD/VRFfkxWTxZs3U9yM+NtvfqH7FkovupORrAB+Fp46a0 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB5790.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7916004)(39860400002)(376002)(366004)(346002)(396003)(136003)(230173577357003)(230273577357003)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(38070700009)(76116006)(6916009)(66476007)(66446008)(64756008)(54906003)(38100700002)(66556008)(86362001)(66946007)(122000001)(6506007)(6512007)(9686003)(6486002)(2906002)(316002)(71200400001)(33716001)(26005)(478600001)(8676002)(5660300002)(4326008)(8936002)(41300700001)(7416002)(41533002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EZKS2w2hk+RJH+Frszkm5gaAVwdHP66lWztimBQH9nlIKnCbVpAiKPcBD5sY?= =?us-ascii?Q?O/WSkebSodvFRjCaoy5lxgy6yXC1JZbVdOBum9OZFG0pY+GWieopSPKYyuLu?= =?us-ascii?Q?f0I1KFpTU+nZgUn2AZjto3f3XVVesoun75FMXPJupF+fXY2WqEV2w1YRkhDm?= =?us-ascii?Q?nKN5FAiC/Mg7NAF8VKbk1V5zX2mh/ar3oRedWmnYUAJrfVleaqlMK5Dw9+f6?= =?us-ascii?Q?VaNYgWv1a3B1Q23JdL7y9G2XiIfU5I8nwuVEIzheg0PELK8Dog9qOt3AN+yB?= =?us-ascii?Q?vGHljBpA0twWLckcczAser512JVOt06mGTZgW70Y5VRA70Awtf5tVKb4Bk0A?= =?us-ascii?Q?1eGRifYqjpRRCi2YmA37KRt0pPyqEo8Wx2EO05Yl5f44O97jKsEESrB/zzH7?= =?us-ascii?Q?Iz1Pc+9u5xjX3GuaRktnGUOupEtEMnyhZkBm/UXnIngD2wjCR4GaGIY81dsR?= =?us-ascii?Q?/gwls6c96cNFQtW0ANtjb/ooWGNbwmIR2rnNREwpSxnS4ghSP9Gjg7VPYDcS?= =?us-ascii?Q?6vgj0caqO0BbLFXkNI5DiUglsCyjTjPkoYqJpP+1CPTsu0bOLJ/a0GOeKKj9?= =?us-ascii?Q?SjCC4cYzKpnNgcSPifkrIfX63sSpDVjhzo0O3Sj2zi1hO8VZjfn/T5AVdxXp?= =?us-ascii?Q?9G7jUncBlxFEVqWXi6RxBI6Xu+jHpu+vJs7y0YxcrqBRoyE12m3jttFeBJgP?= =?us-ascii?Q?34XHSnoDnVnV19r8FZwGt6uz5BU/jyl05f4IB9D+5HXpN+2RbAXbH1mududp?= =?us-ascii?Q?s0/Y3CjXcoDbtaSc2LeaslaoZPrjOCSMYZjq1qhumQvnzo9bqE4+sXn+2aAB?= =?us-ascii?Q?xt9qRrIJa1tl+v1ytOkr1leYuNn5fipLLSLkw8+t8rC276Cuv/CDNa3ypxmV?= =?us-ascii?Q?txbLRaLzFbkFQYATyf2ZTLfipOhOAKhzVdBC8TMoz8fUiipoobWJar6SZnfY?= =?us-ascii?Q?05V1AOVR3T1z5UjeLAby+5R3So/mA6kCT0m9mKxLGzUvgwGmrIDjROSYKOhp?= =?us-ascii?Q?tUfez+3PXzizVf7GZALLljiFdkKu0E5uu235ruCZXCyOCB9G8l+n2JTTIgFM?= =?us-ascii?Q?WdxYgxUNIxS7vFx1Ygv7QbVM+n9gStgsL5Cig7QaNqpxwcE4ipi+nEAdqFOY?= =?us-ascii?Q?kpeoRSx7ou3p4NuAMQIhyouF/aLBwWu42esp258SVdrTxELPs61Je6T4zdui?= =?us-ascii?Q?1W690RuAgMf6FTx+X7d3kS9fmihSkuX7AVg8siSOpx1br6mPZe9aM9pGReIS?= =?us-ascii?Q?EhCO9Ne54I/sn7arJEquutgI0UFQFgOHho+ku47p+jc9Hrr9aGqCidkqkR8a?= =?us-ascii?Q?CwhRnVKHaK9WIQ4J+vdshwtYIN7lidIjMeLwh9PWKfS8fsfEkDuv9DzGb2aA?= =?us-ascii?Q?qsgHg0eUNGWNWeT+b4gyzovzvWPvNKCTszfS4+od1Ff2x0HLWkUJNuEgk+CT?= =?us-ascii?Q?bF6KuHWuDt+b3tFRKNu10hdV3CgY/xBh3IYwWVRAAS7w4JlfDbAzh+QK9iGR?= =?us-ascii?Q?WVv9yza3r6mNPS66Cs3hyN2susV3J0BtUVzDgQCYMBReEnyUgYz0DH6l5BUT?= =?us-ascii?Q?fCVGmWIeuARfjswXMZ+J6l+rm+8JXQJ0yH+K/wM5oeowMD4RWCDMhUS0kzd2?= =?us-ascii?Q?Qg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <9434A757E35DFD469727C9A2E56E9DF6@namprd11.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cisco.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5790.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 048a9a98-880b-48d0-50be-08dbfb3762bc X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2023 17:25:50.1225 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DDfM2VINTaKzaPj8ZIaG50cGJMgK67yN/wzKtuiXCP+MrVKl8Tas+pB54ZLGoOt2W+dDKBPxJVzGbkFazBZpUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4618 X-Outbound-SMTP-Client: 173.37.147.252, alln-opgw-4.cisco.com X-Outbound-Node: rcdn-core-9.cisco.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 12, 2023 at 10:55:33AM +0100, Ard Biesheuvel wrote: > On Fri, 10 Nov 2023 at 02:39, Daniel Walker wrote: > > > > This adds code to handle the generic command line changes. > > The efi code appears that it doesn't benefit as much from this design > > as it could. > > > > For example, if you had a prepend command line with "nokaslr" then > > you might be helpful to re-enable it in the boot loader or dts, > > but there appears to be no way to re-enable kaslr or some of the > > other options. > > > > The efi command line handling is incorrect. x86 and arm have an append > > system however the efi code prepends the command line. > > > > For example, you could have a non-upgradable bios which sends > > > > efi=3Ddisable_early_pci_dma > > > > This hypothetically could have been set because early pci dma caused > > issues on early versions of the product. > > > > Then later the early pci dma was made to work and the company desired > > to start using it. To override the bios you could set the CONFIG_CMDLIN= E > > to, > > > > efi=3Dno_disable_early_pci_dma > > > > then parsing would normally start with the bios command line, then move > > to the CONFIG_CMDLINE and you would end up with early pci dma turned on= . > > > > however, current efi code keeps early pci dma off because the bios > > arguments always override the built in. > > > > Per my reading this is different from the main body of x86, arm, and > > arm64. > > > > The generic command line provides both append and prepend, so it > > alleviates this issue if it's used. However not all architectures use > > it. > > > > It would be desirable to allow the efi stub to have it's builtin comman= d > > line to be modified after compile, but I don't see a feasible way to do > > that currently. > > > > Cc: xe-linux-external@cisco.com > > Signed-off-by: Daniel Walker >=20 > There are quite some 'might be's and 'hypothetical's in this commit log. >=20 > Is there an actual use case that you are addressing here? Without > that, this looks like unnecessary churn to me, tbh. >=20 > Note that this code executes in the context of platform firmware, > which may be old and buggy so we should be cautious about making > unnecessary changes here. It's been a while since I wrote this patch description, but there is an exa= mple I provided in the description. If you intend to enable early pci dma the comm= and line parsing may still disable it because of how the parsing works inside t= he efi stub. There is an implementation difference between the efi stub and th= e architectures which results in this problem. This was not an issue I observ= ed in the wild, it was the results of code review of the efi stub. Maybe the greater issue is that the efi stub seems to have connected itself= to the kernels command line system. If the kernel changes then EFI stub must a= lso change. Daniel=