From: Ido Schimmel <idosch@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jijie Shao <shaojijie@huawei.com>,
yisen.zhuang@huawei.com, salil.mehta@huawei.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
shenjian15@huawei.com, wangjie125@huawei.com,
liuyonglong@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 5/6] net: hns3: Add support for some CMIS transceiver modules
Date: Wed, 13 Dec 2023 13:02:55 +0200 [thread overview]
Message-ID: <ZXmPXzSxq0k4eO0m@shredder> (raw)
In-Reply-To: <20231211192122.14da98f0@kernel.org>
On Mon, Dec 11, 2023 at 07:21:22PM -0800, Jakub Kicinski wrote:
> On Mon, 11 Dec 2023 10:08:15 +0800 Jijie Shao wrote:
> > Add two more SFF-8024 Identifier Values that according to the standard
> > support the Common Management Interface Specification (CMIS) memory map
> > so the hns3 driver will be able to dump, parse and print their EEPROM
> > contents.This two SFF-8024 Identifier Values are SFF8024_ID_QSFP_DD (0x18)
> > and SFF8024_ID_QSFP_PLUS_CMIS (0x1E).
>
> Hm, you don't implement the ethtool get_module_eeprom_by_page op?
> I thought for QSFP DD page support was basically required.
You can read the first few pages with the legacy interface, but for the
rest you need the get_module_eeprom_by_page op. My recommendation is to
implement the new op and abandon the old ones.
next prev parent reply other threads:[~2023-12-13 11:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 2:08 [PATCH net-next 0/6] There are some features for the HNS3 ethernet driver Jijie Shao
2023-12-11 2:08 ` [PATCH net-next 1/6] net: hns3: add support for page_pool_get_stats Jijie Shao
2023-12-12 3:17 ` Jakub Kicinski
2023-12-12 11:05 ` Jijie Shao
2023-12-11 2:08 ` [PATCH net-next 2/6] net: hns3: add command queue trace for hns3 Jijie Shao
2023-12-11 2:08 ` [PATCH net-next 3/6] net: hns3: dump more reg info based on ras mod Jijie Shao
2023-12-11 2:08 ` [PATCH net-next 4/6] net: hns3: support dump pfc frame statistics in tx timeout log Jijie Shao
2023-12-11 2:08 ` [PATCH net-next 5/6] net: hns3: Add support for some CMIS transceiver modules Jijie Shao
2023-12-12 3:21 ` Jakub Kicinski
2023-12-12 11:09 ` Jijie Shao
2023-12-13 11:02 ` Ido Schimmel [this message]
2023-12-11 2:08 ` [PATCH net-next 6/6] net: sfp: Synchronize some CMIS transceiver modules from ethtool Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXmPXzSxq0k4eO0m@shredder \
--to=idosch@nvidia.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).