From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04815C4332F for ; Wed, 13 Dec 2023 18:13:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233379AbjLMSNP (ORCPT ); Wed, 13 Dec 2023 13:13:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233802AbjLMSNM (ORCPT ); Wed, 13 Dec 2023 13:13:12 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A22BE10A; Wed, 13 Dec 2023 10:13:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702491199; x=1734027199; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UQqZxdSjZUZKu7qV4uLKuuB6S1Lf0FGUnVaJd+r0FGI=; b=Ufcx+MCRtsW0DVBuunBNRFKxdbuKIz36FUM5f21IOvzMcu5lo2NSc4XO lpu9TyYHduPnbhLFyWNhZTT97ocwIsmO2JfgSkQK+FxwdbAfRdgvq7KbQ 1Ed8bqgejGk8QVhgf7Z/thy0APR9AiqHsE0yGOv6ynzaKyAGC6VEqQASs m1FeLI7G9xJBkeNAYyQB51Jawf2zjnOdMpD65RCGvvHifh9Gh103WhPZo eKdy87805mnV5uGhmOF6On4uz/8tJobkS35ClmBYvZsbPcj3/ln78eWb1 VBN6h7OtGTn9WUoAYmqHbz8jUUWT3HniYHi54Kpn6w/I25IqMTIEm0EHN w==; X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="1861079" X-IronPort-AV: E=Sophos;i="6.04,273,1695711600"; d="scan'208";a="1861079" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 10:13:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="947264609" X-IronPort-AV: E=Sophos;i="6.04,273,1695711600"; d="scan'208";a="947264609" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 10:13:16 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rDTjN-00000005bbW-2HDO; Wed, 13 Dec 2023 20:13:13 +0200 Date: Wed, 13 Dec 2023 20:13:13 +0200 From: Andy Shevchenko To: Nikita Shubin Cc: Mark Brown , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH v6 16/40] spi: ep93xx: add DT support for Cirrus EP93xx Message-ID: References: <20231212-ep93xx-v6-0-c307b8ac9aa8@maquefel.me> <20231212-ep93xx-v6-16-c307b8ac9aa8@maquefel.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231212-ep93xx-v6-16-c307b8ac9aa8@maquefel.me> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 12, 2023 at 11:20:33AM +0300, Nikita Shubin wrote: > - add OF ID match table > - add device tree DMA request, so we can probe defer, in case DMA is not > ready yet > - drop DMA platform code ... > + espi->dma_rx = dma_request_chan(dev, "rx"); > + if (IS_ERR(espi->dma_rx)) { > + ret = PTR_ERR(espi->dma_rx); > + dev_err_probe(dev, ret, "rx DMA setup failed"); ret = dev_err_probe(...); > goto fail_free_page; > } ... > + espi->dma_tx = dma_request_chan(dev, "tx"); > + if (IS_ERR(espi->dma_tx)) { > + ret = PTR_ERR(espi->dma_tx); > + dev_err_probe(dev, ret, "tx DMA setup failed"); Ditto. > goto fail_release_rx; > } ... Otherwise LGTM. -- With Best Regards, Andy Shevchenko