From: Johan Hovold <johan@kernel.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: Lee Jones <lee@kernel.org>,
phone-devel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org,
Rob Herring <robh@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Boyd <swboyd@chromium.org>,
Satya Priya <quic_c_skakit@quicinc.com>
Subject: Re: [PATCH v4 2/2] leds: qcom-lpg: Add PM660L configuration and compatible
Date: Wed, 20 Dec 2023 09:09:58 +0100 [thread overview]
Message-ID: <ZYKhVlgrlvq3HbFt@hovoldconsulting.com> (raw)
In-Reply-To: <xkmmbgbg2japfunuure2kktbxdkotteawwgzsjq6giafmwuosz@3no7qov5nzei>
On Tue, Dec 19, 2023 at 11:06:08AM +0100, Marijn Suijten wrote:
> On 2023-12-19 10:33:25, Johan Hovold wrote:
> > On Tue, Dec 19, 2023 at 10:17:16AM +0100, Marijn Suijten wrote:
> >
> > > Note that I have one more unmerged leds patch around, that hasn't been looked
> > > at either. Would it help to send this once again, perhaps with more reviewers/
> > > testing (Johan, would you mind taking a look too)?
> > >
> > > https://lore.kernel.org/linux-leds/20220719213034.1664056-1-marijn.suijten@somainline.org/
> >
> > Yes, I suggest you resend that one too so that it ends up in Lee's
> > inbox.
>
> I will rebase, test and resend it too. Just asking if you notice any glaring
> issues with this patch, as it won't be the first time it has been resent after
> not being looked at for some time.
I haven't look at this code before and only skimmed it now, but your
patch looks correct to me.
Johan
next prev parent reply other threads:[~2023-12-20 8:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 21:18 [PATCH v4 1/2] dt-bindings: leds: qcom-lpg: Add compatible for PM660L LPG block Marijn Suijten
2022-07-19 21:18 ` [PATCH v4 2/2] leds: qcom-lpg: Add PM660L configuration and compatible Marijn Suijten
2023-12-19 8:22 ` Johan Hovold
2023-12-19 9:17 ` Marijn Suijten
2023-12-19 9:33 ` Johan Hovold
2023-12-19 10:06 ` Marijn Suijten
2023-12-20 8:09 ` Johan Hovold [this message]
2024-02-04 17:29 ` Marijn Suijten
2022-07-21 17:12 ` [PATCH v4 1/2] dt-bindings: leds: qcom-lpg: Add compatible for PM660L LPG block Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYKhVlgrlvq3HbFt@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jami.kettunen@somainline.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=quic_c_skakit@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).