From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
the arch/x86 maintainers <x86@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [GIT PULL] x86/mm changes for v6.8
Date: Tue, 9 Jan 2024 09:28:33 +0100 [thread overview]
Message-ID: <ZZ0DsS7LGJO0NAq6@gmail.com> (raw)
In-Reply-To: <CAHk-=wi9aEe9BuiM2DQNsGoUg=ZeQS6EfOs+0pz3kTZ=qvf=pg@mail.gmail.com>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Mon, 8 Jan 2024 at 03:35, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > - Robustify pfn_to_kaddr()
> >
> > - Improve the __untagged_addr() code: RIP-relative addresses are fine these days
> > and generate better code, and update misleading/outdated comments as well.
>
> This does not even compile for me.
>
> arch/x86/include/asm/uaccess_64.h: In function ‘__untagged_addr’:
> arch/x86/include/asm/uaccess_64.h:25:28: error: implicit declaration
> of function ‘__my_cpu_var’; did you mean ‘put_cpu_var’?
> [-Werror=implicit-function-declaration]
>
> WTH?
>
> Maybe this has worked in your tree by mistake because there was some
> branch dependency that just happened to work out because you had
> merged things in a different order.
>
> But that would very much not be ok regardless. Those branches should
> be tested independently, and clearly they were not.
Sorry about that and agreed. Indeed the build failure was hidden by another
branch, and while I did test-build and test-boot the x86/mm branch before
sending it out, but my test config didn't have CONFIG_ADDRESS_MASKING=y ...
which ... masked the build failure. The bots that do per-tree testing
didn't catch this either.
I've now sorted it out in our trees, will send the new x86/mm in a few days.
Thanks,
Ingo
prev parent reply other threads:[~2024-01-09 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 11:35 [GIT PULL] x86/mm changes for v6.8 Ingo Molnar
2024-01-09 2:06 ` Linus Torvalds
2024-01-09 3:57 ` Linus Torvalds
2024-01-09 8:34 ` Ingo Molnar
2024-01-09 8:28 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZ0DsS7LGJO0NAq6@gmail.com \
--to=mingo@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).