linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Martin <Dave.Martin@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Edmund Grimley-Evans <edmund.grimley-evans@arm.com>
Subject: Re: [PATCH 1/4] arm64/sve: Remove bitrotted comment about syscall behaviour
Date: Tue, 23 Jan 2024 15:44:23 +0000	[thread overview]
Message-ID: <Za/e15zUOEaa1b7d@e133380.arm.com> (raw)
In-Reply-To: <20240122-arm64-sve-sme-doc-v1-1-3d492e45265b@kernel.org>

On Mon, Jan 22, 2024 at 08:41:51PM +0000, Mark Brown wrote:
> When we documented that we always clear state not shared with FPSIMD we

Where / when?

> didn't catch all of the places that mentioned that state might not be
> cleared, remove a lingering reference.
> 
> Reported-by: Edmund Grimley-Evans <edmund.grimley-evans@arm.com>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  Documentation/arch/arm64/sve.rst | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/Documentation/arch/arm64/sve.rst b/Documentation/arch/arm64/sve.rst
> index 0d9a426e9f85..b45a2da19bf1 100644
> --- a/Documentation/arch/arm64/sve.rst
> +++ b/Documentation/arch/arm64/sve.rst
> @@ -117,11 +117,6 @@ the SVE instruction set architecture.
>  * The SVE registers are not used to pass arguments to or receive results from
>    any syscall.
>  
> -* In practice the affected registers/bits will be preserved or will be replaced
> -  with zeros on return from a syscall, but userspace should not make
> -  assumptions about this.  The kernel behaviour may vary on a case-by-case
> -  basis.
> -

This was originally an intentionally conservative statement, to allow
the kernel the flexibility to relax the register zeroing behaviour in
the future.  It would have permitted not always disabling a task's SVE
across a syscall, for example.  There were some concerns about security
and testability that meant that we didn't use this flexibility to begin
with.

If we are making an irrevocable commitment not to use this flexibility
ever, then this comment can go, but if we're not totally sure then I
think it would be harmless to keep it (?)

(Feel free to point me to the relevant past discussion that I may have
missed.)

[...]

Cheers
---Dave

  reply	other threads:[~2024-01-23 15:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 20:41 [PATCH 0/4] arm64/fp: Documentation cleanups and clarifications Mark Brown
2024-01-22 20:41 ` [PATCH 1/4] arm64/sve: Remove bitrotted comment about syscall behaviour Mark Brown
2024-01-23 15:44   ` Dave Martin [this message]
2024-01-23 17:31     ` Mark Brown
2024-01-23 17:54       ` Dave Martin
2024-01-23 18:11         ` Mark Brown
2024-01-24 14:04           ` Dave Martin
2024-01-22 20:41 ` [PATCH 2/4] arm64/sme: Fix cut'n'paste in ABI document Mark Brown
2024-01-22 20:41 ` [PATCH 3/4] arm64/fp: Clarify effect of setting an unsupported system VL Mark Brown
2024-01-23 15:49   ` Dave Martin
2024-01-23 18:42     ` Mark Brown
2024-01-24 14:09       ` Dave Martin
2024-01-22 20:41 ` [PATCH 4/4] arm64/sme: Remove spurious 'is' in SME documentation Mark Brown
2024-01-23 15:50   ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Za/e15zUOEaa1b7d@e133380.arm.com \
    --to=dave.martin@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=edmund.grimley-evans@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).