From: Frank Li <Frank.li@nxp.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
manivannan.sadhasivam@linaro.org, bhelgaas@google.com,
conor+dt@kernel.org, devicetree@vger.kernel.org,
festevam@gmail.com, hongxing.zhu@nxp.com, imx@lists.linux.dev,
kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org,
krzysztof.kozlowski@linaro.org, kw@linux.com,
l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org,
linux-imx@nxp.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, lpieralisi@kernel.org,
s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH v9 05/16] PCI: imx6: Using "linux,pci-domain" as slot ID
Date: Fri, 2 Feb 2024 20:01:05 -0500 [thread overview]
Message-ID: <Zb2QUTenlj3kEeE/@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20240202225116.GA732628@bhelgaas>
On Fri, Feb 02, 2024 at 04:51:16PM -0600, Bjorn Helgaas wrote:
> [Rob to to: line]
>
> On Fri, Feb 02, 2024 at 05:22:07PM -0500, Frank Li wrote:
> > On Fri, Feb 02, 2024 at 03:54:31PM -0600, Bjorn Helgaas wrote:
> > > On Fri, Jan 19, 2024 at 12:11:11PM -0500, Frank Li wrote:
> > > > Avoid use get slot id by compared with register physical address. If there
> > > > are more than 2 slots, compared logic will become complex.
> > > >
> > > > "linux,pci-domain" already exist at dts since commit:
> > > > commit (c0b70f05c87f3b arm64: dts: imx8mq: use_dt_domains for pci node).
> > > >
> > > > So it is safe to remove compare basic address code:
> > > > ...
> > > > if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR)
> > > > imx6_pcie->controller_id = 1;
> > > > ...
> > >
> > > I have no idea what this is telling me. I guess you don't want to use
> > > IMX8MQ_PCIE2_BASE_ADDR to decide something? That much sounds good:
> > > the *address* of some MMIO space doesn't tell us anything about the
> > > function of that space.
> >
> > You are right. If there are more than two controller. The check logic
> > will be extremely complex.
> >
> > There are some discussin at below thread about linux,pci-domain
> > https://lore.kernel.org/imx/20231206165953.GA717921@bhelgaas/
>
> My response here was too low level, just about trivial syntactic and
> style issues. I should have seen the larger issue at the time; sorry
> about that.
>
> > https://lore.kernel.org/imx/20231217175158.GF6748@thinkpad/
>
> That's a good response from Mani, but again not relevant to my point.
>
> My point here is that "compatible" should tell the driver how to
> operate the device, i.e., the driver knows what registers are present
> and how they work.
>
> If you have two variant devices that both implement a register that
> can be used to distinguish them, a single "compatible" string might be
> enough because the driver can use that register to tell the
> difference.
>
> If the driver can't tell the difference by looking at the hardware
> itself, I think you need a separate "compatible" string for it. Of
> course I'm far from a DT expert, so please correct this if necessary,
> Rob, et al.
>
> > > I expect the "compatible" string to tell the driver what the
> > > programming model of the device is.
> > >
> > > > + /* Using linux,pci-domain as PCI slot id */
> > > > + imx6_pcie->controller_id = of_get_pci_domain_nr(node);
> > > > + /*
> > > > + * If there are no "linux,pci-domain" property specified in DT, then assume only one
> > > > + * controller is available.
> > > > + */
> > > > + if (imx6_pcie->controller_id == -EINVAL)
> > > > + imx6_pcie->controller_id = 0;
> > > > + else if (imx6_pcie->controller_id < 0)
> > > > + return dev_err_probe(dev, imx6_pcie->controller_id,
> > > > + "linux,pci-domain have wrong value\n");
> > >
> > > Maybe I'm missing something here. It looks like this driver uses
> > > controller_id to distinguish between hardware variants or maybe
> > > between two Root Ports (slots?) in the same SoC?
> >
> > Yes!
> >
> > > imx6_pcie_grp_offset
> > > return imx6_pcie->controller_id == 1 ? IOMUXC_GPR16 : IOMUXC_GPR14;
> > >
> > > imx6_pcie_configure_type
> > > id = imx6_pcie->controller_id
> > > if (!drvdata->mode_mask[id]) # <-- looks unsafe
> >
> > I can add safe check here.
> >
> > > id = 0;
> > > regmap_update_bits(drvdata->mode_off[id], ...)
> > >
> > > (This "mode_mask[id]" looks like it will reference garbage if the DT
> > > supplies "linux,pci-domain = <2>". A bogus DT shouldn't be able to
> > > cause a driver to misbehave like that.)
> >
> > Suppose I can use dt-bind doc to force to 0,1 and safe check here.
>
> Nope. The driver must protect itself from garbage in the DT.
>
> > > That doesn't seem related to "linux,pci-domain" at all.
> >
> > I added comments about
> > /* Using linux,pci-domain as PCI slot id */
>
> That doesn't make it related :)
Okay, linux,pci-domain is not good method for this. Anyways, previous
implement is wrong.
Let me skip it and think a better method to fix this problem later.
Frank
>
> > We may add new property about controller-id, but there already have common
> > one "linux,pci-domain", which value in upstreamed dts exactly match our
> > expection, I also found other platform use it as slot id in kernel tree.
> >
> > Any way, we can continue discuss the better solution here. But I hope
> > it was not block whole 16 patches. we can skip this one firstly.
> >
> > I still have more than 10 clean up patches my local tree.
> >
> > >
> > > Bjorn
next prev parent reply other threads:[~2024-02-03 1:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 17:11 [PATCH v9 00/16] PCI: imx6: Clean up and add imx95 pci support Frank Li
2024-01-19 17:11 ` [PATCH v9 01/16] PCI: imx6: Simplify clock handling by using clk_bulk*() function Frank Li
2024-01-19 17:11 ` [PATCH v9 02/16] PCI: imx6: Simplify phy handling by using IMX6_PCIE_FLAG_HAS_PHYDRV Frank Li
2024-01-19 17:11 ` [PATCH v9 03/16] PCI: imx6: Simplify reset handling by using by using *_FLAG_HAS_*_RESET Frank Li
2024-01-19 17:11 ` [PATCH v9 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ Frank Li
2024-01-19 17:11 ` [PATCH v9 05/16] PCI: imx6: Using "linux,pci-domain" as slot ID Frank Li
2024-02-02 12:12 ` Lorenzo Pieralisi
2024-02-02 13:25 ` Frank Li
2024-02-02 18:53 ` Lorenzo Pieralisi
2024-02-05 17:41 ` Frank Li
2024-02-02 21:54 ` Bjorn Helgaas
2024-02-02 22:22 ` Frank Li
2024-02-02 22:51 ` Bjorn Helgaas
2024-02-03 1:01 ` Frank Li [this message]
2024-01-19 17:11 ` [PATCH v9 06/16] PCI: imx6: Simplify ltssm_enable() by using ltssm_off and ltssm_mask Frank Li
2024-01-19 17:11 ` [PATCH v9 07/16] PCI: imx6: Simplify configure_type() by using mode_off and mode_mask Frank Li
2024-02-13 10:57 ` Lorenzo Pieralisi
2024-01-19 17:11 ` [PATCH v9 08/16] PCI: imx6: Simplify switch-case logic by involve init_phy callback Frank Li
2024-01-19 17:11 ` [PATCH v9 09/16] dt-bindings: imx6q-pcie: Clean up irrationality clocks check Frank Li
2024-01-19 17:11 ` [PATCH v9 10/16] dt-bindings: imx6q-pcie: Restruct reg and reg-name Frank Li
2024-01-23 20:36 ` Rob Herring
2024-01-19 17:11 ` [PATCH v9 11/16] dt-bindings: imx6q-pcie: Add imx95 pcie compatible string Frank Li
2024-01-19 17:11 ` [PATCH v9 12/16] PCI: imx6: Add iMX95 PCIe Root Complex support Frank Li
2024-01-19 17:11 ` [PATCH v9 13/16] PCI: imx6: Clean up get addr_space code Frank Li
2024-01-19 17:11 ` [PATCH v9 14/16] PCI: imx6: Add epc_features in imx6_pcie_drvdata Frank Li
2024-01-19 17:11 ` [PATCH v9 15/16] dt-bindings: imx6q-pcie: Add iMX95 pcie endpoint compatible string Frank Li
2024-01-19 17:11 ` [PATCH v9 16/16] PCI: imx6: Add iMX95 Endpoint (EP) support Frank Li
2024-02-13 10:38 ` Lorenzo Pieralisi
2024-02-13 13:23 ` Robin Murphy
2024-02-13 15:35 ` Frank Li
2024-01-25 15:31 ` [PATCH v9 00/16] PCI: imx6: Clean up and add imx95 pci support Frank Li
2024-02-01 19:34 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zb2QUTenlj3kEeE/@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=helgaas@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).