linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Bjorn Helgaas" <helgaas@kernel.org>,
	"Johan Hovold" <johan+linaro@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/12] arm64: dts: qcom: sc8280xp: PCIe fixes and GICv3 ITS enable
Date: Thu, 29 Feb 2024 16:37:27 +0100	[thread overview]
Message-ID: <ZeCktwcEFAfCEVkV@hovoldconsulting.com> (raw)
In-Reply-To: <20240229135407.GE2999@thinkpad>

On Thu, Feb 29, 2024 at 07:24:07PM +0530, Manivannan Sadhasivam wrote:
> On Thu, Feb 29, 2024 at 02:10:21PM +0100, Johan Hovold wrote:

> > I think that based on the available data it's reasonable to go ahead and
> > merge these patches. In the event that this turns out to be a
> > configuration issue, we can just drop the 'aspm-no-l0s' properties
> > again.
> 
> Well the problem is, if you are not sure, then adding the DT properties is
> certainly not correct. As that implies a hardware defect, but it may not be.
> So let's wait for some time to find out the actual issue.

Our devicetrees are always going to be a tentative description of the
hardware, and this especially true for Qualcomm that don't publish any
documentation so that people are forced to rely on informed guesses
based on downstream devicetrees and drivers and reverse engineering.

As far as I can tell, after having spent a lot of time on this and
checking with sources inside Qualcomm, the hardware is to blame here. If
this turns out not to be true, we can always revise later. We do this
all the time, as you know.

I'm all for digging further into this issue with the help of Qualcomm,
but I don't think that should block this series as that would leave the
link errors that we hit since 6.7 in place and effectively prevent us
from enabling the ITS in 6.9.

Johan

  reply	other threads:[~2024-02-29 15:37 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 15:21 [PATCH v2 00/12] arm64: dts: qcom: sc8280xp: PCIe fixes and GICv3 ITS enable Johan Hovold
2024-02-23 15:21 ` [PATCH v2 01/12] dt-bindings: PCI: qcom: Allow 'required-opps' Johan Hovold
2024-02-23 15:21 ` [PATCH v2 02/12] dt-bindings: PCI: qcom: Do not require 'msi-map-mask' Johan Hovold
2024-02-23 15:21 ` [PATCH v2 03/12] dt-bindings: PCI: qcom: Allow 'aspm-no-l0s' Johan Hovold
2024-03-01 21:12   ` Rob Herring
2024-02-23 15:21 ` [PATCH v2 04/12] PCI: qcom: Add support for disabling ASPM L0s in devicetree Johan Hovold
2024-02-23 22:10   ` Bjorn Helgaas
2024-02-27 15:29     ` Johan Hovold
2024-02-28 22:02       ` Bjorn Helgaas
2024-02-23 15:21 ` [PATCH v2 05/12] arm64: dts: qcom: sc8280xp: add missing PCIe minimum OPP Johan Hovold
2024-02-23 21:25   ` Konrad Dybcio
2024-02-23 15:21 ` [PATCH v2 06/12] arm64: dts: qcom: sc8280xp-crd: limit pcie4 link speed Johan Hovold
2024-02-23 21:25   ` Konrad Dybcio
2024-02-23 15:21 ` [PATCH v2 07/12] arm64: dts: qcom: sc8280xp-x13s: " Johan Hovold
2024-02-23 21:25   ` Konrad Dybcio
2024-02-23 15:21 ` [PATCH v2 08/12] arm64: dts: qcom: sc8280xp-crd: disable ASPM L0s for NVMe Johan Hovold
2024-02-23 21:25   ` Konrad Dybcio
2024-02-23 15:21 ` [PATCH v2 09/12] arm64: dts: qcom: sc8280xp-crd: disable ASPM L0s for modem and Wi-Fi Johan Hovold
2024-02-23 15:21 ` [PATCH v2 10/12] arm64: dts: qcom: sc8280xp-x13s: disable ASPM L0s for Wi-Fi Johan Hovold
2024-02-23 15:21 ` [PATCH v2 11/12] arm64: dts: qcom: sc8280xp-x13s: disable ASPM L0s for NVMe and modem Johan Hovold
2024-02-23 15:21 ` [PATCH v2 12/12] arm64: dts: qcom: sc8280xp: enable GICv3 ITS for PCIe Johan Hovold
2024-02-28 22:08 ` [PATCH v2 00/12] arm64: dts: qcom: sc8280xp: PCIe fixes and GICv3 ITS enable Bjorn Helgaas
2024-02-28 23:30   ` Konrad Dybcio
2024-02-29  7:49     ` Johan Hovold
2024-02-29  7:45   ` Johan Hovold
2024-02-29 10:08   ` Manivannan Sadhasivam
2024-02-29 10:25     ` Johan Hovold
2024-02-29 12:24       ` Manivannan Sadhasivam
2024-02-29 13:10         ` Johan Hovold
2024-02-29 13:54           ` Manivannan Sadhasivam
2024-02-29 15:37             ` Johan Hovold [this message]
2024-03-01 12:24               ` Manivannan Sadhasivam
2024-03-01 12:46                 ` Johan Hovold
2024-03-01 13:14                   ` Manivannan Sadhasivam
2024-03-01 13:57                     ` Johan Hovold
2024-02-29 20:52           ` Bjorn Helgaas
2024-03-01  8:09             ` Johan Hovold
2024-03-01 15:01             ` Bjorn Andersson
2024-03-03 19:50 ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZeCktwcEFAfCEVkV@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=helgaas@kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kw@linux.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).