From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7DFF535AB for ; Mon, 4 Mar 2024 15:39:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709566796; cv=none; b=mK758P9YJuMTuuwnZBkWhV/JCDQN+05swgfCdyQCbinQJWTDoDZcsk0YYViF/wNnYoUJ4nz0EbpY/A5BKTaOilAn/bKbLetzcooemdnHH8WX2ccplrZsnL/Ix0AAhtpRV7HsAEXMB45BrpnbiZ6rVyna3TA2hYcotybDU23/kZg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709566796; c=relaxed/simple; bh=shQrjEt62qkuY/PEPStknZIEtYwjLi3R46vtgT1Gjwc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=SdldsXFZrSZCIFiExWOq312LJ1BU59X7A/35Nkt25ZrqdoFQVaX247lk8vT7s0ckq28Hsixkzz4YeNbYPI+gN5YSr9tlVELUA38+E/NpaTsXS736ANGAZy/LNrfJM2afWPQK/AsZlhPbpNpe8icLfV5OK/Rsc6qu5R3qYVCenW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=pjQOMd9n; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pjQOMd9n" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-6e558491ca6so4090460b3a.2 for ; Mon, 04 Mar 2024 07:39:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709566794; x=1710171594; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Vza9xWJMXOMUri344+UMmZGvA7Qs+hM6357mmEmwEZU=; b=pjQOMd9ntKgLhGB0Prv65OAcE80OkcwUX72BaC+ODFy3DF2VvGvs7jocIWw+2pdHGw 0BQfUMusgpcNd4NmMwX6yF+PmFKYiiNL++7P2xo9L/xBE/9dVZ64A1QQqGeAmJEf44jn xOPyYxMloJKL4+CxP01+GDyhFZP8eaWkbDop04MWi0a1r4vT6zga636ubygtbLUZTk42 ZeFbKIzByn1EYFKC8QqHC9J+F0DHwPGXSqfGV3bSvRnF3vMSpOxqqcxcjBMVm1OwfbV4 IKlAKTfNNi5K3Vvg5+A17yKpaaSNBt4MSXxfpUN9TcESD/63fw2yMn0H8nnYGIrg9HXe YNCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709566794; x=1710171594; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vza9xWJMXOMUri344+UMmZGvA7Qs+hM6357mmEmwEZU=; b=vbJHyJ0+hE1miRs6NCNFQb8fHn7F/Tx9hEruwLSGH8a9i5YuvK9xkeLHq0UAQK9Ts6 YoTZMcClQujTafxsFtVq5xQ2yepqaT5wiCGAn2sdtrK+tnvb9SDPZJIt9t43IpQQFJ6z kO+6b1doLsN4JzxXyVyEYAqw6wnnIgK4vMkka75Whbvy1VTRJXS5ivHMI8sGiOcnqAIo RHxlQpx1RZU4M1OqR64CD1cSA3/LZXMpXWBnYglZ1JL9/WFoedJ6pbDIh6lkVhTDAJ3M 32bVmM77ecaprU57hKuw+aatcUDRRjR+9ao5uCGI9u9EWEOEmpdnMxM75rAgKl0YG6dU dboA== X-Forwarded-Encrypted: i=1; AJvYcCW0RQt/Q5K+WXiSWi0PNplU0iXKXDAldk2oLUhwCykEwFrnSfP68cFesxmuVCXTa69v0ECq3e6i5x1ksWTsV/IaXUZ+FJP/ZolYAHmf X-Gm-Message-State: AOJu0Yzb5LU0nsiW3ojnQIkDmwkNNsj/xtKL96hlC5o6O/6YJcIpYvxI 95LXf0qdzWT5CkNZLSlmBjTiGa7kbEUV0dMcnnECDFMgtlNNIyRxQC6NMlnIf/ef2NhR+aqgfdm WQQ== X-Google-Smtp-Source: AGHT+IH+lj9uy1KSWDnGhyh8OoTAL1gU4I5lO/6UR1uXo/NLjfLp9ky0/KzkJTbFzvyLJhRWyCTcvSv2+Vk= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:3cca:b0:6e5:94b0:68be with SMTP id ln10-20020a056a003cca00b006e594b068bemr776208pfb.2.1709566793867; Mon, 04 Mar 2024 07:39:53 -0800 (PST) Date: Mon, 4 Mar 2024 07:39:52 -0800 In-Reply-To: <754f2fcf-fc00-4f89-a17c-a80bbec1e2ff@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240227232100.478238-1-pbonzini@redhat.com> <20240227232100.478238-14-pbonzini@redhat.com> <754f2fcf-fc00-4f89-a17c-a80bbec1e2ff@intel.com> Message-ID: Subject: Re: [PATCH 13/21] KVM: x86/mmu: Pass around full 64-bit error code for KVM page faults From: Sean Christopherson To: Xiaoyao Li Cc: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, michael.roth@amd.com, isaku.yamahata@intel.com, thomas.lendacky@amd.com Content-Type: text/plain; charset="us-ascii" On Mon, Mar 04, 2024, Xiaoyao Li wrote: > On 2/28/2024 7:20 AM, Paolo Bonzini wrote: > > From: Isaku Yamahata > > > ... > > The use of lower_32_bits() moves from kvm_mmu_page_fault() to > > FNAME(page_fault), since walking is independent of the data in the > > upper bits of the error code. > > Is it a must? I don't see any issue if full u64 error_code is passed to > FNAME(page_fault) as well. Heh, my thought as well. https://lore.kernel.org/all/20240228024147.41573-5-seanjc@google.com