linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: <cristian.marussi@arm.com>, <rafael@kernel.org>,
	<viresh.kumar@linaro.org>, <morten.rasmussen@arm.com>,
	<dietmar.eggemann@arm.com>, <lukasz.luba@arm.com>,
	<sboyd@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<quic_mdtipton@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
	<nm@ti.com>
Subject: Re: [PATCH V3 2/2] cpufreq: scmi: Enable boost support
Date: Fri, 8 Mar 2024 14:06:13 +0000	[thread overview]
Message-ID: <ZesbVW0dDd1i2F_F@bogus> (raw)
In-Reply-To: <20240308104410.385631-3-quic_sibis@quicinc.com>

On Fri, Mar 08, 2024 at 04:14:10PM +0530, Sibi Sankar wrote:
> The X1E80100 SoC hosts a number of cpu boost frequencies, so let's enable
> boost support if the freq_table has any opps marked as turbo in it.
>

I had asked if you could put the information about how and when the boost
frequencies are used, it would be useful for reference purposes when someone
attempts to use this feature. But it is not a blocker, just good to have
info.

Also I would not sure specific platform name, just refer as certain platforms
as it such information becomes stale soon.

Anyways apart for those nits on the commit message, this looks good.

Reviewed-by: <viresh.kumar@linaro.org>

I am assuming Viresh might take both these changes for via his tree. If not,
I can take it for v6.10 after v6.9-rc1

-- 
Regards,
Sudeep

  reply	other threads:[~2024-03-08 14:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08 10:44 [PATCH V3 0/2] cpufreq: scmi: Add boost frequency support Sibi Sankar
2024-03-08 10:44 ` [PATCH V3 1/2] firmware: arm_scmi: Add support for marking certain frequencies as boost Sibi Sankar
2024-03-08 13:59   ` Sudeep Holla
2024-03-11  5:35   ` Dhruva Gole
2024-03-11  5:49     ` Viresh Kumar
2024-03-08 10:44 ` [PATCH V3 2/2] cpufreq: scmi: Enable boost support Sibi Sankar
2024-03-08 14:06   ` Sudeep Holla [this message]
2024-03-11  4:55     ` Viresh Kumar
2024-03-11  9:04       ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZesbVW0dDd1i2F_F@bogus \
    --to=sudeep.holla@arm.com \
    --cc=cristian.marussi@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=morten.rasmussen@arm.com \
    --cc=nm@ti.com \
    --cc=quic_mdtipton@quicinc.com \
    --cc=quic_sibis@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).