From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE6CF5102F for ; Fri, 15 Mar 2024 19:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710530434; cv=none; b=oIVTq7NuG59mThBTshcF0klZEUZIrwBZJMHhHwENqpuSTOYC/FD1NLiu9Ut9PK3rIJBulaO1ycGW285IN+4PSDdPSNw2l9IuApq8q5a9Q4QEk66OaVtQgtElPeFqZ3GkRx0AACgctDTFIA0drswOfmbXKUWku+9PbGYFRwI70oc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710530434; c=relaxed/simple; bh=mrTyWLKNzbPd+Es/f7k4riqHuUAgAcAswomjRq95eU4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=WmchQkqYlwR3woIck5NFglqDgx+RVzPOg2JYHtsNMl93AlXAObbRGGuuuygmjbbpfVHlFoiPqJuEuu/yOFWCIAWvRNmUxhypZ5Ju36kmaLskE9/SA6f/msQm0B8fQqav5I1tAlXACtmFNR18LXroZwAfKIWte17rTSH+hYGkxek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kviWD2WK; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kviWD2WK" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-60a55cd262aso44385427b3.2 for ; Fri, 15 Mar 2024 12:20:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710530432; x=1711135232; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=xGq29qQOFJv52Q4bTVIictDDuC4jaHMG/xiohXW6Wrg=; b=kviWD2WKAigKRar70oD9qu8aC7dtFGyvNC/LCAN/xCb7nbKp3EBPg06czInnlqpI/s R2WNYWVE0IbWislcHkYB+wpXJPTlu//bEGREcfXhCNmyoWPUVj7FJsK2pVKvnXohmYGf yncTTfjNebks31Mo8X19QxusyOk2MlGOaCfCCazMPKQ7ZP91lvPt9CQ/2mArHKpp58wl Dx7K4ZMt9ceVime903PCacPb9ltmG7tONmw75xBglBPBSSvD/x2JMuXehlLaJ1c5Rvwy flPh+hciran1gXkSCa0O0zTfd4vmbnLAY46+VVGCgmWPWrgMn+/hO7Tc16AcpDnHcmNO 1jqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710530432; x=1711135232; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xGq29qQOFJv52Q4bTVIictDDuC4jaHMG/xiohXW6Wrg=; b=U9mXSREMcUzysslvblGtAOgE8uXqCNrHD6V1lcDuD1EP1Kmw52ilwAD4hOikhK+M8o aFF9JhWakxLmLpL0g9oyMTkCt4oogpysjGhS25n+qQFH2wMfCe5jlRomywje8LCVU4AM 8roXNYBOJg6PrvV739VKtDXStbJfDb4k0LkZXtw2QbrVyLjq41EBfKHEJnt1U+HJncmB 7NUkZaCeG6CE5j1O5kHz+SQ5qSLNJoVMmXk0kYm5kJzHccnHsTWBZ79+daBxmZQvznso L6MMzy8QN8eXMm/80eqwvNVyKm1TCw/BGFAzuJiiUGZQHuFejfmdp0pGwouTRQeA6CP6 grog== X-Forwarded-Encrypted: i=1; AJvYcCW2Ja/FWpjjQs46aBLFzbWpK7IWb2WPWsIXyCWWrcvv4X7dnuhUfPPMPE1f/f95ZjzFqkVS5hbqdT0Aegsn2Zh/8gWDx/79KZizwCBT X-Gm-Message-State: AOJu0Yz92SqO9bf4svYEIJAoR6d/b/lhXH7o17c1GvsR6+spr0jnKysi 6R2Ap3Co6HwnSfr/yns0q6JT9CFAiib+XaWiCiK+Kdt0QqAwvJ8LieP6PY2lSnFsDsQp6fnqkEi Xig== X-Google-Smtp-Source: AGHT+IF6S3TxprvwoJU2GOkok9Zi0eiF/NCn2IJTYEv9k7CxvacWoa7pAyS5+65wdo+4/6YoHFi411jrrjk= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a0d:db03:0:b0:608:72fe:b8a1 with SMTP id d3-20020a0ddb03000000b0060872feb8a1mr1377179ywe.4.1710530431809; Fri, 15 Mar 2024 12:20:31 -0700 (PDT) Date: Fri, 15 Mar 2024 12:20:30 -0700 In-Reply-To: <07b75e0f18a5082a91f80fb234d29c97489e2f75.camel@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <8f64043a6c393c017347bf8954d92b84b58603ec.1708933498.git.isaku.yamahata@intel.com> <54ae3bbb-34dc-4b10-a14e-2af9e9240ef1@intel.com> <07b75e0f18a5082a91f80fb234d29c97489e2f75.camel@intel.com> Message-ID: Subject: Re: [PATCH v19 007/130] x86/virt/tdx: Export SEAMCALL functions From: Sean Christopherson To: Rick P Edgecombe Cc: Dave Hansen , Tina Zhang , Hang Yuan , Kai Huang , "x86@kernel.org" , Bo Chen , "sagis@google.com" , "linux-kernel@vger.kernel.org" , "isaku.yamahata@gmail.com" , Erdem Aktas , "kvm@vger.kernel.org" , "pbonzini@redhat.com" , Isaku Yamahata Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Fri, Mar 15, 2024, Rick P Edgecombe wrote: > On Fri, 2024-03-15 at 10:46 -0700, Sean Christopherson wrote: > > On Fri, Mar 15, 2024, Sean Christopherson wrote: > > > So my feedback is to not worry about the exports, and instead focus o= n > > > figuring out a way to make the generated code less bloated and easier= to > > > read/debug. > >=20 > > Oh, and please make it a collaborative, public effort.=C2=A0 I don't wa= nt to > > hear crickets and then see v20 dropped with a completely new SEAMCALL > > scheme. >=20 > And here we we're worrying that people might eventually grow tired of > us adding mails to v19 and we debate every detail in public. Will do. As a general rule, I _strongly_ prefer all review to be done on-list, in pu= blic. Copy+pasting myself from another Intel series[*] : Correct, what I object to is Intel _requiring_ a Reviewed-by before post= ing. :=20 : And while I'm certainly not going to refuse patches that have been revie= wed : internally, I _strongly_ prefer reviews be on-list so that they are publ= ic and : recorded. Being able to go back and look at the history and evolution o= f patches : is valuable, and the discussion itself is often beneficial to non-partic= ipants, : e.g. people that are new-ish to KVM and/or aren't familiar with the feat= ure being : enabled can often learn new things and avoid similar pitfalls of their o= wn. There are definitely situations where exceptions are warranted, e.g. if som= eone is a first-time poster and/or wants a sanity check to make sure their idea = isn't completely crazy. But even then, the internal review should only be very c= ursory. In addition to the history being valuable, doing reviews in public minimize= s the probability of a developer being led astray, e.g. due to someone internally= saying do XYZ, and then upstream reviewers telling them to do something entirely d= ifferent.=20 As far as noise goes, look at it this way. Every time a new TDX series is = posted, I get 130+ emails. Y'all can do a _lot_ of public review and discussion be= fore you'll get anywhere near the point where it'd be noiser than spinning a new= version of the series. [*] https://lore.kernel.org/all/Y+ZxLfCrcTQ6poYg@google.com