From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Ayush Singh <ayushdevel1325@gmail.com>
Cc: linux-kernel@vger.kernel.org, jkridner@beagleboard.org,
robertcnelson@beagleboard.org,
Vaishnav M A <vaishnav@beagleboard.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Nishanth Menon <nm@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>,
Derek Kiernan <derek.kiernan@amd.com>,
Dragan Cvetic <dragan.cvetic@amd.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jiri Slaby <jirislaby@kernel.org>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-spi@vger.kernel.org, linux-serial@vger.kernel.org,
greybus-dev@lists.linaro.org
Subject: Re: [PATCH v3 2/8] w1: Add w1_find_master_device
Date: Fri, 15 Mar 2024 19:40:56 +0000 [thread overview]
Message-ID: <ZfSkSPD4dMe7qqhy@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240315184908.500352-3-ayushdevel1325@gmail.com>
On Sat, Mar 16, 2024 at 12:19:00AM +0530, Ayush Singh wrote:
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
> index afb1cc4606c5..ce8a3f93f2ef 100644
> --- a/drivers/w1/w1.c
> +++ b/drivers/w1/w1.c
> @@ -673,9 +673,9 @@ static int __w1_attach_slave_device(struct w1_slave *sl)
> sl->dev.of_node = of_find_matching_node(sl->master->dev.of_node,
> sl->family->of_match_table);
>
> - dev_set_name(&sl->dev, "%02x-%012llx",
> - (unsigned int) sl->reg_num.family,
> - (unsigned long long) sl->reg_num.id);
> + dev_set_name(&sl->dev, "%s-%02x-%012llx", sl->master->name,
> + (unsigned int)sl->reg_num.family,
> + (unsigned long long)sl->reg_num.id);
This is a user visible change likely to cause breakage. I know that I've
written programmes for reading the DS18B20 temperature probes that
depend on the sysfs device name remaining stable. The same is likely
true of other program authors.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-03-15 19:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 18:48 [PATCH v3 0/8] misc: Add mikroBUS driver Ayush Singh
2024-03-15 18:48 ` [PATCH v3 1/8] dt-bindings: misc: Add mikrobus-connector Ayush Singh
2024-03-15 20:09 ` Krzysztof Kozlowski
2024-03-15 20:20 ` Russell King (Oracle)
2024-03-15 20:40 ` Krzysztof Kozlowski
2024-03-15 21:00 ` Russell King (Oracle)
2024-03-17 20:59 ` Rob Herring
2024-03-18 12:37 ` Ayush Singh
2024-03-15 18:49 ` [PATCH v3 2/8] w1: Add w1_find_master_device Ayush Singh
2024-03-15 19:40 ` Russell King (Oracle) [this message]
2024-03-15 20:14 ` Krzysztof Kozlowski
2024-03-15 18:49 ` [PATCH v3 3/8] spi: Make of_find_spi_controller_by_node() available Ayush Singh
2024-03-15 18:49 ` [PATCH v3 4/8] serdev: add of_ helper to get serdev controller Ayush Singh
2024-03-15 20:16 ` Krzysztof Kozlowski
2024-03-15 18:49 ` [PATCH v3 5/8] regulator: fixed-helper: export regulator_register_always_on Ayush Singh
2024-03-15 18:49 ` [PATCH v3 6/8] greybus: Add mikroBUS manifest types Ayush Singh
2024-04-11 12:03 ` Greg Kroah-Hartman
2024-03-15 18:49 ` [PATCH v3 7/8] mikrobus: Add mikrobus driver Ayush Singh
2024-03-15 19:03 ` Mark Brown
2024-03-15 19:32 ` Russell King (Oracle)
[not found] ` <46ba778a-5966-4b99-b820-f0d047a56227@gmail.com>
2024-03-15 21:19 ` Russell King (Oracle)
2024-03-15 22:10 ` Vaishnav Achath
2024-03-15 20:35 ` Krzysztof Kozlowski
2024-03-16 13:06 ` Ayush Singh
2024-03-19 5:32 ` Krzysztof Kozlowski
2024-03-19 6:59 ` Ayush Singh
2024-03-20 11:56 ` Krzysztof Kozlowski
2024-03-16 8:18 ` kernel test robot
2024-03-16 9:00 ` kernel test robot
2024-03-15 18:49 ` [PATCH v3 8/8] dts: ti: k3-am625-beagleplay: Add mikroBUS Ayush Singh
2024-03-15 20:20 ` Krzysztof Kozlowski
2024-03-15 21:20 ` [PATCH v3 0/8] misc: Add mikroBUS driver Vaishnav M A
2024-03-15 21:41 ` Ayush Singh
2024-03-15 22:24 ` Vaishnav Achath
2024-03-17 14:41 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfSkSPD4dMe7qqhy@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=arnd@arndb.de \
--cc=ayushdevel1325@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=derek.kiernan@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@amd.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jirislaby@kernel.org \
--cc=jkridner@beagleboard.org \
--cc=johan@kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nm@ti.com \
--cc=robertcnelson@beagleboard.org \
--cc=robh@kernel.org \
--cc=vaishnav@beagleboard.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).