From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 241C4C432C3 for ; Thu, 14 Nov 2019 11:02:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 073A8206EF for ; Thu, 14 Nov 2019 11:02:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726755AbfKNLCF convert rfc822-to-8bit (ORCPT ); Thu, 14 Nov 2019 06:02:05 -0500 Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]:38931 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725977AbfKNLCF (ORCPT ); Thu, 14 Nov 2019 06:02:05 -0500 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-32-r_KPqAifMlOEtdi9ThEBSQ-1; Thu, 14 Nov 2019 11:02:01 +0000 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 14 Nov 2019 11:02:01 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Thu, 14 Nov 2019 11:02:01 +0000 From: David Laight To: 'Peter Zijlstra' , Thomas Gleixner CC: LKML , "x86@kernel.org" , Linus Torvalds , Andy Lutomirski , Stephen Hemminger , "Willy Tarreau" , Juergen Gross , Sean Christopherson , "H. Peter Anvin" Subject: RE: [patch V2 11/16] x86/ioperm: Share I/O bitmap if identical Thread-Topic: [patch V2 11/16] x86/ioperm: Share I/O bitmap if identical Thread-Index: AQHVmTnGMlCgX/wyC0irSyeDShf4MaeKgnHA Date: Thu, 14 Nov 2019 11:02:01 +0000 Message-ID: References: <20191111220314.519933535@linutronix.de> <20191111223052.603030685@linutronix.de> <20191112091521.GX4131@hirez.programming.kicks-ass.net> In-Reply-To: <20191112091521.GX4131@hirez.programming.kicks-ass.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-MC-Unique: r_KPqAifMlOEtdi9ThEBSQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra > Sent: 12 November 2019 09:15 ... > > + /* > > + * If the bitmap is not shared, then nothing can take a refcount as > > + * current can obviously not fork at the same time. If it's shared > > + * duplicate it and drop the refcount on the original one. > > + */ > > + if (refcount_read(&iobm->refcnt) > 1) { > > + iobm = kmemdup(iobm, sizeof(*iobm), GFP_KERNEL); > > + if (!iobm) > > + return -ENOMEM; > > + io_bitmap_exit(); > refcount_set(&iobm->refcnd, 1); > > } What happens if two threads of the same process enter the above at the same time? (I've not looked for a lock, but since kmemdup() can sleep I'd suspect there isn't one.) Also can another thread call fork() - eg while the kmemdup() is sleeping? David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)