From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753419AbdGJFwY (ORCPT ); Mon, 10 Jul 2017 01:52:24 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:36177 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753244AbdGJFwX (ORCPT ); Mon, 10 Jul 2017 01:52:23 -0400 Subject: Re: [PATCH] NVMe: Added another device ID with stripe quirk To: Christoph Hellwig , Keith Busch Cc: David Wayne Fugate , Jens Axboe , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <1499379151-32479-1-git-send-email-david.fugate@intel.com> <20170706221754.GA10217@lst.de> <20170706223955.GA1200@localhost.localdomain> <20170706232253.GA11119@lst.de> From: Sagi Grimberg Message-ID: Date: Mon, 10 Jul 2017 08:52:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170706232253.GA11119@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> That's true for all Intel controllers going forward, but this >> is actually an older controller that pre-dates NOIOB. It's the exact >> same as the 8086:0A54 model, but a particular vendor decided their >> rebranded device needs to be made special with a different DID. > > Meh.. > >> >> We all agree that's a terrible way to go about this for mutliple reasons, >> but we can't go back in time to tell the decision makers of this folly. So >> I think we need to let this last one go through with the quirk. >> >> Acked-by: Keith Busch > > Reluctantly-accepted-by: Christoph Hellwig > David, can you resend the patch? For some reason I can't locate it in my mailbox...