From: Mike Kravetz <mike.kravetz@oracle.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: aarcange@redhat.com, hughd@google.com, nyc@holomorphy.com
Subject: Re: [PATCH v2 7/9] memfd-test: add 'memfd-hugetlb:' prefix when testing hugetlbfs
Date: Mon, 6 Nov 2017 17:31:39 -0800 [thread overview]
Message-ID: <a020e971-e84d-42aa-7523-86bbbb7244ba@oracle.com> (raw)
In-Reply-To: <20171106143944.13821-8-marcandre.lureau@redhat.com>
On 11/06/2017 06:39 AM, Marc-André Lureau wrote:
> Suggested-by: Mike Kravetz <mike.kravetz@oracle.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
> ---
> tools/testing/selftests/memfd/memfd_test.c | 26 ++++++++++++++++----------
> 1 file changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
> index cca957a06525..955d09ee16ca 100644
> --- a/tools/testing/selftests/memfd/memfd_test.c
> +++ b/tools/testing/selftests/memfd/memfd_test.c
> @@ -20,6 +20,7 @@
> #include <unistd.h>
>
> #define MEMFD_STR "memfd:"
> +#define MEMFD_HUGE_STR "memfd-hugetlb:"
> #define SHARED_FT_STR "(shared file-table)"
>
> #define MFD_DEF_SIZE 8192
> @@ -30,6 +31,7 @@
> */
> static int hugetlbfs_test;
> static size_t mfd_def_size = MFD_DEF_SIZE;
> +static const char *memfd_str = MEMFD_STR;
>
> /*
> * Copied from mlock2-tests.c
> @@ -606,7 +608,7 @@ static void test_create(void)
> char buf[2048];
> int fd;
>
> - printf("%s CREATE\n", MEMFD_STR);
> + printf("%s CREATE\n", memfd_str);
>
> /* test NULL name */
> mfd_fail_new(NULL, 0);
> @@ -652,7 +654,7 @@ static void test_basic(void)
> {
> int fd;
>
> - printf("%s BASIC\n", MEMFD_STR);
> + printf("%s BASIC\n", memfd_str);
>
> fd = mfd_assert_new("kern_memfd_basic",
> mfd_def_size,
> @@ -704,7 +706,7 @@ static void test_seal_write(void)
> {
> int fd;
>
> - printf("%s SEAL-WRITE\n", MEMFD_STR);
> + printf("%s SEAL-WRITE\n", memfd_str);
>
> fd = mfd_assert_new("kern_memfd_seal_write",
> mfd_def_size,
> @@ -730,7 +732,7 @@ static void test_seal_shrink(void)
> {
> int fd;
>
> - printf("%s SEAL-SHRINK\n", MEMFD_STR);
> + printf("%s SEAL-SHRINK\n", memfd_str);
>
> fd = mfd_assert_new("kern_memfd_seal_shrink",
> mfd_def_size,
> @@ -756,7 +758,7 @@ static void test_seal_grow(void)
> {
> int fd;
>
> - printf("%s SEAL-GROW\n", MEMFD_STR);
> + printf("%s SEAL-GROW\n", memfd_str);
>
> fd = mfd_assert_new("kern_memfd_seal_grow",
> mfd_def_size,
> @@ -782,7 +784,7 @@ static void test_seal_resize(void)
> {
> int fd;
>
> - printf("%s SEAL-RESIZE\n", MEMFD_STR);
> + printf("%s SEAL-RESIZE\n", memfd_str);
>
> fd = mfd_assert_new("kern_memfd_seal_resize",
> mfd_def_size,
> @@ -808,7 +810,7 @@ static void test_share_dup(char *banner, char *b_suffix)
> {
> int fd, fd2;
>
> - printf("%s %s %s\n", MEMFD_STR, banner, b_suffix);
> + printf("%s %s %s\n", memfd_str, banner, b_suffix);
>
> fd = mfd_assert_new("kern_memfd_share_dup",
> mfd_def_size,
> @@ -850,7 +852,7 @@ static void test_share_mmap(char *banner, char *b_suffix)
> int fd;
> void *p;
>
> - printf("%s %s %s\n", MEMFD_STR, banner, b_suffix);
> + printf("%s %s %s\n", memfd_str, banner, b_suffix);
>
> fd = mfd_assert_new("kern_memfd_share_mmap",
> mfd_def_size,
> @@ -884,7 +886,7 @@ static void test_share_open(char *banner, char *b_suffix)
> {
> int fd, fd2;
>
> - printf("%s %s %s\n", MEMFD_STR, banner, b_suffix);
> + printf("%s %s %s\n", memfd_str, banner, b_suffix);
>
> fd = mfd_assert_new("kern_memfd_share_open",
> mfd_def_size,
> @@ -927,7 +929,7 @@ static void test_share_fork(char *banner, char *b_suffix)
> int fd;
> pid_t pid;
>
> - printf("%s %s %s\n", MEMFD_STR, banner, b_suffix);
> + printf("%s %s %s\n", memfd_str, banner, b_suffix);
>
> fd = mfd_assert_new("kern_memfd_share_fork",
> mfd_def_size,
> @@ -963,7 +965,11 @@ int main(int argc, char **argv)
> }
>
> hugetlbfs_test = 1;
> + memfd_str = MEMFD_HUGE_STR;
> mfd_def_size = hpage_size * 2;
> + } else {
> + printf("Unknown option: %s\n", argv[1]);
> + abort();
> }
> }
>
>
next prev parent reply other threads:[~2017-11-07 1:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 14:39 [PATCH v2 0/9] memfd: add sealing to hugetlb-backed memory Marc-André Lureau
2017-11-06 14:39 ` [PATCH v2 1/9] shmem: unexport shmem_add_seals()/shmem_get_seals() Marc-André Lureau
2017-11-06 14:39 ` [PATCH v2 2/9] shmem: rename functions that are memfd-related Marc-André Lureau
2017-11-06 14:39 ` [PATCH v2 3/9] hugetlb: expose hugetlbfs_inode_info in header Marc-André Lureau
2017-11-06 14:39 ` [PATCH v2 4/9] hugetlbfs: implement memfd sealing Marc-André Lureau
2017-11-06 14:39 ` [PATCH v2 5/9] shmem: add sealing support to hugetlb-backed memfd Marc-André Lureau
2017-11-06 23:56 ` Mike Kravetz
2017-11-06 14:39 ` [PATCH v2 6/9] memfd-tests: test hugetlbfs sealing Marc-André Lureau
2017-11-07 1:30 ` Mike Kravetz
2017-11-06 14:39 ` [PATCH v2 7/9] memfd-test: add 'memfd-hugetlb:' prefix when testing hugetlbfs Marc-André Lureau
2017-11-07 1:31 ` Mike Kravetz [this message]
2017-11-06 14:39 ` [PATCH v2 8/9] memfd-test: move common code to a shared unit Marc-André Lureau
2017-11-07 1:32 ` Mike Kravetz
2017-11-06 14:39 ` [PATCH v2 9/9] memfd-test: run fuse test on hugetlb backend memory Marc-André Lureau
2017-11-07 1:41 ` Mike Kravetz
2017-11-07 12:12 ` Marc-André Lureau
2017-11-07 1:47 ` [PATCH v2 0/9] memfd: add sealing to hugetlb-backed memory Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a020e971-e84d-42aa-7523-86bbbb7244ba@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=aarcange@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcandre.lureau@redhat.com \
--cc=nyc@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).