From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0345EC7618B for ; Wed, 24 Jul 2019 06:12:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB732227BF for ; Wed, 24 Jul 2019 06:12:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726314AbfGXGMk (ORCPT ); Wed, 24 Jul 2019 02:12:40 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2711 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725945AbfGXGMj (ORCPT ); Wed, 24 Jul 2019 02:12:39 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id DB0DDD7CEC6E4F93575F; Wed, 24 Jul 2019 14:12:36 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.439.0; Wed, 24 Jul 2019 14:12:26 +0800 Subject: Re: [PATCH v2] RDMA/hns: Fix build error for hip08 To: , , , , References: <20190723024908.11876-1-yuehaibing@huawei.com> <20190724034016.15048-1-yuehaibing@huawei.com> CC: , From: Yuehaibing Message-ID: Date: Wed, 24 Jul 2019 14:12:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20190724034016.15048-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pls drop this, this cannot fix the issue. On 2019/7/24 11:40, YueHaibing wrote: > If INFINIBAND_HNS_HIP08 is selected and HNS3 is m, > but INFINIBAND_HNS is y, building fails: > > drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_exit': > hns_roce_hw_v2.c:(.exit.text+0xd): undefined reference to `hnae3_unregister_client' > drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_init': > hns_roce_hw_v2.c:(.init.text+0xd): undefined reference to `hnae3_register_client' > > Reported-by: Hulk Robot > Suggested-by: Leon Romanovsky > Fixes: dd74282df573 ("RDMA/hns: Initialize the PCI device for hip08 RoCE") > Signed-off-by: YueHaibing > --- > v2: select HNS3 to fix this > --- > drivers/infiniband/hw/hns/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/hns/Kconfig b/drivers/infiniband/hw/hns/Kconfig > index 8bf847b..b9dfac0 100644 > --- a/drivers/infiniband/hw/hns/Kconfig > +++ b/drivers/infiniband/hw/hns/Kconfig > @@ -22,7 +22,8 @@ config INFINIBAND_HNS_HIP06 > > config INFINIBAND_HNS_HIP08 > bool "Hisilicon Hip08 Family RoCE support" > - depends on INFINIBAND_HNS && PCI && HNS3 > + depends on INFINIBAND_HNS && PCI > + select HNS3 > ---help--- > RoCE driver support for Hisilicon RoCE engine in Hisilicon Hip08 SoC. > The RoCE engine is a PCI device. >