From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F7FDC43603 for ; Wed, 27 Jan 2021 00:20:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69A6E206A3 for ; Wed, 27 Jan 2021 00:20:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404088AbhA0ASM (ORCPT ); Tue, 26 Jan 2021 19:18:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728600AbhAZRIE (ORCPT ); Tue, 26 Jan 2021 12:08:04 -0500 Received: from bedivere.hansenpartnership.com (bedivere.hansenpartnership.com [IPv6:2607:fcd0:100:8a00::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 041F5C061A2B; Tue, 26 Jan 2021 08:46:52 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id 60BB6128025E; Tue, 26 Jan 2021 08:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1611679609; bh=YYXnRPkivoOQxj54PhIN26oV5DaWUkpUQrmfHkVSlNU=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=ppIoAxCFDVqtgUWlciU6HC4WacNGp4rGFFc9rJ3UYff+qWhXsPAw/7CxEwo8D9t9r VKEMzkyoULgQhSLHDJwwr45B4xgnnkkPSi4hT88o41fDDQA6YIDr9x4b3QJasMGjhq TWViLYPh6j/ibqwTHyBotM/JJqFZQjzabutH3ZjI= Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gPbahwszsqyx; Tue, 26 Jan 2021 08:46:49 -0800 (PST) Received: from jarvis.int.hansenpartnership.com (unknown [IPv6:2601:600:8280:66d1::c447]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id B80391280232; Tue, 26 Jan 2021 08:46:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1611679609; bh=YYXnRPkivoOQxj54PhIN26oV5DaWUkpUQrmfHkVSlNU=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=ppIoAxCFDVqtgUWlciU6HC4WacNGp4rGFFc9rJ3UYff+qWhXsPAw/7CxEwo8D9t9r VKEMzkyoULgQhSLHDJwwr45B4xgnnkkPSi4hT88o41fDDQA6YIDr9x4b3QJasMGjhq TWViLYPh6j/ibqwTHyBotM/JJqFZQjzabutH3ZjI= Message-ID: Subject: Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls From: James Bottomley To: =?UTF-8?Q?=C5=81ukasz?= Majczak , Guenter Roeck , "Tj (Elloe Linux)" , Dirk Gouders Cc: Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Radoslaw Biernacki , Marcin Wojtas , Alex Levin Date: Tue, 26 Jan 2021 08:46:48 -0800 In-Reply-To: References: <20210123014247.989368-1-lma@semihalf.com> <20210125171846.GA31929@roeck-us.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2021-01-26 at 16:46 +0100, Łukasz Majczak wrote: > Hi Jarkko, Guenter > > Yes, here are the logs when failure occurs - > https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9 > Look for a phrase "TPM returned invalid status" We've had other reports of this: https://lore.kernel.org/linux-integrity/ghsgagsnag.fsf@gouders.net/ https://lore.kernel.org/linux-integrity/374e918c-f167-9308-2bea-ae6bc6a3d2e3@elloe.vision/ The problem is some TIS TPMs don't begin in the correct locality so we have to set it. When I proposed the check, I also proposed a fix for this problem: https://lore.kernel.org/linux-integrity/20201001180925.13808-5-James.Bottomley@HansenPartnership.com/ But it's part of a series that never went upstream. Part of the reason was Jarkko proposed the get/put patch to fix this instead, but that never went upstream either. We need to decide an approach and apply one or other fixes. James