From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752538AbdF2MFM (ORCPT ); Thu, 29 Jun 2017 08:05:12 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:63457 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752682AbdF2MEz (ORCPT ); Thu, 29 Jun 2017 08:04:55 -0400 X-AuditID: cbfec7f4-f79806d000001279-f1-5954ecda9831 Subject: Re: [PATCH v3 6/8] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format To: Thierry Escande , Jacek Anaszewski , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org From: Andrzej Pietrasiewicz Message-id: Date: Thu, 29 Jun 2017 14:04:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-version: 1.0 In-reply-to: <1498579734-1594-7-git-send-email-thierry.escande@collabora.com> Content-type: text/plain; charset=utf-8; format=flowed Content-language: en-US Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLKsWRmVeSWpSXmKPExsWy7djPc7q334REGizcxWxxe+sGFovLu+aw WfRs2MpqsWzTHyaL/quX2BxYPXbcXcLosXPWXXaPTas62Tw+b5ILYInisklJzcksSy3St0vg ynj1+jJ7wSreij+rl7E1MN7l6mLk5JAQMJGYdOQbO4QtJnHh3nq2LkYuDiGBpYwS3TdPMUM4 nxklbn6YyQzTseLMaSaIxDJGiX1X70K1vGCU+Pb4LRNIlbBAmMSaVZvZQRIiAhMYJQ5s2wm2 hFnAVqLjUCcLiM0mYCyx92AHI4jNK2AncWPeK1YQm0VAVeJCQxNYjahAhMSiSRPZIWoEJX5M vgcW5xTwldh2bwkzxEwriWf/WlkhbHGJ5tabLBC2vMTmNW/BfpAQWMQuMWHFAaBlHECOrMSm A1DvuEj83naMBcIWlnh1fAs0MGQkOjsOMkH0TmaU2HDzAwuEs51RYu2xE6wQVdYSh49fhNrM JzFp23RmiAW8Eh1tQhAlHhKTrl6GWuYocXDmA2jYPWaUOL/sGPMERoVZSJ6bheShWUgemoXk oQWMLKsYRVJLi3PTU4tN9IoTc4tL89L1kvNzNzECE83pf8e/7GBcfMzqEKMAB6MSD++KVcGR QqyJZcWVuYcYJTiYlUR4mV+ERArxpiRWVqUW5ccXleakFh9ilOZgURLn5Tp1LUJIID2xJDU7 NbUgtQgmy8TBKdXAyLzFNvNA28bVm0wePdNUVePvP9o/cYvlaS3XeebTLA/fsE549DCD7Zp+ KNcrtS3i2u9uOy6oL1vy09vYVnreF8EmHnf3PQkqT1VCFsUsPpcptUWg4Pldx0ezhAU+cDve cyrRElwjwta7VlDe0CdS7Frqrv+a6fuvaN66drFj8bvfBe9Da4/+U2Ipzkg01GIuKk4EADW6 ZMgwAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsVy+t/xK7q33oREGizcLG9xe+sGFovLu+aw WfRs2MpqsWzTHyaL/quX2BxYPXbcXcLosXPWXXaPTas62Tw+b5ILYIlys8lITUxJLVJIzUvO T8nMS7dVCg1x07VQUshLzE21VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2CW8ar15fZC1bx VvxZvYytgfEuVxcjJ4eEgInEijOnmSBsMYkL99azdTFycQgJLGGUeD1lGTOE84JRou3MctYu Rg4OYYEwiY87uUHiIgKTGCVWbv0L1s0sYCvRcaiTBaLhMaPE/DXPWEESbALGEnsPdjCC2LwC dhI35r0Ci7MIqEpcaGhiAbFFBSIkdl0/wApRIyjxY/I9sDingK/EtntLmCEWmEl8eXmYFcIW l2huvckCYctLbF7zlnkCo+AsJO2zkLTMQtIyC0nLAkaWVYwiqaXFuem5xYZ6xYm5xaV56XrJ +bmbGIERt+3Yz807GC9tDD7EKMDBqMTDu2JVcKQQa2JZcWXuIUYJDmYlEV7mFyGRQrwpiZVV qUX58UWlOanFhxhNgZ6byCwlmpwPTAZ5JfGGJobmloZGxhYW5kZGSuK8JR+uhAsJpCeWpGan phakFsH0MXFwSjUwCm35HH7I6LnFrg88bFONalcvm/BhcTxv1e5jStNrNQ8UFGb+S328dGVK dAVbwA81q4n+0qU3Zkerd8v+/3Pl26Q28akS4atSjuwo3nc6NWrXlmjNrcqm07sba6blCAbP eOBk/eUn46oZ64Td5ITfxkzOVRS6HLtofyLn/fi/cb9jOA6eu7XwrRJLcUaioRZzUXEiAMKq jdXOAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170629120442eucas1p13ab4c46045952b5acb11da8af3c4ebdf X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBQaWV0cmFzaWV3aWN6G1NSUE9MLUtlcm5lbCAo?= =?UTF-8?B?VFApG+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBUb21hc3ogUGlldHJhc2lld2ljehtTUlBPTC1L?= =?UTF-8?B?ZXJuZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2Fy?= =?UTF-8?B?ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170627161047epcas2p439c3d90e17402cd06d3c820564cb0e17 X-RootMTR: 20170627161047epcas2p439c3d90e17402cd06d3c820564cb0e17 References: <1498579734-1594-1-git-send-email-thierry.escande@collabora.com> <1498579734-1594-7-git-send-email-thierry.escande@collabora.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org W dniu 27.06.2017 o 18:08, Thierry Escande pisze: > From: Tony K Nadackal > > This patch adds support for decoding 4:1:1 chroma subsampling in the > jpeg header parsing function. > > Signed-off-by: Tony K Nadackal > Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz > --- > drivers/media/platform/s5p-jpeg/jpeg-core.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c > index 0783809..cca0fb8 100644 > --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c > +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c > @@ -1099,6 +1099,8 @@ static void skip(struct s5p_jpeg_buffer *buf, long len) > static bool s5p_jpeg_subsampling_decode(struct s5p_jpeg_ctx *ctx, > unsigned int subsampling) > { > + unsigned int version; > + > switch (subsampling) { > case 0x11: > ctx->subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_444; > @@ -1112,6 +1114,19 @@ static bool s5p_jpeg_subsampling_decode(struct s5p_jpeg_ctx *ctx, > case 0x33: > ctx->subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_GRAY; > break; > + case 0x41: > + /* > + * 4:1:1 subsampling only supported by 3250, 5420, and 5433 > + * variants > + */ > + version = ctx->jpeg->variant->version; > + if (version != SJPEG_EXYNOS3250 && > + version != SJPEG_EXYNOS5420 && > + version != SJPEG_EXYNOS5433) > + return false; > + > + ctx->subsampling = V4L2_JPEG_CHROMA_SUBSAMPLING_411; > + break; > default: > return false; > } >