From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 069C7C433EF for ; Thu, 9 Sep 2021 06:08:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E159B61158 for ; Thu, 9 Sep 2021 06:08:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351549AbhIIGJL (ORCPT ); Thu, 9 Sep 2021 02:09:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231438AbhIIGJJ (ORCPT ); Thu, 9 Sep 2021 02:09:09 -0400 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E55BC061575 for ; Wed, 8 Sep 2021 23:08:00 -0700 (PDT) Received: by mail-ot1-x336.google.com with SMTP id i3-20020a056830210300b0051af5666070so1147829otc.4 for ; Wed, 08 Sep 2021 23:08:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5IZhKmYjWyUNxqS/JWropfkc5GoYoPNRqG2FrnyCWSw=; b=Uby1UFSqv+tObg8zy1Qt9JfEE0z4OOZS1mZrQSbWDi0jjncQe48BLUiEkCBnIT0OEH XZEM6zsVARUlXeVJksyht7d1Gib8J5mY4X0cwD8cLeV3nlJJKTPKqo6WI+mrt82lFgq8 FApkveOpRQYKUP/1FEkXoO8h21Ow3ja9KPCw6IFjzKNNfU+7+afhnR/akfRpZdNGlp0T lcEBTEqvbbJdbdGUGw6Y+vIhtwvqzpYx3iPXFHBJw7axVEtjK/5LyF7fYiUNP8a9DCEk Bj0kX4U3FzIu5lmRVwoJ1aWhneyWpViN7s5hOqA/z7SRBwEVs51RxSVvIohhBbGaAJHq 5h9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5IZhKmYjWyUNxqS/JWropfkc5GoYoPNRqG2FrnyCWSw=; b=YW0AN3kGtC9W58qCp5FIyk3jOinEcbdQXYrwZU20itV2HUnVKbKNV2Kv3S7UiwFgPO xTAQAbOIvypxd5bN2FweXHjSEyb+cu6Lfx4xekHALQb+WqwJ8KtxNYC8A9JfUDjwyQSz /yJFw/tutyBg3Ld/m8njtZuabtA/UNhGjInPk/MxUH6xJdJ+mR11s3+q2OmLR3DwnZHw 3QMoIrr5UfjIXNHOyEBjWriEXG3sdhMV0b8CEvuTrT1b4PS2C68ITVMkTxe98ghckK3m KyU0lovhL9IgWgYruRAMdEQzFX14Q7oBaT+cGcLqO2USvaTDgCddT30W61lQ/ksmVNV6 Co1Q== X-Gm-Message-State: AOAM5334oHOItgT5GZ1Kh9Uw+DKVBPz2TFEV8O8ZUzudLZgayOatTAh4 aMZNFczC5oXrp9amrUw8bCQ= X-Google-Smtp-Source: ABdhPJz2e0pQIKzbERrP4yOrC1kq1zJGwp23agv3qtyCHWfk+VzWPFR9D44RgTj57Sc8MlD8s8FyJg== X-Received: by 2002:a05:6830:4084:: with SMTP id x4mr1039349ott.280.1631167679964; Wed, 08 Sep 2021 23:07:59 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id y7sm180455oov.36.2021.09.08.23.07.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 23:07:59 -0700 (PDT) Sender: Guenter Roeck Subject: Re: [PATCH] Enable '-Werror' by default for all kernel builds To: Christoph Hellwig , Marco Elver Cc: Nathan Chancellor , Arnd Bergmann , Linus Torvalds , Linux Kernel Mailing List , llvm@lists.linux.dev, Nick Desaulniers , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org, Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Andrey Konovalov , kasan-dev@googlegroups.com, Christian =?unknown-8bit?B?S8O2bmln?= , "Pan, Xinhui" , amd-gfx@lists.freedesktop.org References: <20210906142615.GA1917503@roeck-us.net> <75a10e8b-9f11-64c4-460b-9f3ac09965e2@roeck-us.net> From: Guenter Roeck Message-ID: Date: Wed, 8 Sep 2021 23:07:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/8/21 10:58 PM, Christoph Hellwig wrote: > On Wed, Sep 08, 2021 at 11:58:56PM +0200, Marco Elver wrote: >> It'd be good to avoid. It has helped uncover build issues with KASAN in >> the past. Or at least make it dependent on the problematic architecture. >> For example if arm is a problem, something like this: > > I'm also seeing quite a few stack size warnings with KASAN on x86_64 > without COMPILT_TEST using gcc 10.2.1 from Debian. In fact there are a > few warnings without KASAN, but with KASAN there are a lot more. > I'll try to find some time to dig into them. > > While we're at it, with -Werror something like this is really futile: > > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c: In function ‘amdgpu_bo_support_uswc’: > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:493:2: warning: #warning > Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance thanks to write-combining [-Wcpp > 493 | #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance \ > | ^~~~~~~ > I have been wondering if all those #warning "errors" should either be removed or be replaced with "#pragma message". Guenter