From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AD11C43387 for ; Wed, 2 Jan 2019 10:24:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B0E62075B for ; Wed, 2 Jan 2019 10:24:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729329AbfABKYf (ORCPT ); Wed, 2 Jan 2019 05:24:35 -0500 Received: from mx2.suse.de ([195.135.220.15]:51918 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728451AbfABKYf (ORCPT ); Wed, 2 Jan 2019 05:24:35 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 231F9AD02; Wed, 2 Jan 2019 10:24:32 +0000 (UTC) Subject: Re: general protection fault in transparent_hugepage_enabled To: Dmitry Vyukov Cc: syzbot , Andrew Morton , "Aneesh Kumar K.V" , Hugh Dickins , Jerome Glisse , Konstantin Khlebnikov , "Kirill A. Shutemov" , LKML , Linux-MM , Michal Hocko , David Rientjes , Stephen Rothwell , syzkaller-bugs , Matthew Wilcox References: <000000000000ae384d057dc685c1@google.com> <1186a139-3a46-3311-5f72-bef02d403ee1@suse.cz> From: Vlastimil Babka Openpgp: preference=signencrypt Message-ID: Date: Wed, 2 Jan 2019 11:24:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/2/19 11:03 AM, Dmitry Vyukov wrote: > On Wed, Jan 2, 2019 at 10:47 AM Vlastimil Babka wrote: >> >> Actually the fix was folded into the patch that caused the bug, and was >> already sent to and merged by Linus, commit >> 7635d9cbe8327e131a1d3d8517dc186c2796ce2e > > > But the email thread you referenced says that we need: > > @@ -66,6 +66,8 @@ bool transparent_hugepage_enabled(struct vm_area_struct *vma) > { > if (vma_is_anonymous(vma)) > return __transparent_hugepage_enabled(vma); > + if (!vma->vm_file || !vma->vm_file->f_mapping) > + return false; > if (shmem_mapping(vma->vm_file->f_mapping) && shmem_huge_enabled(vma)) > return __transparent_hugepage_enabled(vma); > > and 7635d9cbe8327e131a1d3d8517dc186c2796ce2e contains: > > +bool transparent_hugepage_enabled(struct vm_area_struct *vma) > +{ > + if (vma_is_anonymous(vma)) > + return __transparent_hugepage_enabled(vma); > + if (vma_is_shmem(vma) && shmem_huge_enabled(vma)) > + return __transparent_hugepage_enabled(vma); > + > + return false; > +} > > What am I missing? Ah, the solution with vma_is_shmem() appeared later in the thread: https://marc.info/?l=linux-mm&m=154567747315893&w=2 >>>>> Code: 80 3c 02 00 0f 85 ae 04 00 00 4c 8b a3 a0 00 00 00 48 b8 00 00 00 00 >>>>> 00 fc ff df 49 8d bc 24 b8 01 00 00 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f >>>>> 85 91 04 00 00 49 8b bc 24 b8 01 00 00 e8 2d 70 e6 >>>>> RSP: 0018:ffff8881c2237138 EFLAGS: 00010202 >>>>> RAX: dffffc0000000000 RBX: ffff8881c2bdbc60 RCX: 0000000000000000 >>>>> RDX: 0000000000000037 RSI: ffffffff81c8fa1a RDI: 00000000000001b8 >>>>> RBP: ffff8881c2237160 R08: ffffed10383b25ed R09: ffffed10383b25ec >>>>> R10: ffffed10383b25ec R11: ffff8881c1d92f63 R12: 0000000000000000 >>>>> R13: ffff8881c2bdbd00 R14: dffffc0000000000 R15: 0000000000000f5e >>>>> FS: 0000000001a48880(0000) GS:ffff8881dad00000(0000) knlGS:0000000000000000 >>>>> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>>>> CR2: 0000000020b58000 CR3: 00000001c2210000 CR4: 00000000001406e0 >>>>> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >>>>> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 >>>>> Call Trace: >>>>> show_smap+0x167/0x580 fs/proc/task_mmu.c:805 >>>>> traverse+0x344/0x7b0 fs/seq_file.c:113 >>>>> seq_read+0xc76/0x1150 fs/seq_file.c:188 >>>>> do_loop_readv_writev fs/read_write.c:700 [inline] >>>>> do_iter_read+0x4bc/0x670 fs/read_write.c:924 >>>>> vfs_readv+0x175/0x1c0 fs/read_write.c:986 >>>>> kernel_readv fs/splice.c:362 [inline] >>>>> default_file_splice_read+0x539/0xb20 fs/splice.c:417 >>>>> do_splice_to+0x12e/0x190 fs/splice.c:880 >>>>> splice_direct_to_actor+0x31c/0x9d0 fs/splice.c:957 >>>>> do_splice_direct+0x2d4/0x420 fs/splice.c:1066 >>>>> do_sendfile+0x62a/0xe50 fs/read_write.c:1439 >>>>> __do_sys_sendfile64 fs/read_write.c:1494 [inline] >>>>> __se_sys_sendfile64 fs/read_write.c:1486 [inline] >>>>> __x64_sys_sendfile64+0x15d/0x250 fs/read_write.c:1486 >>>>> do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290 >>>>> entry_SYSCALL_64_after_hwframe+0x49/0xbe >>>>> RIP: 0033:0x440089 >>>>> Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 >>>>> 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff >>>>> ff 0f 83 5b 14 fc ff c3 66 2e 0f 1f 84 00 00 00 00 >>>>> RSP: 002b:00007fff3d710a18 EFLAGS: 00000213 ORIG_RAX: 0000000000000028 >>>>> RAX: ffffffffffffffda RBX: 00007fff3d710a20 RCX: 0000000000440089 >>>>> RDX: 0000000020b58000 RSI: 0000000000000003 RDI: 0000000000000003 >>>>> RBP: 00000000006ca018 R08: 0000000000000010 R09: 65732f636f72702f >>>>> R10: 000000000000ffff R11: 0000000000000213 R12: 0000000000401970 >>>>> R13: 0000000000401a00 R14: 0000000000000000 R15: 0000000000000000 >>>>> Modules linked in: >>>>> ---[ end trace faf026efd8795e93 ]--- >>>>> RIP: 0010:transparent_hugepage_enabled+0x8c/0x5e0 mm/huge_memory.c:69 >>>>> Code: 80 3c 02 00 0f 85 ae 04 00 00 4c 8b a3 a0 00 00 00 48 b8 00 00 00 00 >>>>> 00 fc ff df 49 8d bc 24 b8 01 00 00 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f >>>>> 85 91 04 00 00 49 8b bc 24 b8 01 00 00 e8 2d 70 e6 >>>>> RSP: 0018:ffff8881c2237138 EFLAGS: 00010202 >>>>> RAX: dffffc0000000000 RBX: ffff8881c2bdbc60 RCX: 0000000000000000 >>>>> RDX: 0000000000000037 RSI: ffffffff81c8fa1a RDI: 00000000000001b8 >>>>> RBP: ffff8881c2237160 R08: ffffed10383b25ed R09: ffffed10383b25ec >>>>> R10: ffffed10383b25ec R11: ffff8881c1d92f63 R12: 0000000000000000 >>>>> R13: ffff8881c2bdbd00 R14: dffffc0000000000 R15: 0000000000000f5e >>>>> FS: 0000000001a48880(0000) GS:ffff8881dad00000(0000) knlGS:0000000000000000 >>>>> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>>>> CR2: 0000000020b58000 CR3: 00000001c2210000 CR4: 00000000001406e0 >>>>> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >>>>> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 >>>>> >>>>> >>>>> --- >>>>> This bug is generated by a bot. It may contain errors. >>>>> See https://goo.gl/tpsmEJ for more information about syzbot. >>>>> syzbot engineers can be reached at syzkaller@googlegroups.com. >>>>> >>>>> syzbot will keep track of this bug report. See: >>>>> https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with >>>>> syzbot. >>>>> syzbot can test patches for this bug, for details see: >>>>> https://goo.gl/tpsmEJ#testing-patches >>