From: Arend Van Spriel <aspriel@gmail.com>
To: Li Qiong <liqiong@nfschina.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Kalle Valo <kvalo@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Yu Zhe <yuzhe@nfschina.com>
Subject: Re: [PATCH] wifi: cfg80211: add error code in brcmf_notify_sched_scan_results()
Date: Mon, 29 Aug 2022 10:51:40 +0200 [thread overview]
Message-ID: <a054ffb1-527b-836c-f43e-9f76058cc9ed@gmail.com> (raw)
In-Reply-To: <20220829065831.14023-1-liqiong@nfschina.com>
On 8/29/2022 8:58 AM, Li Qiong wrote:
> The err code is 0 at the first two "out_err" paths, add error code
> '-EINVAL' for these error paths.
There is no added value provided in this change. There is an error
message, but it is otherwise silently ignored as there is no additional
fault handling required.
Regards,
Arend
> Signed-off-by: Li Qiong <liqiong@nfschina.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 ++
> 1 file changed, 2 insertions(+)
next prev parent reply other threads:[~2022-08-29 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 6:58 [PATCH] wifi: cfg80211: add error code in brcmf_notify_sched_scan_results() Li Qiong
2022-08-29 7:59 ` Kalle Valo
2022-08-29 8:51 ` Arend Van Spriel [this message]
2022-08-29 11:31 ` liqiong
2022-08-29 11:12 ` [PATCH v2] wifi: brcmfmac: " Li Qiong
2022-09-07 7:29 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a054ffb1-527b-836c-f43e-9f76058cc9ed@gmail.com \
--to=aspriel@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=netdev@vger.kernel.org \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).