From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23208C4338F for ; Fri, 30 Jul 2021 11:37:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00ACE61050 for ; Fri, 30 Jul 2021 11:37:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238631AbhG3Lh2 (ORCPT ); Fri, 30 Jul 2021 07:37:28 -0400 Received: from foss.arm.com ([217.140.110.172]:40856 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230157AbhG3Lh0 (ORCPT ); Fri, 30 Jul 2021 07:37:26 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CA045D6E; Fri, 30 Jul 2021 04:37:21 -0700 (PDT) Received: from [10.57.86.111] (unknown [10.57.86.111]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3B6173F73D; Fri, 30 Jul 2021 04:37:20 -0700 (PDT) Subject: Re: [PATCH v2 04/10] coresight: trbe: Ensure the format flag is set on truncation To: Anshuman Khandual , coresight@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, tamas.zsoldos@arm.com, al.grant@arm.com, leo.yan@linaro.org, mike.leach@linaro.org, mathieu.poirier@linaro.org, jinlmao@qti.qualcomm.com References: <20210723124611.3828908-1-suzuki.poulose@arm.com> <20210723124611.3828908-5-suzuki.poulose@arm.com> From: Suzuki K Poulose Message-ID: Date: Fri, 30 Jul 2021 12:37:18 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/07/2021 05:26, Anshuman Khandual wrote: > > > On 7/23/21 6:16 PM, Suzuki K Poulose wrote: >> When the TRBE is stopped on truncating an event, we may not >> set the FORMAT flag, even though the size of the record is 0. >> Let us be consistent and not confuse the user. Always set the >> format flag for TRBE generated records. >> >> Cc: Anshuman Khandual >> Cc: Leo Yan >> Cc: Mike Leach >> Cc: Mathieu Poirier >> Signed-off-by: Suzuki K Poulose >> --- >> drivers/hwtracing/coresight/coresight-trbe.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c >> index 176868496879..446f080f8320 100644 >> --- a/drivers/hwtracing/coresight/coresight-trbe.c >> +++ b/drivers/hwtracing/coresight/coresight-trbe.c >> @@ -132,7 +132,8 @@ static void trbe_stop_and_truncate_event(struct perf_output_handle *handle) >> * the update_buffer() to return a 0 size. >> */ >> trbe_drain_and_disable_local(); >> - perf_aux_output_flag(handle, PERF_AUX_FLAG_TRUNCATED); >> + perf_aux_output_flag(handle, PERF_AUX_FLAG_TRUNCATED | >> + PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW); >> *this_cpu_ptr(buf->cpudata->drvdata->handle) = NULL; >> } > > But why should not PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW also be set on > zero sized records as well ? Otherwise there are two instances during > TRBE buffer management, where PERF_AUX_FLAG_TRUNCATED is marked alone > without PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW. Those could be changed as > well. All records (irrespective of the size) generated by the TRBE must contain the "RAW" flag. Did I miss another instance where we don't do this ? Suzuki >