From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752336AbdLCN2V (ORCPT ); Sun, 3 Dec 2017 08:28:21 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:44777 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752031AbdLCN2S (ORCPT ); Sun, 3 Dec 2017 08:28:18 -0500 X-Google-Smtp-Source: AGs4zMZdbQIcQiOYCaJ2kEYmLC0Cok3Snr2Jz0l3pTvgljfdHFIeHWofAAukZYBFPEr1Fx2j9tFrUg== Subject: Re: [PATCH v6 4/6] dt: bindings: lp8860: Update the bindings to the standard To: Dan Murphy , rpurdie@rpsys.net, pavel@ucw.cz References: <20171201165613.10358-1-dmurphy@ti.com> <20171201165613.10358-4-dmurphy@ti.com> Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , "devicetree@vger.kernel.org" From: Jacek Anaszewski X-Enigmail-Draft-Status: N1110 Message-ID: Date: Sun, 3 Dec 2017 14:27:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20171201165613.10358-4-dmurphy@ti.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dan, On 12/01/2017 05:56 PM, Dan Murphy wrote: > Update the lp8860 dt binding to the LED standard where > the LED should have a child node and also adding a > LED trigger entry. > > Signed-off-by: Dan Murphy > --- > > v6 - New patch to fix binding documentation > > Documentation/devicetree/bindings/leds/leds-lp8860.txt | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt > index aad38dd94d4b..4cf396de6eba 100644 > --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt > +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt > @@ -12,17 +12,24 @@ Required properties: > - label - Used for naming LEDs > > Optional properties: > - - enable-gpio - gpio pin to enable/disable the device. > - - supply - "vled" - LED supply > + - enable-gpios : gpio pin to enable/disable the device. > + - vled-supply : LED supply > + - label : see Documentation/devicetree/bindings/leds/common.txt > + - linux,default-trigger : (optional) > + see Documentation/devicetree/bindings/leds/common.txt > > Example: > > -leds: leds@6 { > +lp8860@2d { > compatible = "ti,lp8860"; > reg = <0x2d>; > - label = "display_cluster"; > enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>; > vled-supply = <&vbatt>; > + > + backlight: backlight@0 { > + label = "backlight_cluster"; You'll need to change this to: label = "white:backlight_cluster" Please always cc your patches with DT bindings to devicetree@vger.kernel.org and related maintainers. > + linux,default-trigger = "backlight"; > + }; > } > > For more product information please see the link below: > -- Best regards, Jacek Anaszewski