From: Vlastimil Babka <vbabka@suse.cz>
To: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
Cc: Faiyaz Mohammed <faiyazm@codeaurora.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH 1/1] mm/slub: fix endless "No data" printing for alloc/free_traces attribute
Date: Tue, 23 Nov 2021 15:19:49 +0100 [thread overview]
Message-ID: <a081d544-41f0-29ab-6d46-1afa382af8be@suse.cz> (raw)
In-Reply-To: <20211122213330.66b7893e@thinkpad>
On 11/22/21 21:33, Gerald Schaefer wrote:
> On Mon, 22 Nov 2021 21:14:00 +0100
> Gerald Schaefer <gerald.schaefer@linux.ibm.com> wrote:
>
> [...]
>>
>> Thanks. While testing this properly, yet another bug showed up. The idx
>> in op->show remains 0 in all iterations, so I always see the same line
>> printed t->count times (or infinitely, ATM). Not sure if this only shows
>> on s390 due to endianness, but the reason is this:
>>
>> unsigned int idx = *(unsigned int *)v;
Uh, good catch. I was actually looking suspiciously at how we cast signed to
unsigned, but didn't occur to me that shortening together with endiannes is
the problem.
>>
>> IIUC, void *v is always the same as loff_t *ppos, and therefore idx also
>> should be *ppos. De-referencing the loff_t * with an unsigned int * only
>> gives the upper 32 bit half of the 64 bit value, which remains 0.
>>
>> This would be fixed e.g. with
>>
>> unsigned int idx = (unsigned int) *(loff_t *) v;
With all this experience I'm now inclined to rather follow more the example
in Documentation/filesystems/seq_file.rst and don't pass around the pointer
that we got as ppos in slab_debugfs_start(), and that seq_file.c points to
m->index.
In that example an own value is kmalloced:
loff_t *spos = kmalloc(sizeof(loff_t), GFP_KERNEL);
while we could just make this a field of loc_track?
>> With this fixed, my original patch actually also works for t->count > 0,
>> because then op->show would return w/o printing anything when idx reaches
>> t->count. For t->count > 0, it would even work w/o any extra checks in
>> op->start because of that, only "No data" would be printed infinitely.
>
> Oh, no, that would actually also fix the "No data" part, as op->show
> will then also return w/o printing in the next iteration, so that op->next
> would correctly end it all.
>
> This could also explain why it might all have worked fine on x86 (haven't
> verified), and really only showed on big-endian s390.
>
> Hmm, now I'm not so sure anymore if we really want the additional
> checks and return NULL in op->start, just to make it "double safe".
I guess we don't.
>>
>> It probably still makes sense to make this explicit in op->start, by
>> checking separately for !*ppos && !t->count, and returning NULL for
>> *ppos >= t->count, as you suggested.
>>
>> I think I will also make idx an unsigned long again, like it was before
>> commit 64dd68497be7, and similar to t->count. Not sure if it needs to
>> be, and with proper casting unsigned int is also possible, but why
>> change it?
>
next prev parent reply other threads:[~2021-11-23 14:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 19:39 [RFC PATCH 0/1] mm/slub: endless "No data" printing for alloc/free_traces attribute Gerald Schaefer
2021-11-17 19:39 ` [RFC PATCH 1/1] mm/slub: fix " Gerald Schaefer
2021-11-19 10:41 ` Vlastimil Babka
2021-11-19 19:59 ` Gerald Schaefer
2021-11-22 15:02 ` Vlastimil Babka
2021-11-22 20:14 ` Gerald Schaefer
2021-11-22 20:33 ` Gerald Schaefer
2021-11-23 14:19 ` Vlastimil Babka [this message]
2021-11-25 16:13 ` Gerald Schaefer
2021-11-25 20:12 ` Gerald Schaefer
2021-11-25 22:00 ` Vlastimil Babka
2021-11-26 17:11 ` Gerald Schaefer
2021-11-26 17:18 ` [PATCH] mm/slub: fix endianness bug for alloc/free_traces attributes Gerald Schaefer
2021-11-29 14:26 ` Vlastimil Babka
2021-11-19 9:43 ` [RFC PATCH 0/1] mm/slub: endless "No data" printing for alloc/free_traces attribute Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a081d544-41f0-29ab-6d46-1afa382af8be@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=faiyazm@codeaurora.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).