Re: [PATCH v20 2/8] soc: mediatek: add mtk-mutex support for mt8195 vdosys0 - Jason-JH Lin

From: Jason-JH Lin <jason-jh.lin@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
	CK Hu <ck.hu@mediatek.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>
Cc: Nancy Lin <nancy.lin@mediatek.com>,
	Singo Chang <singo.chang@mediatek.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v20 2/8] soc: mediatek: add mtk-mutex support for mt8195 vdosys0
Date: Sun, 24 Apr 2022 16:48:54 +0800	[thread overview]
Message-ID: <a0b90deb9d30fe331493f5fbe8e67a97b698fe49.camel@mediatek.com> (raw)
In-Reply-To: <074d8c26-3fb7-bee1-d559-7ce96f583fee@gmail.com>

Hi Matthias,

Thanks for the reviews.

On Fri, 2022-04-22 at 14:31 +0200, Matthias Brugger wrote:
> 
> On 22/04/2022 04:32, Jason-JH Lin wrote:
> > Hi CK,
> > 
> > Thanks for the reviews.
> > 
> > On Thu, 2022-04-21 at 14:50 +0800, CK Hu wrote:
> > > Hi, Jason:
> > > 
> > > On Tue, 2022-04-19 at 17:41 +0800, jason-jh.lin wrote:
> > > > Add mtk-mutex support for mt8195 vdosys0.
> > > > 
> > > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
> > > > Acked-by: AngeloGioacchino Del Regno <
> > > > angelogioacchino.delregno@collabora.com>
> > > > Tested-by: Fei Shao <fshao@chromium.org>
> > > > ---
> > > >   drivers/soc/mediatek/mtk-mutex.c | 87
> > > > ++++++++++++++++++++++++++++++--
> > > >   1 file changed, 84 insertions(+), 3 deletions(-)
> > > > 
> > > > diff --git a/drivers/soc/mediatek/mtk-mutex.c
> > > > b/drivers/soc/mediatek/mtk-mutex.c
> > > > index aaf8fc1abb43..729ee88035ed 100644
> > > > --- a/drivers/soc/mediatek/mtk-mutex.c
> > > > +++ b/drivers/soc/mediatek/mtk-mutex.c
> > > > @@ -17,6 +17,9 @@
> > > >   #define MT8183_MUTEX0_MOD0			0x30
> > > >   #define MT8183_MUTEX0_SOF0			0x2c
> > > >   
> > > > +#define MT8195_DISP_MUTEX0_MOD0			0x30
> > > > +#define MT8195_DISP_MUTEX0_SOF			0x2c
> > > 
> > > This is identical to mt8183, so use mt8183 one instead of
> > > creating
> > > new
> > > one.
> > > 
> > > Regards,
> > > CK
> > > 
> > 
> > I'll fix this in the next version.
> 
> Please send this as a follow-up fix on top of:
> 
https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/log/?h=v5.18-next*soc__;Lw!!CTRNKA9wMg0ARbw!0QzNDaejnt54R86SL628fJ9p2BKTOmYBnoz6uPz9X8WsHXeQi3rqPAXmPFRBcw1vEtUu$
>  
> 
> Regards,
> Matthias
> 
OK, I'll send the fix-up patch soon.

Regards,
Jason-JH.Lin

> > 
> > Regards,
> > Jason-JH.Lin.
> > > > 
> > > >   
> > > > +static const struct mtk_mutex_data mt8195_mutex_driver_data =
> > > > {
> > > > +	.mutex_mod = mt8195_mutex_mod,
> > > > +	.mutex_sof = mt8195_mutex_sof,
> > > > +	.mutex_mod_reg = MT8195_DISP_MUTEX0_MOD0,
> > > > +	.mutex_sof_reg = MT8195_DISP_MUTEX0_SOF,
> > > > +};
> > > > +
> > > >   
> > > 
> > > 
-- 
Jason-JH Lin <jason-jh.lin@mediatek.com>