From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16D80C433EF for ; Wed, 30 Mar 2022 17:25:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349272AbiC3R1j (ORCPT ); Wed, 30 Mar 2022 13:27:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245162AbiC3R1e (ORCPT ); Wed, 30 Mar 2022 13:27:34 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E2706144 for ; Wed, 30 Mar 2022 10:25:48 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id qa43so42893027ejc.12 for ; Wed, 30 Mar 2022 10:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ywoW9d6iS1v9MqKMZLThlxZsRS/iSgOcBYL7HQFMb8w=; b=jXk62kaOb+JZKYyIu6K42PmmJIIdGtCx+R5cntWsvzNPATuN2iTuNHYp+Xv7eu8rNX zBBxcwEHW0KJvJ7FAmBCuXDPXBqUjHOU3EmkZnB28JQeKhKvKCNOH7AUFonVtWgn/lFm fRxBZMOPOE6IZsyQUWIz4nbh009mA9u6qOr2tmDHTx0txHOrL6wSdUtWD3J+R3sxt8mG fz1ht2TrYkbcCEsipaWGd3Wq05pEU1oyYUXJY88dSOGG7m7PZtT8nR8L2ytl0TxFGgbu qV0D5kIFVBokjp1U0w9N9N5gl1MdXm56QVlcjOhihrbLa/12jg0up/Ck+XN/5CN5uP1n Qh2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ywoW9d6iS1v9MqKMZLThlxZsRS/iSgOcBYL7HQFMb8w=; b=t3DE8bVg084uhrqcgXimUVh6eLGoUt/Z1aGyZdF7jzT9jAWQSj6PFRaxcumjEwopJf hGwazR+n8xmsC5N+DiWzXYLqwr/sFZii83L8fce/+0KrBRp3RXUCbIpcNm0NULtPn71h dhB+FVr2UY42w/aUsJXWTd8C+FBSKrPpWWxlN2YyQbnEMWfIEXO2qJ1WujO7IBUKkYXN rRWCbft3Wpze3wdc2Outd59FGVRl8njKTDmyvWK3qlVBPuTKC3mwU7E8tNWqKsCfQwcm P916QBjsAX0wEf9sKUuhP6QpVERuC3CY6qx3mtYcA16PrEQs/W/QPd5fSWDV5bG+TO8q 95zQ== X-Gm-Message-State: AOAM53248bjqoPHGsAK1pLulzThwTdmt1Lj+nYqleciEYmnT3rMl0yxE 8y8s8QfYUAImlUvFXpC0bSZKoaH9Qt4Sxose X-Google-Smtp-Source: ABdhPJxxOU49iYcKjfDnjlgu3KVv7WLRtGVL9RCQkhzwLgkyAXnZHHhNugRy23T450DuqxkqRAXkmw== X-Received: by 2002:a17:907:1ca3:b0:6e0:5a9:37a1 with SMTP id nb35-20020a1709071ca300b006e005a937a1mr598108ejc.651.1648661146942; Wed, 30 Mar 2022 10:25:46 -0700 (PDT) Received: from [192.168.0.164] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id ds5-20020a170907724500b006df8f39dadesm8343734ejc.218.2022.03.30.10.25.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Mar 2022 10:25:46 -0700 (PDT) Message-ID: Date: Wed, 30 Mar 2022 19:25:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] CHROMIUM: arm64: dts: qcom: Add sc7180-gelarshie Content-Language: en-US To: Mars Chen , agross@kernel.org Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220330090947.9100-1-chenxiangrui@huaqin.corp-partner.google.com> From: Krzysztof Kozlowski In-Reply-To: <20220330090947.9100-1-chenxiangrui@huaqin.corp-partner.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/03/2022 11:09, Mars Chen wrote: > Initial attempt at Gelarshie device tree. > > BUG=b:225756600 > TEST=emerge-strongbad chromeos-kernel-5_4 > > Signed-off-by: Mars Chen > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../dts/qcom/sc7180-trogdor-gelarshie-r0.dts | 15 + > .../dts/qcom/sc7180-trogdor-gelarshie.dtsi | 304 ++++++++++++++++++ > 3 files changed, 320 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index f9e6343acd03..cf8f88b065c3 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -57,6 +57,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1-lte.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r3-lte.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-gelarshie-r0.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r2.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r4.dtb > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts > new file mode 100644 > index 000000000000..027d6d563a5f > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts > @@ -0,0 +1,15 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Google Gelarshie board device tree source > + * > + * Copyright 2022 Google LLC. > + */ > + > +/dts-v1/; > + > +#include "sc7180-trogdor-gelarshie.dtsi" > + > +/ { > + model = "Google Gelarshie (rev0+)"; > + compatible = "google,gelarshie", "qcom,sc7180"; Missing bindings. Please document the compatible. Best regards, Krzysztof