From: John Garry <john.garry@huawei.com>
To: Shunsuke Nakamura <nakamura.shun@jp.fujitsu.com>
Cc: <will@kernel.org>, <mathieu.poirier@linaro.org>,
<leo.yan@linaro.org>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] perf vendor events: Add Fujitsu A64FX V1.2 pmu event
Date: Thu, 21 Jan 2021 17:41:26 +0000 [thread overview]
Message-ID: <a0f7c814-5c56-4e17-1198-a611d19f57d5@huawei.com> (raw)
In-Reply-To: <20210121105425.2695843-4-nakamura.shun@jp.fujitsu.com>
On 21/01/2021 10:54, Shunsuke Nakamura wrote:
> + {
> + "PublicDescription": "This event counts each correction to the predicted program flow that occurs because of a misprediction from, or no prediction from, the branch prediction resources and that relates to instructions that the branch prediction resources are capable of predicting.",
> + "EventCode": "0x10",
> + "EventName": "BR_MIS_PRED",
I think that we need to the same here as the IMPDEF recommended events -
add a common JSON to reduce the duplication.
I had done work on this for current CPUs, but never got it finished. Let
me check the status.
Cheers,
John
Ps, arm have put JSONs here for their cores:
https://github.com/ARM-software/data/tree/master/pmu
But unfortunately the schema does not suit perf.
I raised an issue, but no response.
I'm just wondering if you hand copied the JSON data.
> + "BriefDescription": "This event counts each correction to the predicted program flow that occurs because of a misprediction from, or no prediction from, the branch prediction resources and that relates to instructions that the branch prediction resources are capable of predicting."
> + },
next prev parent reply other threads:[~2021-01-21 17:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 10:54 [PATCH v2 0/3] perf vendor events: Support PMU events for A64FX Shunsuke Nakamura
2021-01-21 10:54 ` [PATCH v2 1/3] perf vendor events: Add cache refill and DCZVA events Shunsuke Nakamura
2021-01-21 11:39 ` Shaokun Zhang
2021-01-21 17:43 ` John Garry
2021-01-22 8:35 ` nakamura.shun
2021-01-21 10:54 ` [PATCH v2 2/3] perf tools: Fix lexical definition of event name Shunsuke Nakamura
2021-01-21 10:54 ` [PATCH v2 3/3] perf vendor events: Add Fujitsu A64FX V1.2 pmu event Shunsuke Nakamura
2021-01-21 17:41 ` John Garry [this message]
2021-01-22 8:37 ` nakamura.shun
2021-01-25 12:46 ` John Garry
2021-01-26 8:03 ` nakamura.shun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0f7c814-5c56-4e17-1198-a611d19f57d5@huawei.com \
--to=john.garry@huawei.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nakamura.shun@jp.fujitsu.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).