linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Suchanek <msuchanek@suse.de>
To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Javier Martinez Canillas <javierm@redhat.com>
Cc: Michal Suchanek <msuchanek@suse.de>,
	Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Martin Mares <mj@ucw.cz>, Helge Deller <deller@gmx.de>,
	Ard Biesheuvel <ardb@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Cristian Marussi <cristian.marussi@arm.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	David Herrmann <dh.herrmann@gmail.com>,
	linux-kernel@vger.kernel.org,
	linux-video@atrey.karlin.mff.cuni.cz, linux-efi@vger.kernel.org
Subject: [PATCH v4 1/3] sysfb: Make config option dependencies explicit
Date: Fri, 25 Feb 2022 21:51:33 +0100	[thread overview]
Message-ID: <a0fa41e9186653e4c41ad0a28259e5cdc71b1f66.1645822213.git.msuchanek@suse.de> (raw)
In-Reply-To: <1f13e6f2-a87c-83ac-7119-8632c8c8ac8e@redhat.com>

efifb and vesafb requires sysfb implicitly but this is not stated in
Kconfig. Add the dependency.

With that all drivers that require sysfb depend on it so it can default
to disabled.

Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
v4: new patch
---
 drivers/firmware/Kconfig    | 5 ++---
 drivers/video/fbdev/Kconfig | 2 ++
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index 75cb91055c17..5265eca74ba1 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -218,12 +218,11 @@ config QCOM_SCM_DOWNLOAD_MODE_DEFAULT
 
 config SYSFB
 	bool
-	default y
-	depends on X86 || EFI
 
 config SYSFB_SIMPLEFB
 	bool "Mark VGA/VBE/EFI FB as generic system framebuffer"
-	depends on SYSFB
+	depends on X86 || EFI
+	select SYSFB
 	help
 	  Firmwares often provide initial graphics framebuffers so the BIOS,
 	  bootloader or kernel can show basic video-output during boot for
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 3cfce8dce8d9..907c305caf27 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -628,6 +628,7 @@ config FB_VESA
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
 	select FB_BOOT_VESA_SUPPORT
+	select SYSFB
 	help
 	  This is the frame buffer device driver for generic VESA 2.0
 	  compliant graphic cards. The older VESA 1.2 cards are not supported.
@@ -641,6 +642,7 @@ config FB_EFI
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
+	select SYSFB
 	help
 	  This is the EFI frame buffer device driver. If the firmware on
 	  your platform is EFI 1.10 or UEFI 2.0, select Y to add support for
-- 
2.34.1


  parent reply	other threads:[~2022-02-25 20:51 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18  9:33 [PATCH] simpldrm: Enable boot time VESA graphic mode selection Michal Suchanek
2022-02-18  9:57 ` Thomas Zimmermann
2022-02-18 10:08   ` Michal Suchánek
2022-02-18 10:24     ` Thomas Zimmermann
2022-02-18 10:51       ` [PATCH v2] simplefb: " Michal Suchanek
2022-02-18 11:36         ` Thomas Zimmermann
2022-02-18 12:05           ` Michal Suchánek
2022-02-18 16:04           ` [PATCH v3] " Michal Suchanek
2022-02-21  9:51             ` Thomas Zimmermann
2022-02-23 18:38               ` Borislav Petkov
2022-02-23 16:34             ` Javier Martinez Canillas
2022-02-23 16:45               ` Michal Suchánek
2022-02-23 16:54                 ` Javier Martinez Canillas
2022-02-23 17:07                   ` Javier Martinez Canillas
2022-02-23 17:12                   ` Michal Suchánek
2022-02-23 18:13                     ` Javier Martinez Canillas
2022-02-23 18:23                       ` Michal Suchánek
2022-02-23 18:34                         ` Javier Martinez Canillas
2022-02-23 19:55                           ` Michal Suchánek
2022-02-25 20:51                           ` Michal Suchanek [this message]
2022-02-25 22:09                             ` [PATCH v4 1/3] sysfb: Make config option dependencies explicit Javier Martinez Canillas
2022-02-25 20:51                           ` [PATCH v4 2/3] sysfb: Enable boot time VESA graphic mode selection Michal Suchanek
2022-02-25 22:10                             ` Javier Martinez Canillas
2022-02-25 20:51                           ` [PATCH v4 3/3] efifb: Remove redundant efifb_setup_from_dmi stub Michal Suchanek
2022-02-25 22:11                             ` Javier Martinez Canillas
2022-03-02 19:31 ` [PATCH] simpldrm: Enable boot time VESA graphic mode selection Thomas Zimmermann
2022-03-02 19:38   ` Michal Suchánek
2022-03-02 19:47     ` Javier Martinez Canillas
2022-03-04 20:00       ` Thomas Zimmermann
2022-03-04 20:47         ` Javier Martinez Canillas
2022-03-07 14:33           ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0fa41e9186653e4c41ad0a28259e5cdc71b1f66.1645822213.git.msuchanek@suse.de \
    --to=msuchanek@suse.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bjorn.andersson@linaro.org \
    --cc=bp@alien8.de \
    --cc=cristian.marussi@arm.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=deller@gmx.de \
    --cc=dh.herrmann@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=javierm@redhat.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-video@atrey.karlin.mff.cuni.cz \
    --cc=mingo@redhat.com \
    --cc=mj@ucw.cz \
    --cc=sudeep.holla@arm.com \
    --cc=tglx@linutronix.de \
    --cc=tzimmermann@suse.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).