Re: [PATCH 1/4] dt-bindings: thermal: k3: Add VTM bindings documentation

From: Keerthy <j-keerthy@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <rui.zhang@intel.com>, <robh+dt@kernel.org>,
	<daniel.lezcano@linaro.org>, <amit.kucheria@verdurent.com>,
	<t-kristo@ti.com>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-pm@vger.kernel.org>, <mark.rutland@arm.com>
Subject: Re: [PATCH 1/4] dt-bindings: thermal: k3: Add VTM bindings documentation
Date: Fri, 14 Feb 2020 11:55:39 +0530	[thread overview]
Message-ID: <a1022021-1c4c-4a4b-8391-776df0d03a82@ti.com> (raw)
In-Reply-To: <20200213204738.GA2973@bogus>

On 14/02/20 2:17 am, Rob Herring wrote:
> On Thu, 13 Feb 2020 15:54:37 +0530, Keerthy wrote:
>> Add VTM bindings documentation. In the Voltage Thermal
>> Management Module(VTM), K3 AM654 supplies a voltage
>> reference and a temperature sensor feature that are gathered in the band
>> gap voltage and temperature sensor (VBGAPTS) module. The band
>> gap provides current and voltage reference for its internal
>> circuits and other analog IP blocks. The analog-to-digital
>> converter (ADC) produces an output value that is proportional
>> to the silicon temperature.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>   .../bindings/thermal/ti,am654-thermal.yaml    | 59 +++++++++++++++++++
>>   1 file changed, 59 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/thermal/ti,am654-thermal.yaml
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:

I will fix them and resend v2.

> 
> warning: no schema found in file: Documentation/devicetree/bindings/thermal/ti,am654-thermal.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/ti,am654-thermal.yaml: ignoring, error parsing file
> Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
> Traceback (most recent call last):
>    File "/usr/local/bin/dt-doc-validate", line 35, in check_doc
>      testtree = dtschema.load(filename, line_number=line_number, duplicate_keys=False)
>    File "/usr/local/lib/python3.6/dist-packages/dtschema/lib.py", line 513, in load
>      return yaml.load(f.read())
>    File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/main.py", line 343, in load
>      return constructor.get_single_data()
>    File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/constructor.py", line 111, in get_single_data
>      node = self.composer.get_single_node()
>    File "_ruamel_yaml.pyx", line 718, in _ruamel_yaml.CParser.get_single_node
> ruamel.yaml.composer.ComposerError: expected a single document in the stream
>    in "<unicode string>", line 2, column 1
> but found another document
>    in "<unicode string>", line 4, column 1
> 
> During handling of the above exception, another exception occurred:
> 
> Traceback (most recent call last):
>    File "/usr/local/bin/dt-doc-validate", line 74, in <module>
>      ret = check_doc(args.yamldt)
>    File "/usr/local/bin/dt-doc-validate", line 40, in check_doc
>      print(filename + ":", exc.path[-1], exc.message)
> AttributeError: 'ComposerError' object has no attribute 'path'
> Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/thermal/ti,am654-thermal.example.dts' failed
> make[1]: *** [Documentation/devicetree/bindings/thermal/ti,am654-thermal.example.dts] Error 1
> Makefile:1263: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
> 
> See https://patchwork.ozlabs.org/patch/1237405
> Please check and re-submit.
> 