From: Andrzej Hajda <a.hajda@samsung.com>
To: Colin King <colin.king@canonical.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: make const array static
Date: Wed, 27 Feb 2019 13:20:36 +0100 [thread overview]
Message-ID: <a10c5be3-9223-a1b7-a3d5-22d7ec6542eb@samsung.com> (raw)
In-Reply-To: <20190226165932.17528-1-colin.king@canonical.com>
On 26.02.2019 17:59, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array ti_sn_bridge_supply_names on the
> stack but instead make it static.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index f72ee137e5f1..4c2ca4e39be5 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -211,7 +211,7 @@ static struct ti_sn_bridge *bridge_to_ti_sn_bridge(struct drm_bridge *bridge)
> static int ti_sn_bridge_parse_regulators(struct ti_sn_bridge *pdata)
> {
> unsigned int i;
> - const char * const ti_sn_bridge_supply_names[] = {
> + static const char * const ti_sn_bridge_supply_names[] = {
> "vcca", "vcc", "vccio", "vpll",
> };
>
prev parent reply other threads:[~2019-02-27 12:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190226165938epcas2p2aba05bf0a7b1b992ff2f71c0bfcffb6a@epcas2p2.samsung.com>
2019-02-26 16:59 ` [PATCH] drm/bridge: ti-sn65dsi86: make const array static Colin King
2019-02-27 12:20 ` Andrzej Hajda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a10c5be3-9223-a1b7-a3d5-22d7ec6542eb@samsung.com \
--to=a.hajda@samsung.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=colin.king@canonical.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).