From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA4DACA9ED0 for ; Fri, 1 Nov 2019 16:50:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0F47218DE for ; Fri, 1 Nov 2019 16:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572627014; bh=BUpvPIgCiek5J4CeLj4ca43Fs+r3iHsHbPYrxAmt2wE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=smL6K8ZgKzijoNQPPRkTniBsRfCY6dHG+41WpL4JXv9zRpFNhFnVoOI+HerPDD2UE sHSUGUntlG5wGdMQtDgsO3BGgSIJx5FhfaM3nsK0kouRRU8YafGDV8tRTx48zC0wko ABNnv3Olt4kalHdwgqdDXbgGP8C898a9VHXQByno= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729014AbfKAQuN (ORCPT ); Fri, 1 Nov 2019 12:50:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:55056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726825AbfKAQuN (ORCPT ); Fri, 1 Nov 2019 12:50:13 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15D052080F; Fri, 1 Nov 2019 16:50:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572627012; bh=BUpvPIgCiek5J4CeLj4ca43Fs+r3iHsHbPYrxAmt2wE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=psFXQRDbxkTKxYUj7eTf2Omjo3astwoXfflW1bYkNIZmTuZD+EtesRws9UOkeYe91 IFZOcdy87wphXGkpuiDJs8rspxU3g4InAIWj8GjQJ6G/4herpdB9aV2dqStRjNlC9x ow6EgmD3OczIPTgaA4qoa5ZVWNCdPZpOmHt5oMAI= Subject: Re: [PATCH linux-kselftest/test v6] lib/list-test: add a test for the 'list' doubly linked list To: Joe Perches , Dan Carpenter Cc: David Gow , Brendan Higgins , Andrew Morton , Kees Cook , "open list:KERNEL SELFTEST FRAMEWORK" , kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, shuah References: <20191024224631.118656-1-davidgow@google.com> <0cb1d948-0da3-eb0f-c58f-ae3a785dd0dd@kernel.org> <20191030104217.GA18421@kadam> <42a8270d-ed6f-d29f-5e71-7b76a074b63e@kernel.org> <20191030191255.GD18421@kadam> From: shuah Message-ID: Date: Fri, 1 Nov 2019 10:49:51 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/19 1:23 PM, Joe Perches wrote: > On Wed, 2019-10-30 at 22:12 +0300, Dan Carpenter wrote: >> On Wed, Oct 30, 2019 at 10:27:12AM -0600, shuah wrote: >>>> It's better to ignore checkpatch and other scripts when they are wrong. >>>> (unless the warning message inspires you to make the code more readable >>>> for humans). >>>> >>> >>> It gets confusing when to ignore and when not to. It takes work to >>> figure out and it is subjective. >>> >> >> In this case, it's not subjective because checkpatch is clearly not >> working as intended. > > checkpatch _is_ working as intended. > It was never intended to be perfect. > > checkpatch _always_ depended on a reviewer deciding > whether its output was appropriate. > >> I don't feel like "checkpatch clean" is a useful criteria for applying >> patches. > > Nor do I. > >> The other things about warnings is that I always encourage people to >> just ignore old warnings. If you're running Smatch and you see a >> warning in ancient code that means I saw it five years ago and didn't >> fix it so it's a false positive. Old warnings are always 100% false >> positives. > > That'd be not absolute either because it depended on your > historical judgment as to whether an old warning was in fact > a defect or not. > > People make mistakes. > Regex based scripts are by design stupid and untrustworthy. > > Mistakes will be made. > Just fix the actual defects in code as soon as possible. > > > Thanks all for chiming in. I am taking v6 as is and adding an update to commit log capture the spurious errors from checkpath.pl for this specific case. thanks, -- Shuah