LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: avoid fi->i_gc_rwsem[WRITE] lock in f2fs_gc
Date: Mon, 20 Aug 2018 15:13:04 +0800
Message-ID: <a12d7501-2156-2492-7fe2-8727f91bd5ff@huawei.com> (raw)
In-Reply-To: <20180810014614.GA44979@jaegeuk-macbookpro.roam.corp.google.com>

Hi Jaegeuk,

Please add:

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

On 2018/8/10 9:46, Jaegeuk Kim wrote:
> On 08/10, Chao Yu wrote:
>> On 2018/8/10 3:59, Jaegeuk Kim wrote:
>>> Yup, how about this?
>>>
>>> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
>>> index d816c328f02b..cb510fb36523 100644
>>> --- a/fs/f2fs/gc.c
>>> +++ b/fs/f2fs/gc.c
>>> @@ -1052,6 +1052,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
>>>  		.iroot = RADIX_TREE_INIT(gc_list.iroot, GFP_NOFS),
>>>  	};
>>>  	unsigned long long last_skipped = sbi->skipped_atomic_files[FG_GC];
>>> +	unsigned long long first_skipped;
>>>  	unsigned int skipped_round = 0, round = 0;
>>>  
>>>  	trace_f2fs_gc_begin(sbi->sb, sync, background,
>>> @@ -1064,8 +1065,10 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
>>>  				prefree_segments(sbi));
>>>  
>>>  	cpc.reason = __get_cp_reason(sbi);
>>> -	sbi->skipped_gc_rwsem = 0;
>>>  gc_more:
>>> +	sbi->skipped_gc_rwsem = 0;
>>> +	first_skipped = last_skipped;
>>> +
>>>  	if (unlikely(!(sbi->sb->s_flags & SB_ACTIVE))) {
>>>  		ret = -EINVAL;
>>>  		goto stop;
>>> @@ -1126,8 +1129,8 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
>>>  			goto gc_more;
>>>  		}
>>>  
>>> -		if (sbi->skipped_atomic_files[FG_GC] == last_skipped &&
>>> -				sbi->skipped_atomic_files[FG_GC] >
>>> +		if (first_skipped < last_skipped &&
>>> +				(last_skipped - first_skipped) >
>>
>> IMO, it would be better to judge the condition with skipped number in all round
>> of FGGC instead of last round, since number in last round may not very accurate.
> 
> Yup, moved before gc_more.
> 
>>
>> Thoughts?
>>
>> Thanks,
>>
>>>  						sbi->skipped_gc_rwsem) {
>>>  			f2fs_drop_inmem_pages_all(sbi, true);
>>>  			segno = NULL_SEGNO;
>>>
>>> .
>>>
> 
> .
> 


      reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30  1:32 [PATCH] " Jaegeuk Kim
2018-07-30  3:29 ` Chao Yu
2018-07-30  4:18   ` Jaegeuk Kim
2018-07-30  6:36     ` Chao Yu
2018-07-30  9:08       ` Jaegeuk Kim
2018-07-30  9:28         ` Chao Yu
2018-07-30 10:00           ` Jaegeuk Kim
2018-08-04  2:31             ` [f2fs-dev] " Chao Yu
2018-08-12 10:24               ` Chao Yu
2018-08-13 20:12                 ` Jaegeuk Kim
2018-08-14  6:21                   ` Chao Yu
2018-08-04 22:29 ` [PATCH v2] " Jaegeuk Kim
2018-08-05 14:42   ` [f2fs-dev] " Chao Yu
2018-08-05 16:08     ` Jaegeuk Kim
2018-08-05 16:34   ` [f2fs-dev] [PATCH v3] " Jaegeuk Kim
2018-08-09  1:44     ` Chao Yu
2018-08-09 19:59       ` Jaegeuk Kim
2018-08-10  1:36         ` Chao Yu
2018-08-10  1:46           ` Jaegeuk Kim
2018-08-20  7:13             ` Chao Yu [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a12d7501-2156-2492-7fe2-8727f91bd5ff@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox