From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C9D3C43460 for ; Thu, 22 Apr 2021 08:57:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15FCE6145B for ; Thu, 22 Apr 2021 08:57:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235561AbhDVI6X (ORCPT ); Thu, 22 Apr 2021 04:58:23 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:16613 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230316AbhDVI6V (ORCPT ); Thu, 22 Apr 2021 04:58:21 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FQrpy1lqmz16LWd; Thu, 22 Apr 2021 16:55:22 +0800 (CST) Received: from [127.0.0.1] (10.174.177.72) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.498.0; Thu, 22 Apr 2021 16:57:40 +0800 Subject: Re: [PATCH 1/1] dt-bindings: serial: Add label property for pl011 From: "Leizhen (ThunderTown)" To: Rob Herring CC: Greg Kroah-Hartman , linux-serial , devicetree , linux-kernel References: <20210415073105.3687-1-thunder.leizhen@huawei.com> <20210420200246.GA3717650@robh.at.kernel.org> <6491648e-aab1-72cb-c766-5c4eff331412@huawei.com> Message-ID: Date: Thu, 22 Apr 2021 16:57:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <6491648e-aab1-72cb-c766-5c4eff331412@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/4/22 11:10, Leizhen (ThunderTown) wrote: > > > On 2021/4/21 21:53, Rob Herring wrote: >> On Wed, Apr 21, 2021 at 4:38 AM Leizhen (ThunderTown) >> wrote: >>> >>> >>> >>> On 2021/4/21 4:02, Rob Herring wrote: >>>> On Thu, Apr 15, 2021 at 03:31:05PM +0800, Zhen Lei wrote: >>>>> When there is more than one pl011 serial port present, the label property >>>>> allows a custom name to be used for briefly describe the usage or position >>>>> of each serial port. >>>>> >>>>> Without this "label" property, many dtbs_check warnings similar to the >>>>> following are reported: >>>>> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dt.yaml: \ >>>>> serial@ffd74000: Additional properties are not allowed ('label' was unexpected) >>>>> From schema: Documentation/devicetree/bindings/serial/pl011.yaml >>>> >>>> I think this should go into serial.yaml instead. >>> >>> Yes，But if I add "label: true" into serial.yaml, it doesn't work. I haven't figured out why. >> >> Change the 'additionalProperties: false' to 'unevaluatedProperties: false'. > > Wow, it works. I admire you so much. You're a master. > >> >>> By the way, should "$ref: /schemas/serial.yaml#" be replaced with "$ref: /schemas/serial/serial.yaml#"? >> >> Oh, yes! Looks like it should be fixed for the other serial schemas >> too. There is a /schemas/serial.yaml schema from dt-schema which >> predates the kernel one, but it just has the $nodename. The kernel one >> is much more complete. > > All right, I'll fix them all. I checked all YAML files in directory Documentation/devicetree/bindings/serial/, except pl011.yaml, all that need to be modified are modified. No similar ('xxx' was unexpected) warnings are reported. > >> >> Rob >> >> . >>