From: Praveen Kumar <kumarpraveen@linux.microsoft.com>
To: Deepak R Varma <drv@mailo.com>,
outreachy@lists.linux.dev, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, paskripkin@gmail.com,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, saurabh.truth@gmail.com
Subject: Re: [PATCH v4 08/11] staging: r8188eu: replace leading spaces by tabs
Date: Fri, 21 Oct 2022 11:04:49 +0530 [thread overview]
Message-ID: <a1429a6a-1688-c30a-4fb2-3d575ffecbf1@linux.microsoft.com> (raw)
In-Reply-To: <c32b702c61ea3367d60f0a4c2443093d6ce45a69.1666299151.git.drv@mailo.com>
On 21-10-2022 03:01, Deepak R Varma wrote:
> Spaces are prohibited as per the Linux coding style guidelines. Replace
> those by tabs wherever possible to improve code alignment. Error
> reported by checkpatch script.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
>
> Changes in v4:
> -- None.
>
> Changes in v3:
> 1. Patch newly added in the patch set.
>
> drivers/staging/r8188eu/include/rtw_cmd.h | 10 +++++-----
> drivers/staging/r8188eu/include/rtw_mlme.h | 2 +-
> drivers/staging/r8188eu/include/rtw_mlme_ext.h | 2 +-
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/include/rtw_cmd.h b/drivers/staging/r8188eu/include/rtw_cmd.h
> index 61fb523afb08..4b6a91aefc1e 100644
> --- a/drivers/staging/r8188eu/include/rtw_cmd.h
> +++ b/drivers/staging/r8188eu/include/rtw_cmd.h
> @@ -592,14 +592,14 @@ struct setratable_parm {
> };
>
> struct getratable_parm {
> - uint rsvd;
> + uint rsvd;
> };
>
> struct getratable_rsp {
> - u8 ss_ForceUp[NumRates];
> - u8 ss_ULevel[NumRates];
> - u8 ss_DLevel[NumRates];
> - u8 count_judge[NumRates];
> + u8 ss_ForceUp[NumRates];
> + u8 ss_ULevel[NumRates];
> + u8 ss_DLevel[NumRates];
Can this be reworked further like ss_ForceUp -> ss_force_up or ss_forceup ?
Similarly for other attributes.
> + u8 count_judge[NumRates];
> };
>
> /* to get TX,RX retry count */
> diff --git a/drivers/staging/r8188eu/include/rtw_mlme.h b/drivers/staging/r8188eu/include/rtw_mlme.h
> index 7658f864136e..ebf7168a7ef9 100644
> --- a/drivers/staging/r8188eu/include/rtw_mlme.h
> +++ b/drivers/staging/r8188eu/include/rtw_mlme.h
> @@ -528,7 +528,7 @@ void rtw_indicate_scan_done(struct adapter *padapter);
> int rtw_restruct_sec_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie,
> uint in_len);
> int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie,
> - uint in_len, uint initial_out_len);
> + uint in_len, uint initial_out_len);
> void rtw_init_registrypriv_dev_network(struct adapter *adapter);
>
> void rtw_update_registrypriv_dev_network(struct adapter *adapter);
> diff --git a/drivers/staging/r8188eu/include/rtw_mlme_ext.h b/drivers/staging/r8188eu/include/rtw_mlme_ext.h
> index be470f913a94..413b94e38744 100644
> --- a/drivers/staging/r8188eu/include/rtw_mlme_ext.h
> +++ b/drivers/staging/r8188eu/include/rtw_mlme_ext.h
> @@ -449,7 +449,7 @@ void ERP_IE_handler(struct adapter *padapter, struct ndis_802_11_var_ie *pIE);
> void VCS_update(struct adapter *padapter, struct sta_info *psta);
>
> void update_beacon_info(struct adapter *padapter, u8 *pframe, uint len,
> - struct sta_info *psta);
> + struct sta_info *psta);
> int rtw_check_bcn_info(struct adapter *Adapter, u8 *pframe, u32 packet_len);
> void update_IOT_info(struct adapter *padapter);
> void update_capinfo(struct adapter *adapter, u16 updatecap);
> --
> 2.30.2
>
>
>
Regards,
~Praveen.
next prev parent reply other threads:[~2022-10-21 5:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 21:26 [PATCH v4 00/11] staging: r8188eu: trivial code cleanup patches Deepak R Varma
2022-10-20 21:26 ` [PATCH v4 01/11] staging: r8188eu: use Linux kernel variable naming convention Deepak R Varma
2022-10-20 21:27 ` [PATCH v4 02/11] staging: r8188eu: reformat long computation lines Deepak R Varma
2022-10-20 21:27 ` [PATCH v4 03/11] staging: r8188eu: remove {} for single statement blocks Deepak R Varma
2022-10-20 21:28 ` [PATCH v4 04/11] staging: r8188eu: use htons macro instead of __constant_htons Deepak R Varma
2022-10-20 21:29 ` [PATCH v4 05/11] staging: r8188eu: correct misspelled words in comments Deepak R Varma
2022-10-20 21:30 ` [PATCH v4 06/11] staging: r8188eu: Add space between function & macro parameters Deepak R Varma
2022-10-20 21:30 ` [PATCH v4 07/11] staging: r8188eu: Associate pointer symbol with parameter name Deepak R Varma
2022-10-20 21:31 ` [PATCH v4 08/11] staging: r8188eu: replace leading spaces by tabs Deepak R Varma
2022-10-21 5:34 ` Praveen Kumar [this message]
2022-10-20 23:31 ` Deepak R Varma
2022-10-20 21:31 ` [PATCH v4 09/11] staging: r8188eu: Put '{" on the symbol declaration line Deepak R Varma
2022-10-20 21:32 ` [PATCH v4 10/11] staging: r8188eu: Correct missing or extra space in the statements Deepak R Varma
2022-10-20 21:32 ` [PATCH v4 11/11] staging: r8188eu: Remove unused macros Deepak R Varma
2022-10-21 5:51 ` Praveen Kumar
2022-10-21 5:56 ` Greg KH
2022-10-20 23:34 ` Deepak R Varma
2022-10-21 8:33 ` Greg KH
2022-10-20 23:50 ` Deepak R Varma
2022-10-21 5:20 ` [PATCH v4 00/11] staging: r8188eu: trivial code cleanup patches Philipp Hortmann
2022-10-22 8:05 ` Greg KH
2022-10-21 16:49 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1429a6a-1688-c30a-4fb2-3d575ffecbf1@linux.microsoft.com \
--to=kumarpraveen@linux.microsoft.com \
--cc=Larry.Finger@lwfinger.net \
--cc=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=saurabh.truth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).