From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Kukjin Kim <kgene@kernel.org>, Anand Moon <linux.amoon@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Peter Chen <peter.chen@nxp.com>,
gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
ulf.hansson@linaro.org, broonie@kernel.org, sre@kernel.org,
robh+dt@kernel.org, linux-usb@vger.kernel.org,
linux-pm@vger.kernel.org, hverkuil@xs4all.nl,
Markus Reichl <m.reichl@fivetechno.de>
Subject: Re: [PATCH 2/4] ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot
Date: Mon, 9 Jan 2017 13:17:38 -0300 [thread overview]
Message-ID: <a145363b-4c88-ed27-839e-f71c9430dcf9@osg.samsung.com> (raw)
In-Reply-To: <20170107085203.4431-3-krzk@kernel.org>
Hello Krzysztof,
On 01/07/2017 05:52 AM, Krzysztof Kozlowski wrote:
> The ethernet adapter LAN9730, after enabling in bootloader (e.g. for
> tftpboot) requires reset during boot. Otherwise it won't come up.
>
> The schematics of Odroid U3 are detailed enough but after grabbing
> knowledge also from other sources (like U-Boot) the overall design looks
> like:
> 1. LAN9730 is connected to HSIC0 and USB3503 to HSIC1 of EHCI controller.
> 2. USB3503 comes with its own reset pin: gpx3-5.
> 3. Reset pin of LAN9730 is pulled up to 3.3 V so it cannot be used.
> 4. The supply of 3.3 V for LAN9730 is delivered from buck8.
> 5. Buck8 state is a logical OR of registry value (through I2C command)
> and ENB8 pin. The ENB8, not described in schematics, is in fact
> gpa1-1.
> 6. Missing or wrongly timed reset of LAN9730 might result in missing of
> two devices: LAN9730 and USB3503. Without reset, LAN9730 will not
> come up, if it was enabled by bootloader.
>
> To fix the issue use the generic power sequence driver and toggle the
> ENB8 (buck8) pin. Reset duration of 500 us was chosen by experiments
> (shortest working time was 400 us). This is an easiest way to fix the
> long standing LAN9730 reset issue.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
Thanks for keep pushing a fix for this long standing issue.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2017-01-09 16:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 8:51 [PATCH 0/4] ARM: exynos: Fix Odroid U3 USB/LAN when TFTP booting (power sequence) Krzysztof Kozlowski
2017-01-07 8:52 ` [PATCH 1/4] ARM: dts: exynos: Fix indentation of EHCI and OHCI ports Krzysztof Kozlowski
2017-01-09 16:01 ` Javier Martinez Canillas
2017-01-07 8:52 ` [PATCH 2/4] ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot Krzysztof Kozlowski
2017-01-09 16:17 ` Javier Martinez Canillas [this message]
2017-01-07 8:52 ` [PATCH 3/4] ARM: exynos_defconfig: Enable power sequence for Odroid U3 Krzysztof Kozlowski
2017-01-09 16:19 ` Javier Martinez Canillas
2017-01-07 8:52 ` [PATCH 4/4] ARM: multi_v7_defconfig: " Krzysztof Kozlowski
2017-01-07 9:16 ` [PATCH v1.1] " Krzysztof Kozlowski
2017-01-09 16:24 ` Javier Martinez Canillas
2017-01-09 17:38 ` Krzysztof Kozlowski
2017-01-09 17:44 ` Javier Martinez Canillas
2017-01-09 18:04 ` [PATCH 0/4] ARM: exynos: Fix Odroid U3 USB/LAN when TFTP booting (power sequence) Anand Moon
2017-01-09 18:17 ` Krzysztof Kozlowski
2017-01-09 18:26 ` Anand Moon
2017-01-09 18:35 ` Krzysztof Kozlowski
2017-03-29 11:12 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a145363b-4c88-ed27-839e-f71c9430dcf9@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=m.reichl@fivetechno.de \
--cc=m.szyprowski@samsung.com \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sre@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).