From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F770C433F5 for ; Sat, 20 Nov 2021 21:48:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231390AbhKTVvH (ORCPT ); Sat, 20 Nov 2021 16:51:07 -0500 Received: from mail-0201.mail-europe.com ([51.77.79.158]:53606 "EHLO mail-0201.mail-europe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbhKTVvF (ORCPT ); Sat, 20 Nov 2021 16:51:05 -0500 Date: Sat, 20 Nov 2021 21:47:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connolly.tech; s=protonmail; t=1637444878; bh=2Y2y86H9TPwE4dS4X+Ec6pt6QcS7T+DsQvhWBMghZZA=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=J0PDK79KCFeJ5PNlHnAoyoMuvkDdhNw+liexWI751OEDX7AAeWw6BVtbbj8KRh731 09TesZ9dtGyU9Dn9EAiLoYbqfQwVfR1/V1iDm7nh5VhgGFZNRZp8JGAH9ctGSr+Ldi csCy1Rl2dNBsVSccqsLxvDQOXdrduGtyM/sA4I7g= To: Dang Huynh From: Caleb Connolly Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Min , Martin Botka , Konrad Dybcio , Konrad Dybcio Reply-To: Caleb Connolly Subject: Re: [PATCH v4 2/8] arm64: dts: qcom: sdm630-pm660: Move RESIN to pm660 dtsi Message-ID: In-Reply-To: <20211120214227.779742-3-danct12@riseup.net> References: <20211120214227.779742-1-danct12@riseup.net> <20211120214227.779742-3-danct12@riseup.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/11/2021 21:42, Dang Huynh wrote: > It's not worth duplicating the same node over and over again, > so let's keep the common bits in the pm660 DTSI, making only > changing the status and keycode necessary. > > Also, disable RESIN/PWR by default just in case if there are > devices that doesn't use them. > > Reviewed-by: Konrad Dybcio > Signed-off-by: Dang Huynh > --- > arch/arm64/boot/dts/qcom/pm660.dtsi | 12 +++++++++++- > .../boot/dts/qcom/sdm630-sony-xperia-nile.dtsi | 16 ++++++++-------- > 2 files changed, 19 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/pm660.dtsi b/arch/arm64/boot/dts/qc= om/pm660.dtsi > index d0ef8a1675e2..c482663aad56 100644 > --- a/arch/arm64/boot/dts/qcom/pm660.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm660.dtsi > @@ -54,14 +54,24 @@ pon: pon@800 { > =09=09=09mode-bootloader =3D <0x2>; > =09=09=09mode-recovery =3D <0x1>; > > -=09=09=09pwrkey { > +=09=09=09pon_pwrkey: pwrkey { > =09=09=09=09compatible =3D "qcom,pm8941-pwrkey"; > =09=09=09=09interrupts =3D <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; > =09=09=09=09debounce =3D <15625>; > =09=09=09=09bias-pull-up; > =09=09=09=09linux,code =3D ; > + > +=09=09=09=09status =3D "disabled"; > =09=09=09}; > > +=09=09=09pon_resin: resin { > +=09=09=09=09compatible =3D "qcom,pm8941-resin"; > +=09=09=09=09interrupts =3D <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>; > +=09=09=09=09debounce =3D <15625>; > +=09=09=09=09bias-pull-up; > + > +=09=09=09=09status =3D "disabled"; > +=09=09=09}; > =09=09}; > > =09=09pm660_temp: temp-alarm@2400 { > diff --git a/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi b/arch= /arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi > index 11d0a8c1cf35..e90c9ec84675 100644 > --- a/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi > @@ -215,14 +215,14 @@ &blsp2_uart1 { > =09/* HCI Bluetooth */ > }; > > -&pon { > -=09volup { > -=09=09compatible =3D "qcom,pm8941-resin"; > -=09=09interrupts =3D <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>; > -=09=09debounce =3D <15625>; > -=09=09bias-pull-up; > -=09=09linux,code =3D ; > -=09}; > +&pon_pwrkey { > +=09status =3D "okay"; > +}; > + > +&pon_resin { > +=09status =3D "okay"; > + > +=09linux,code =3D ; > }; > > &qusb2phy { > -- > 2.33.1 > Reviewed-by: Caleb Connolly -- Kind Regards, Caleb