Build error in -next due to ion patches when building sparc64:allmodconfig

Build error in -next due to ion patches when building sparc64:allmodconfig

[Guenter Roeck]

Hi Laura,

I see the following build error in -next.

Building sparc64:allmodconfig ... failed
--------------
Error log:
...
drivers/built-in.o: In function `ion_parse_dt':
(.text+0x11aa2c): undefined reference to `of_platform_device_create'

of_platform_device_create() depends on CONFIG_OF_ADDRESS, which is not
supported on sparc. Maybe add "depends on OF_ADDRESS" to the Kconfig file ?

Thanks,
Guenter

[PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS

[Laura Abbott]

The Ion platform code uses of_platform_device_create which has
dependencies on OF_ADDRESS. Depending on OF is not sufficient

Building sparc64:allmodconfig ... failed
--------------
Error log:
...
drivers/built-in.o: In function `ion_parse_dt':
(.text+0x11aa2c): undefined reference to `of_platform_device_create'

Add a dependency on OF_ADDRESS

Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Laura Abbott <labbott@redhat.com>
---
Based on next-20160914
---
 drivers/staging/android/ion/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
index 8a54ddc..9410554 100644
--- a/drivers/staging/android/ion/Kconfig
+++ b/drivers/staging/android/ion/Kconfig
@@ -43,7 +43,7 @@ source "drivers/staging/android/ion/hisilicon/Kconfig"
 
 config ION_OF
 	bool "Devicetree support for Ion"
-	depends on ION && OF
+	depends on ION && OF_ADDRESS
 	help
 	  Provides base support for defining Ion heaps in devicetree
 	  and setting them up. Also includes functions for platforms
-- 
2.7.4

Re: [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS

[Sumit Semwal]

Hi Laura,

On 14 September 2016 at 21:03, Laura Abbott <labbott@redhat.com> wrote:
> The Ion platform code uses of_platform_device_create which has
> dependencies on OF_ADDRESS. Depending on OF is not sufficient
>
Thanks for the patch; looks good to me.
Please feel free to apply my
Reviewed-by: Sumit Semwal <sumit.semwal@linaro.org>

Best,
Sumit.

> Building sparc64:allmodconfig ... failed
> --------------
> Error log:
> ...
> drivers/built-in.o: In function `ion_parse_dt':
> (.text+0x11aa2c): undefined reference to `of_platform_device_create'
>
> Add a dependency on OF_ADDRESS
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> Based on next-20160914
> ---
>  drivers/staging/android/ion/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
> index 8a54ddc..9410554 100644
> --- a/drivers/staging/android/ion/Kconfig
> +++ b/drivers/staging/android/ion/Kconfig
> @@ -43,7 +43,7 @@ source "drivers/staging/android/ion/hisilicon/Kconfig"
>
>  config ION_OF
>         bool "Devicetree support for Ion"
> -       depends on ION && OF
> +       depends on ION && OF_ADDRESS
>         help
>           Provides base support for defining Ion heaps in devicetree
>           and setting them up. Also includes functions for platforms
> --
> 2.7.4
>

Re: [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS

[Guenter Roeck]

On Wed, Sep 14, 2016 at 08:33:58AM -0700, Laura Abbott wrote:
> The Ion platform code uses of_platform_device_create which has
> dependencies on OF_ADDRESS. Depending on OF is not sufficient
> 
> Building sparc64:allmodconfig ... failed
> --------------
> Error log:
> ...
> drivers/built-in.o: In function `ion_parse_dt':
> (.text+0x11aa2c): undefined reference to `of_platform_device_create'
> 
> Add a dependency on OF_ADDRESS
> 
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Laura Abbott <labbott@redhat.com>

Tested-by: Guenter Roeck <linux@roeck-us.net>

> ---
> Based on next-20160914
> ---
>  drivers/staging/android/ion/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
> index 8a54ddc..9410554 100644
> --- a/drivers/staging/android/ion/Kconfig
> +++ b/drivers/staging/android/ion/Kconfig
> @@ -43,7 +43,7 @@ source "drivers/staging/android/ion/hisilicon/Kconfig"
>  
>  config ION_OF
>  	bool "Devicetree support for Ion"
> -	depends on ION && OF
> +	depends on ION && OF_ADDRESS
>  	help
>  	  Provides base support for defining Ion heaps in devicetree
>  	  and setting them up. Also includes functions for platforms
> -- 
> 2.7.4
>