From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753547AbdEENUD (ORCPT ); Fri, 5 May 2017 09:20:03 -0400 Received: from mail-he1eur01on0137.outbound.protection.outlook.com ([104.47.0.137]:48617 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752478AbdEENT7 (ORCPT ); Fri, 5 May 2017 09:19:59 -0400 Authentication-Results: pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dmarc=none action=none header.from=axentia.se; Subject: Re: [PATCH v13 03/10] mux: minimal mux subsystem and gpio-based mux controller To: Greg Kroah-Hartman References: <1492101794-13444-1-git-send-email-peda@axentia.se> <1492101794-13444-4-git-send-email-peda@axentia.se> <20170418085156.GA4773@kroah.com> CC: , Wolfram Sang , Rob Herring , Mark Rutland , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Corbet , , , , , Andrew Morton , Colin Ian King , Paul Gortmaker , Philipp Zabel , From: Peter Rosin Organization: Axentia Technologies AB Message-ID: Date: Fri, 5 May 2017 15:19:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [81.224.171.159] X-ClientProxiedBy: HE1PR0502CA0009.eurprd05.prod.outlook.com (10.175.36.147) To HE1PR0202MB2555.eurprd02.prod.outlook.com (10.168.184.8) X-MS-Office365-Filtering-Correlation-Id: b213dd3b-807b-4915-fd34-08d493b96ad8 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075);SRVR:HE1PR0202MB2555; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0202MB2555;3:ZK6xrc/o5VhfhHwkpFiBKLKFVd7zeEKDG6uaE/KiWk+mofvV2G2zAzFsL1G44DQNR2mSVQpkg/v/bwB5Tjc2gRFIUdBawerhyE/SUtJ/unKTKVZALCGBJ1ZGf1hE0oB0c3lHJ2Rszwu4T+j2lIzBGn2o5E+6/Kkqr2fimk+K1YHHJJXI+oPxrq8mrt3aFOcs8Xxj1ciGj2oB7+ldNFRUOEOtlXSbFw9xcAzmipV7vAE3P+VVLa5sGlUg+vQHhaeEJg26MZ95pkEdhvpvCVji7Qx5WN5Md0o0TMLBHA88Ji5tyzw1tFMWW85W6MSEkrA7;25:hsNHw6X2sZjGJMWE5CnZshZkYKU0tJvCk6GdbUcAdPb85zCHH26i78lBJChwTx4aV1Yit3r6w71Ar5dgMkhg5pgmHjnoglK+eT6RCe6+M6J5ZiIZa4lgiYO6du5/r9M+W9tG7KbA8d0x2FmlNYNfBpcpUpIOaOTNbrmbCWUZXQlZkfIoUGqenhrLbkQcqZ6JbN0mWyzfO5dlxwdILw6+oMGkcsQQB6rNOx9neSh4F0RgynhbaDbaDy4kAr6wTmkl3nbw8mfftY61w/K/EWSAkyZthc7EmH1H0i81CAFFBVjDH6QX75Jvo91encPcsWdCfTtNNZs6c+VuBxcPuNtcumTo2eH7+X3bQXyCnUzSixIJxzLQHwrd2LcniUOFYGg3tM+faFRkch/7pF3vNppzafGE9z3RJR1QhkJmpns0zgBQ6ET2Ah04afdZJd3mZt7I X-Microsoft-Exchange-Diagnostics: 1;HE1PR0202MB2555;31:fNX6N6tfrVl+7QBkU/TjCKKxEQ6m6xa2W/y21Ar7AMC91+svO0fW9QmS8na3FTt5tyr5vAjWmXxGQPC8eFn2NRa1ueOFv0sD2vX//3oBrquvM/N4owC0lpHOb7fxCV+2ngR43kwy+x78IcSkeCBUjClpm0zZgMvtMSCBg+e++7H0brS6vGdoLC2GDIjebMw1DTPWGtPwacRFKqq+Aa2eobsWOdkyRC9GIrrbxDSr6In6flMi2GDAGNaj1wGwDi9WkU+PBsTopx6AIsMBJGMV/g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(4782527817362); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123558100)(2016111802025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(6072148)(6043046);SRVR:HE1PR0202MB2555;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0202MB2555; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0202MB2555;4:pqw8ryufEn/Cxi2vuMNfQXHWlQUkOSb9RWxJw/DElmnQW1l6zY74Ai3mKKmKoavUubs3YffkVIVumJnIdRkkr4CSv19C4xer9meZbzFTzNyHux2MIEdOgJBqmer2IEAwH/I2wgBRrCvnYMAy7oIdpqdZFSWUBN6JH+cyLDBX5iZ9E+RPy6DxcNnwgARaLVl/ZfMkNKQojUZ7d8lUtP/lt9zwn7Jhj7ybd99l0ZNkZxCggdQUBBegT3YY5ZjPDw8le+vaPQwpFfzvXFc8V7LWaqIANf1pZxX49kT9ipKheoHy/grFnQjzDDuwE6aak2NaNwmPF/xu5qN43m4bMQY1RamVKZorZKw4lJZQm7vjJKz04PzY/z2UH+buG6rGkT+Qo44E2LnKPpKDz0A+4i9HMfmGgPd9G2LPFQ1osZY0kfLIPhmjZJw61Yf+dzIEUm1mehQzAJ8wVa2QnuLq9ta++RkuNzFMSvXlVIOXbPkWbIj1Eny+i7GWeG+3gnds8qkHUqTvmJDCKC7GDSZqXX9fqzNNgQMoyhxkgTP/jRMPLhh7RfQCTdPd8R5C9nn13m6QFwYMGUXFFuFHvY59VBW6UHozjbYqaw1TR1aSX/a259SuF0kGgKfcg16MsWj2FOfNNs3lfcQEkx08n2IHdsRFpjL/YfKdO+S1jDRXvjw5NIIrzKxen7mAXPtvb53BYihzoLbY0oxJrdlytSQkxxli2WalHGJ823CPfrJVNmCqgHzL6LO+SNzv7NSjxfkB9fPsc2jWrD8oQEH2FJOmTGGt49uuhakwvUPLR3FWDrcpjnS2Y4WLhfigrgz1tx5RP2eExXqHreurLsTDceyNpQlznm9BdRYMmc9qbgxAbKOEZIKZfcvHUKBbUQLVs5rX9zzx X-Forefront-PRVS: 02981BE340 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39400400002)(39410400002)(39450400003)(24454002)(377424004)(36756003)(6916009)(2950100002)(6666003)(76176999)(54356999)(50986999)(31696002)(47776003)(6246003)(83506001)(64126003)(110136004)(50466002)(74482002)(38730400002)(65956001)(66066001)(65826007)(7416002)(5660300001)(2906002)(3846002)(6116002)(33646002)(478600001)(4001350100001)(189998001)(23746002)(4326008)(230700001)(81166006)(8676002)(229853002)(25786009)(53546009)(3260700006)(42186005)(31686004)(90366009)(53936002)(7736002)(54906002)(305945005)(6306002)(77096006)(6486002)(117156002)(8666007)(86362001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0202MB2555;H:[192.168.0.125];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;HE1PR0202MB2555;23:8z5ID+WtGpQ5+8FcJq0aIY6+cuGjUMJqtnK?= =?Windows-1252?Q?ON5AknI0ag1Pmd4EhViTSCzqrjCrWz7swv9VL5+quKRfxEm1n2vdArNH?= =?Windows-1252?Q?WAvySwDgCTP34XUmJ95PSRMv6eiaNrm5MamZU8l+EZ59IJBR+aImo9NG?= =?Windows-1252?Q?P4nZxfoOKcbTpos+uJQnxT2NUI4DM5IfjE+4P0UDOob/nW6hsKWfLJjN?= =?Windows-1252?Q?r8DqXamDwacIgoqmfovY/JsI3CxDN2LU8ZvQDoqtPIFzdmqZDSmyQrrB?= =?Windows-1252?Q?s1M383l372ZY2M8/30lTEmmnBUxXz3CFV+FtUUCvz9+4PjgyztBF1eR6?= =?Windows-1252?Q?ikXebsYRm/O8NLPWVtDQ5WldckbztJK1ZQyIlq0y2haOEoLhvxLi2gSs?= =?Windows-1252?Q?kDC9zmxWgmFFARXxYtVxB9+aWwSw3rhV2lET46EIK2IpuPNMjrmRsHIe?= =?Windows-1252?Q?73Hl5xvjWJc/wNCpE18Q4iU/tIM4oCa/Uo6U6h6eJJmfDGPaBJS/7TwB?= =?Windows-1252?Q?nbqDhr76Vu5FBvrzYQqEa/6e2Hz7itydPDYc1SD+6d7F52N9blNDbE5w?= =?Windows-1252?Q?KSgkem6t4lz8sep8/Wxdu0J5G1FBHzl8jGr1/t1ie5UEU2+RBs/skKpC?= =?Windows-1252?Q?X/2M29fSl8EPsKfuZjvl/g9UdwZAu0YEzE6hkRUBsDrp5ydEJy9DLJAT?= =?Windows-1252?Q?+khCxFHmdHliG1cFjQ0IRMKyyN5n4IuR2VnmziXAeRuWVCAwqPMWFeA5?= =?Windows-1252?Q?CYCb2rkpbMh9MNNOYQo5EWR+Phe/OdrRWqiMY0Ies+87FB+tRft+LdED?= =?Windows-1252?Q?0EIBKJMSehs2Yr+qV/Acn/3aSm4UzjkM7e4j8Lbm635OurD8DxqF+gxA?= =?Windows-1252?Q?HWgcQblOdKkWpcG6BywVYNg4EDpwi5PUAArEogni1LInWIFMdPPd9CQP?= =?Windows-1252?Q?MbMrIRthYuRDYyp1fHRRkFx7hx2YF1UR2jjKu/Wp+eDuBC6YcIAXKqGS?= =?Windows-1252?Q?Wv73SHTbWU2mcn9Ci2l/N0Y1hjFc68gnroh/uaQEFLOzgoqauiXASjNi?= =?Windows-1252?Q?zqC+seHlqtFZOpfQsbW/KZBCSmLA7C+UHa6VbSCrjDna4sSDbB2BrQKA?= =?Windows-1252?Q?JSpnlv0mVT0YS1UhdSbfQ7VKOLNmczJ6TDJqIUw8hVrEnZj1jqWs8tUU?= =?Windows-1252?Q?Ky9iR3uwAQUOpsQyE/S3UL/e/V8IcB0L/4TDvzXAVAq68RjbmpZnD4eQ?= =?Windows-1252?Q?foGDaR3vtR7nUPygeT8yuplrSV+K6cZvxjrBWilGD3fBnGNs0c7QQmKc?= =?Windows-1252?Q?Oq0qSH5M0/fXyqhxUgAIjA7YqsXTtIlGgUomiS5USkx/w4oOQwg8ullz?= =?Windows-1252?Q?G6L6kh6sLQfNGXXI6MR5qTHRDw2xKEpe2Pu89lA4Q8V6qAbmGmCM/jmw?= =?Windows-1252?Q?s1iCn+E4E6HW59ba3WdX8TnrbWYtVpwXIP7ukUIOhKwy7rAbtFODOuy2?= =?Windows-1252?Q?HIJEKnpGjbPqGKHIFB8pQa/ZtlqflnTvsM7HWa6sBmX2mu6crrg=3D?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0202MB2555;6:esUp8NXykUJWxh1q1hc/82r2br95umllGUu4Q6vWsx9MFHsddAa++7PqXW/s2qXYcEBvMOETy/6zg8zm5kwSzWxt6F1qghFCKgZ6BMyt2fOnvbtDedru7J1hafPV3LZWLFgEdKoRpH4cjmipnHABqpZfCtZgJyEPk1aPCSJo5N1x6VeIyVeAQGlSFl8+e0MfLoY1dwXwQQMWG3I7dT23vj5lyZuTDSeqcaKMvxNaAwUUS8x2GBH0IBIgFAtGqk2R4HGJ4q8at9/4SRzC6e4cfQ5WexlRtWL0njSbT31v2wEb1ZZAjJ3CitlGvBAz/OUQCULw6DsG8aK1Iv0eVd0xwtm1DoWnWWrgIYBML5ALb+ZKVHGLOmMuDI/EodZQhgAWGfpVknx2Ld4el80o05zkraqCA5WBLttVUqizzUpgeGHS2RuhMVPNtTxaeAQyNjv9DNQuo8d2eDaKos1q6OCW46Gs3UwQjXG6/pg889fqf1WL5ML4jICm+YZqKJmF+Y2FaX0Sxp338DQH+ZSUnd53FQ==;5:oODbUU0yBmFt8Q5pT3frEX2Hw1+XIqVoMBnvR3BO0ZFKLI+263QNMcPacMfg+5YbXqu5XK1YeR8NwXrDiKv66o9j2g5NNaJbJokMLLtdNfYS9WyIrxW8e8g/wt01Lesab3dW53PNflwUdinGS/CUdw==;24:Tt5m9iXSTFZQYC/lq+IMdNy+csVvOvsdSfNfAwbErJHGFMUgFBDHa2wJFp2Cpe2uUL30+cf5IY5pfyC11RconOkypRRZmPuIS3HTCh6NIDc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0202MB2555;7:sO2lkVswdaFASLVDQjhJHmwh5wVH0mrFqFuhNRwChn8afXlJRRY5BQTlrseiXRo7zuaJo/6LsfscV0jz10z9OlfFIx10iozJ15vcs/oCZHSmjMCBiBMbG1HxIab8ACuGgAICzS3r0eqjoFOOYZ9eySFWiPDl3Ev6UjXtD8UjZS14cxs6ei6Velft6/b1qlS0M0RDcYUjKBMRW9DcJ1ee+xPPFK2rZmMl6Dcwow5rQZqslx8w/B01jvsp7Awfk2WkCYSllfC9WqyNdLRvHacMDFSDtNtHuEyp0MpXrPwBE7bj4UslARfDUACBh7Eg4k3Oa10JrhsrbhsD9S5OehlQmA== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2017 13:19:52.3649 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0202MB2555 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-04-18 12:59, Peter Rosin wrote: > On 2017-04-18 10:51, Greg Kroah-Hartman wrote: >> On Thu, Apr 13, 2017 at 06:43:07PM +0200, Peter Rosin wrote: >>> +/** >>> + * devm_mux_chip_unregister() - Resource-managed version mux_chip_unregister(). >>> + * @dev: The device that originally registered the mux-chip. >>> + * @mux_chip: The mux-chip to unregister. >>> + * >>> + * See mux_chip_unregister() for more details. >>> + * >>> + * Note that you do not normally need to call this function. >> >> Odd, then why is it exported??? > > You normally don't call the devm_foo_{free,release,unregister,etc} functions. > The intention is of course that the resourse cleans up automatically. But there > are no cases where the manual clean up is not available, at least not that I can > find? I had a second look and there are of course plenty of examples of missing clean up versions for devm function. I simply hadn't looked very hard at all. So, for v15 I intend to remove all of devm_mux_chip_unregister, devm_mux_chip_free and devm_mux_control_put. They are all just sitting there with no callers. And the mux-mmio/video-mux drivers by Philipp Zabel that build on top of this series don't need them either. Besides, easy to resurrect if needed... I will do v15 with the above, the change from mutex to semaphore for locking the mux controller state [1] and a few small documentation improvements. That will be rebased onto v4.12-rc1 and sent in 10 days or so, or whenever v4.12-rc1 is out. Meanwhile, what I currently intend for v15 but based on v4.11 is available from https://gitlab.com/peda-linux/mux.git in the "mux" branch. Cheers, peda [1] https://lkml.org/lkml/2017/4/25/411