From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C5F5C433F5 for ; Tue, 17 May 2022 16:49:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351198AbiEQQtm (ORCPT ); Tue, 17 May 2022 12:49:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347947AbiEQQtf (ORCPT ); Tue, 17 May 2022 12:49:35 -0400 X-Greylist: delayed 8400 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 17 May 2022 09:49:33 PDT Received: from 9.mo552.mail-out.ovh.net (9.mo552.mail-out.ovh.net [87.98.180.222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 970414EF54 for ; Tue, 17 May 2022 09:49:33 -0700 (PDT) Received: from mxplan5.mail.ovh.net (unknown [10.109.143.159]) by mo552.mail-out.ovh.net (Postfix) with ESMTPS id 99C30272DB; Tue, 17 May 2022 12:03:05 +0000 (UTC) Received: from kaod.org (37.59.142.95) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.6; Tue, 17 May 2022 14:03:03 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-95G00170ed3db5-be56-4885-81a9-6c1aa5207cce, BB146B841C735870D6401592F5D215EFF71F43F0) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: Date: Tue, 17 May 2022 14:03:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: (subset) [PATCH v7 00/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem Content-Language: en-US To: Pratyush Yadav , Mark Brown CC: , , , , , , , , , , , , , References: <20220509175616.1089346-1-clg@kaod.org> <165272636363.750911.14933122170662994904.b4-ty@kernel.org> <20220517110509.2e6xbwot63yl6a3c@ti.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20220517110509.2e6xbwot63yl6a3c@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.95] X-ClientProxiedBy: DAG5EX1.mxp5.local (172.16.2.41) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 80e81b9c-232a-483c-aa21-84c362e6a333 X-Ovh-Tracer-Id: 10302265625168612228 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrheejgdeghecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfhisehtkeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnheptdehkeelieetvddtlefgveeuheduheetledvtdfgfeffledvjeekjeegledvkeeunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddrleehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pratyush, On 5/17/22 13:05, Pratyush Yadav wrote: > Hi Cedric, > > On 16/05/22 07:39PM, Mark Brown wrote: >> On Mon, 9 May 2022 19:56:05 +0200, Cédric Le Goater wrote: >>> This series adds a new SPI driver using the spi-mem interface for the >>> Aspeed static memory controllers of the AST2600, AST2500 and AST2400 >>> SoCs. >>> >>> * AST2600 Firmware SPI Memory Controller (FMC) >>> * AST2600 SPI Flash Controller (SPI1 and SPI2) >>> * AST2500 Firmware SPI Memory Controller (FMC) >>> * AST2500 SPI Flash Controller (SPI1 and SPI2) >>> * AST2400 New Static Memory Controller (also referred as FMC) >>> * AST2400 SPI Flash Controller (SPI) >>> >>> [...] >> >> Applied to >> >> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next >> >> Thanks! >> >> [02/11] dt-bindings: spi: Convert the Aspeed SMC controllers device tree binding >> commit: ce9858ea499da025684a7a5f19823c2c3f14bdce >> [03/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem >> commit: 9c63b846e6df43e5b3d31263f7db545f32deeda3 >> [04/11] spi: aspeed: Add support for direct mapping >> commit: 9da06d7bdec7dad8018c23b180e410ef2e7a4367 >> [05/11] spi: aspeed: Adjust direct mapping to device size >> commit: bb084f94e1bca4a5c4f689d7aa9b410220c1ed71 >> [06/11] spi: aspeed: Workaround AST2500 limitations >> commit: 5785eedee42c34cfec496199a80fa8ec9ddcf7fe >> [07/11] spi: aspeed: Add support for the AST2400 SPI controller >> commit: 53526ab27d9c256504f267713aea60db7af18fb0 >> [08/11] spi: aspeed: Calibrate read timings >> commit: eeaec1ea05c0e0f08e04c6844f20cc24a2fcc0f4 > > I have repeatedly objected to this patch [0][1][2] and you have > repeatedly decided to not address my objections. That's a very harsh way of saying things. I did not decide anything or ignore your comments. I answered your questions and acknowledged that indeed the read training was done under the dirmap handler but this was not a concern today since we had all the required information from spimem. We waited _together_, 5 or 6 weeks, for more inputs on how to address the concerns you raised regarding the sustainability of this method. > I won't spend any more time fighting it. This is not a fight. I don't know why you interpret it that way. Now, since you object so explicitly, and since this patchset has not reached the Linux kernel yet, we should consider dropping it. I rather do that than push crap in mainline. But then, please, provide solutions and not only objections ! > But I will say that you should not expect any > guarantees that SPI NOR or SPI NAND will not break your calibration in > the future if they decide to move the dirmap_create() call around. If that's the case one day, we have multiple solutions : - stop doing the training - move the training to the appropriate handler if it exists - use a default value >> [11/11] mtd: spi-nor: aspeed: set the decoding size to at least 2MB for AST2600 >> commit: 73ae97e3cabb580639f02f12a192324a53c4bebb >> > > [0] https://patchwork.kernel.org/project/spi-devel-general/patch/20220325100849.2019209-9-clg@kaod.org/ > [1] https://patchwork.kernel.org/project/spi-devel-general/patch/20220214094231.3753686-9-clg@kaod.org/ > [2] https://lore.kernel.org/all/20220208190636.h6dubktkmuosvdxo@ti.com/ Regards, Cédric.