From: Pramod Kumar <pramod.kumar@broadcom.com>
To: Rob Herring <robh@kernel.org>
Cc: Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: RE: [PATCH v2 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus mutiplexer
Date: Fri, 3 Jun 2016 20:20:52 +0530 [thread overview]
Message-ID: <a18d8d629426ccbca1a9da19241a6e5d@mail.gmail.com> (raw)
In-Reply-To: <20160603014323.GA12365@rob-hp-laptop>
Hi Rob,
> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: 03 June 2016 07:13
> To: Pramod Kumar
> Cc: Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Catalin Marinas;
Will
> Deacon; Kishon Vijay Abraham I; David S. Miller;
devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; bcm-kernel-feedback-
> list@broadcom.com; linux-kernel@vger.kernel.org; netdev@vger.kernel.org
> Subject: Re: [PATCH v2 3/7] binding: mdio-mux: Add DT binding doc for
> Broadcom MDIO bus mutiplexer
>
> On Tue, May 31, 2016 at 07:06:37PM +0530, Pramod Kumar wrote:
> > Add DT binding doc for Broadcom MDIO bus mutiplexer driver.
> >
> > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com>
> > ---
> > .../bindings/net/brcm,mdio-mux-iproc.txt | 60
> ++++++++++++++++++++++
> > 1 file changed, 60 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt
> > b/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt
> > new file mode 100644
> > index 0000000..f270b41
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt
> > @@ -0,0 +1,60 @@
> > +Properties for an MDIO bus mutiplexer found in Broadcom iProc based
SoCs.
> > +
> > +This MDIO bus multiplexer defines buses that could be internal as
> > +well as external to SoCs and could accept MDIO transaction compatible
> > +to C-22 or
> > +C-45 Clause. When Child bus is selected, one need to select these two
>
> s/Child/child/
Sure. Will ensure this.
> s/need/needs/
Sure. Will ensure this.
> > +properties as well to generate desired MDIO trascation on appropriate
bus.
> > +
> > +Required properties in addition to the generic multiplexer
properties:
> > +
> > +MDIO multiplexer node:
> > +- complatible: brcm,mdio-mux-iproc.
>
> typo
>
Fixed.
> > +
> > +Every non-ethernet PHY requires a compatible so that it could be
> > +probed based on this compatible string.
> > +
> > +Additional information regarding generic multiplexer properties could
> > +be found
>
> s/could/can/
>
Replaced.
> > +at- Documentation/devicetree/bindings/net/mdio-mux.txt
> > +
> > +
> > +for example:
> > + mdio_mux_iproc: mdio_mux_iproc@6602023c {
>
> No '_' in node names.
>
> mdio-mux@...
Yes. Will take care of this.
>
> > + compatible = "brcm,mdio-mux-iproc";
> > + reg = <0x6602023c 0x14>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + mdio-integrated-mux;
> > +
> > + mdio@0 {
> > + reg = <0x0>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + pci_phy0: pci-phy@0 {
> > + compatible = "brcm,ns2-pcie-phy";
> > + reg = <0x0>;
> > + #phy-cells = <0>;
> > + };
> > + };
> > +
> > + mdio@7 {
> > + reg = <0x7>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + pci_phy1: pci-phy@0 {
> > + compatible = "brcm,ns2-pcie-phy";
> > + reg = <0x0>;
> > + #phy-cells = <0>;
> > + };
> > + };
> > + mdio@10 {
> > + reg = <0x10>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + gphy0: eth-phy@10 {
> > + reg = <0x10>;
> > + };
> > + };
> > + };
> > --
> > 1.9.1
> >
Regards,
Pramod
next prev parent reply other threads:[~2016-06-03 14:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 13:36 [PATCH v2 0/7] Add MDIO bus multiplexer support for iProc SoCs Pramod Kumar
2016-05-31 13:36 ` [PATCH v2 1/7] mdio:mux: Enhanced MDIO mux framework for integrated multiplexers Pramod Kumar
2016-06-01 13:02 ` Andrew Lunn
2016-06-03 13:41 ` Pramod Kumar
2016-05-31 13:36 ` [PATCH v2 2/7] DT: phy.txt: Add mdio-integrated-mux property Pramod Kumar
2016-06-02 23:27 ` Rob Herring
2016-06-03 0:46 ` Andrew Lunn
2016-05-31 13:36 ` [PATCH v2 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus mutiplexer Pramod Kumar
2016-06-03 1:43 ` Rob Herring
2016-06-03 14:50 ` Pramod Kumar [this message]
2016-05-31 13:36 ` [PATCH v2 4/7] DT:mdio-mux: Add mdio multiplexer driver node Pramod Kumar
2016-05-31 13:36 ` [PATCH v2 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs Pramod Kumar
2016-06-01 23:18 ` David Miller
2016-06-03 13:47 ` Pramod Kumar
2016-05-31 13:36 ` [PATCH v2 6/7] Binding:PHY: Binding doc for NS2 PCIe PHYs Pramod Kumar
2016-06-03 1:44 ` Rob Herring
2016-05-31 13:36 ` [PATCH v2 7/7] phy: Add Northstar2 PCI Phy support Pramod Kumar
2016-06-01 13:12 ` Andrew Lunn
2016-06-03 11:23 ` Pramod Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a18d8d629426ccbca1a9da19241a6e5d@mail.gmail.com \
--to=pramod.kumar@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).