From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: "shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "linux-imx@nxp.com" <linux-imx@nxp.com>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
"festevam@gmail.com" <festevam@gmail.com>,
"victor.liu@nxp.com" <victor.liu@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH v5 09/10] arm64: dts: freescale: add initial apalis imx8 aka quadmax module support
Date: Fri, 3 Feb 2023 13:14:23 +0000 [thread overview]
Message-ID: <a18e3fb7529328e85730e50a748e140169b39e38.camel@toradex.com> (raw)
In-Reply-To: <b815ba533d339adb014651f27d20f3f6349bdbc4.camel@toradex.com>
Hi Shawn
On Wed, 2023-02-01 at 04:01 +0100, Marcel Ziswiler wrote:
[snip]
> > > +/* Apalis UART1 */
> > > +&lpuart1 {
> > > + dma-names = "","";
> >
> > What is this for?
>
> I guess that switches off DMA falling pack to PIO. Likely, there was an issue at one point in downstream. Let
> me re-test without it.
BTW: Upstream this indeed works just fine without this and I removed it in v6.
[snip]
> > > +&usbotg1 {
> > > + adp-disable;
> > > + ci-disable-lpm;
> > > + hnp-disable;
> > > + over-current-active-low;
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_usbotg1>;
> >
> > We generally want to put such generic properties before device specific
> > ones.
>
> Okay.
Sorry, I missed the generally here. Let me re-work the device trees with this in mind adhering to hopefully all
the rules which apply and send a v7 ASAP.
> Thanks!
Thank you!
> > Shawn
Cheers
Marcel
[snip]
next prev parent reply other threads:[~2023-02-03 13:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 11:08 [PATCH v5 00/10] arm64: dts: freescale: prepare and add apalis imx8 support Marcel Ziswiler
2023-01-26 11:08 ` [PATCH v5 01/10] arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3 Marcel Ziswiler
2023-01-26 11:08 ` [PATCH v5 02/10] arm64: dts: imx8-ss-dma: add io-channel-cells to adc nodes Marcel Ziswiler
2023-01-31 15:00 ` Alexander Stein
2023-01-26 11:08 ` [PATCH v5 03/10] arm64: dts: freescale: imx8-ss-dma: set lpspi0 max frequency to 60mhz Marcel Ziswiler
2023-01-26 11:08 ` [PATCH v5 04/10] firmware: imx: scu-pd: add missed lvds lpi2c and pwm power domains Marcel Ziswiler
2023-01-26 11:08 ` [PATCH v5 05/10] arm64: dts: imx8qxp: add flexcan in adma Marcel Ziswiler
2023-01-31 14:55 ` Alexander Stein
2023-01-26 11:08 ` [PATCH v5 06/10] arm64: dts: imx8qm: add can node in devicetree Marcel Ziswiler
2023-01-26 11:08 ` [PATCH v5 07/10] arm64: dts: imx8qm: add vpu decoder and encoder Marcel Ziswiler
2023-01-26 11:08 ` [PATCH v5 08/10] dt-bindings: arm: fsl: add toradex,apalis-imx8 et al Marcel Ziswiler
2023-01-26 11:08 ` [PATCH v5 09/10] arm64: dts: freescale: add initial apalis imx8 aka quadmax module support Marcel Ziswiler
2023-01-29 3:19 ` Shawn Guo
2023-02-01 3:01 ` Marcel Ziswiler
2023-02-03 13:14 ` Marcel Ziswiler [this message]
2023-01-26 11:08 ` [PATCH v5 10/10] arm64: dts: freescale: add apalis imx8 aka quadmax carrier board support Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a18e3fb7529328e85730e50a748e140169b39e38.camel@toradex.com \
--to=marcel.ziswiler@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).