From: Markus Elfring <Markus.Elfring@web.de>
To: Xianting Tian <xianting_tian@126.com>,
linux-scsi@vger.kernel.org,
virtualization@lists.linux-foundation.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"James E. J. Bottomley" <jejb@linux.ibm.com>,
Jason Wang <jasowang@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] scsi: virtio_scsi: Remove unnecessary condition checks
Date: Thu, 9 Jul 2020 19:16:01 +0200 [thread overview]
Message-ID: <a197f532-7020-0d8e-21bf-42bb66e8daec@web.de> (raw)
> kmem_cache_destroy and mempool_destroy can correctly handle
> null pointer parameter, so there is no need to check if the
> parameter is null before calling kmem_cache_destroy and
> mempool_destroy.
Can another imperative wording be preferred for the change description?
…
> +++ b/drivers/scsi/virtio_scsi.c
> @@ -1003,14 +1003,10 @@ static int __init init(void)
> return 0;
>
> error:
Can such a label be questionable?
…
> + mempool_destroy(virtscsi_cmd_pool);
> + virtscsi_cmd_pool = NULL;
> + kmem_cache_destroy(virtscsi_cmd_cache);
> + virtscsi_cmd_cache = NULL;
> return ret;
> }
How do you think about to add a jump target so that the execution
of a few statements can be avoided according to a previous
null pointer check?
Regards,
Markus
next reply other threads:[~2020-07-09 17:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 17:16 Markus Elfring [this message]
2020-07-09 17:25 ` [PATCH] scsi: virtio_scsi: Remove unnecessary condition checks Paolo Bonzini
2020-07-09 20:55 ` Markus Elfring
2020-07-10 6:32 ` Markus Elfring
2020-07-10 7:17 ` Paolo Bonzini
2020-07-10 7:40 ` Markus Elfring
2020-07-10 7:46 ` Paolo Bonzini
2020-07-10 8:11 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a197f532-7020-0d8e-21bf-42bb66e8daec@web.de \
--to=markus.elfring@web.de \
--cc=jasowang@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xianting_tian@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).