* Re: [PATCH] rxrpc: Fix a memory leak in rxkad_verify_response()
@ 2020-05-22 6:30 Markus Elfring
2020-05-22 6:36 ` Markus Elfring
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-05-22 6:30 UTC (permalink / raw)
To: Qiushi Wu, linux-afs, netdev
Cc: linux-kernel, David Howells, David S. Miller, Jakub Kicinski, Kangjie Lu
> In function rxkad_verify_response(), pointer "ticket" is not released,
> when function rxkad_decrypt_ticket() returns an error, causing a
> memory leak bug.
I suggest to improve also this change description.
How do you think about a wording variant like the following?
A ticket was not released after a call of the function “platform_get_irq” failed.
Thus replace the jump target “temporary_error_free_resp”
by “temporary_error_free_ticket”.
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] rxrpc: Fix a memory leak in rxkad_verify_response()
2020-05-22 6:30 [PATCH] rxrpc: Fix a memory leak in rxkad_verify_response() Markus Elfring
@ 2020-05-22 6:36 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-05-22 6:36 UTC (permalink / raw)
To: Qiushi Wu, linux-afs, netdev
Cc: linux-kernel, David Howells, David S. Miller, Jakub Kicinski, Kangjie Lu
> How do you think about a wording variant like the following?
>
> A ticket was not released after a call of the function “platform_get_irq” failed.
I should have specified an other function name here.
A ticket was not released after a call of the function “rxkad_decrypt_ticket” failed.
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-22 6:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22 6:30 [PATCH] rxrpc: Fix a memory leak in rxkad_verify_response() Markus Elfring
2020-05-22 6:36 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).