From: Ray Jui <ray.jui@broadcom.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Subject: Re: [PATCH v5 7/8] i2c: iproc: add NIC I2C support
Date: Tue, 2 Apr 2019 10:57:33 -0700 [thread overview]
Message-ID: <a1a7a9c9-be4e-c582-d0d5-feccba4022ab@broadcom.com> (raw)
In-Reply-To: <20190402102733.GD2960@kunai>
On 4/2/2019 3:27 AM, Wolfram Sang wrote:
>
>> +#define IDM_CTRL_DIRECT_OFFSET 0x00
>
> And this IDM thing is also never used outside of the I2C context? In
> other words, it also doesn't need a seperate DT node?
>
>
That is correct. Only in the I2C context in our use case.
>> + /* indicates no slave mode support */
>> + bool no_slave;
>
> I would suggest to not use a flag, but to nullify the {un}reg_slave
> callbacks in probe depending on the type. That will also tell the
> i2c-core that slave functionality is not supported. And you can use if
> (!algo->reg_slave) as a flag, too.
>
Yes. Great idea. I'll make the change and remove reg_slave.
>> + iproc_i2c->type =
>> + (enum bcm_iproc_i2c_type) of_device_get_match_data(&pdev->dev);
>
> No need to cast a void*.
>
Yes will fix.
Thanks,
Ray
next prev parent reply other threads:[~2019-04-02 17:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 17:57 [PATCH v5 0/8] iProc I2C slave mode and NIC mode Ray Jui
2019-02-14 17:57 ` [PATCH v5 1/8] i2c: iproc: Extend I2C read up to 255 bytes Ray Jui
2019-03-27 22:17 ` Wolfram Sang
2019-04-01 21:35 ` Ray Jui
2019-02-14 17:57 ` [PATCH v5 2/8] i2c: iproc: Add slave mode support Ray Jui
2019-03-27 22:14 ` Wolfram Sang
2019-03-27 22:41 ` Wolfram Sang
2019-04-01 21:33 ` Ray Jui
2019-04-02 8:24 ` Rayagonda Kokatanur
2019-04-02 9:01 ` Wolfram Sang
2019-02-14 17:57 ` [PATCH v5 3/8] dt-bindings: i2c: iproc: make 'interrupts' optional Ray Jui
2019-02-14 22:25 ` Rob Herring
2019-02-14 17:57 ` [PATCH v5 4/8] i2c: iproc: add polling support Ray Jui
2019-02-14 17:57 ` [PATCH v5 5/8] i2c: iproc: use wrapper for read/write access Ray Jui
2019-02-14 17:57 ` [PATCH v5 6/8] dt-bindings: i2c: iproc: add "brcm,iproc-nic-i2c" compatible string Ray Jui
2019-02-14 22:26 ` Rob Herring
2019-03-27 22:24 ` Wolfram Sang
2019-04-01 21:43 ` Ray Jui
2019-04-02 10:17 ` Wolfram Sang
2019-02-14 17:57 ` [PATCH v5 7/8] i2c: iproc: add NIC I2C support Ray Jui
2019-04-02 10:27 ` Wolfram Sang
2019-04-02 17:57 ` Ray Jui [this message]
2019-04-03 1:10 ` Ray Jui
2019-02-14 17:57 ` [PATCH v5 8/8] arm64: dts: Stingray: Add NIC i2c device node Ray Jui
2019-02-22 20:04 ` [PATCH v5 0/8] iProc I2C slave mode and NIC mode Ray Jui
2019-03-22 16:40 ` Florian Fainelli
2019-03-27 22:27 ` Wolfram Sang
2019-04-01 21:44 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1a7a9c9-be4e-c582-d0d5-feccba4022ab@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).