From: Sudeep Holla <sudeep.holla@arm.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>, X86 ML <x86@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Oleg Nesterov <oleg@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Richard Weinberger <richard@nod.at>,
Jeff Dike <jdike@addtoit.com>,
Steve Capper <Steve.Capper@arm.com>, Haibo Xu <haibo.xu@arm.com>,
Bin Lu <bin.lu@arm.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v2 3/6] x86: clean up _TIF_SYSCALL_EMU handling using ptrace_syscall_enter hook
Date: Tue, 30 Apr 2019 18:09:50 +0100 [thread overview]
Message-ID: <a1de9e18-95f6-c9a4-0d60-9f61b5a2f108@arm.com> (raw)
In-Reply-To: <CALCETrXEebRqX0W8MuS0SeaMDpEO5KdS3k7id279hZgHrmc8yA@mail.gmail.com>
On 30/04/2019 17:46, Andy Lutomirski wrote:
> On Mon, Mar 18, 2019 at 3:49 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
>>
>> Now that we have a new hook ptrace_syscall_enter that can be called from
>> syscall entry code and it handles PTRACE_SYSEMU in generic code, we
>> can do some cleanup using the same in syscall_trace_enter.
>>
>> Further the extra logic to find single stepping PTRACE_SYSEMU_SINGLESTEP
>> in syscall_slow_exit_work seems unnecessary. Let's remove the same.
>>
>
> Unless the patch set contains a selftest that exercises all the
> interesting cases here, NAK. To be clear, there needs to be a test
> that passes on an unmodified kernel and still passes on a patched
> kernel. And that test case needs to *fail* if, for example, you force
> "emulated" to either true or false rather than reading out the actual
> value.
>
Tested using tools/testing/selftests/x86/ptrace_syscall.c
Also v3 doesn't change any logic or additional call to new function as
in v2. It's just simple cleanup as suggested by Oleg.
--
Regards,
Sudeep
next prev parent reply other threads:[~2019-04-30 17:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 10:49 [PATCH v2 0/6] ptrace: consolidate PTRACE_SYSEMU handling and add support for arm64 Sudeep Holla
2019-03-18 10:49 ` [PATCH v2 1/6] ptrace: move clearing of TIF_SYSCALL_EMU flag to core Sudeep Holla
2019-03-18 17:29 ` Oleg Nesterov
2019-03-18 10:49 ` [PATCH v2 2/6] ptrace: introduce ptrace_syscall_enter to consolidate PTRACE_SYSEMU handling Sudeep Holla
2019-03-18 14:31 ` Dmitry V. Levin
2019-03-18 14:55 ` Sudeep Holla
2019-03-18 14:41 ` Dmitry V. Levin
2019-03-18 14:57 ` Sudeep Holla
2019-03-18 10:49 ` [PATCH v2 3/6] x86: clean up _TIF_SYSCALL_EMU handling using ptrace_syscall_enter hook Sudeep Holla
2019-03-18 15:33 ` Oleg Nesterov
2019-04-30 16:44 ` Sudeep Holla
2019-05-01 15:57 ` Oleg Nesterov
2019-05-01 16:51 ` Sudeep Holla
2019-04-30 16:46 ` Andy Lutomirski
2019-04-30 17:09 ` Sudeep Holla [this message]
2019-03-18 10:49 ` [PATCH v2 4/6] powerpc: use common ptrace_syscall_enter hook to handle _TIF_SYSCALL_EMU Sudeep Holla
2019-03-18 14:26 ` Dmitry V. Levin
2019-03-18 14:59 ` Sudeep Holla
2019-03-18 17:20 ` Oleg Nesterov
2019-03-18 17:24 ` Sudeep Holla
2019-03-18 17:33 ` Oleg Nesterov
2019-03-18 17:40 ` Sudeep Holla
2019-03-19 17:08 ` Oleg Nesterov
2019-03-19 17:32 ` Oleg Nesterov
2019-04-03 16:50 ` Will Deacon
2019-03-18 10:49 ` [PATCH v2 5/6] arm64: add PTRACE_SYSEMU{,SINGLESTEP} definations to uapi headers Sudeep Holla
2019-03-18 10:49 ` [PATCH v2 6/6] arm64: ptrace: add support for syscall emulation Sudeep Holla
2019-03-19 3:26 ` Haibo Xu (Arm Technology China)
2019-03-18 20:04 ` [PATCH v2 0/6] ptrace: consolidate PTRACE_SYSEMU handling and add support for arm64 Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1de9e18-95f6-c9a4-0d60-9f61b5a2f108@arm.com \
--to=sudeep.holla@arm.com \
--cc=Steve.Capper@arm.com \
--cc=bin.lu@arm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=haibo.xu@arm.com \
--cc=jdike@addtoit.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).