linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [regression, bisected] 4.11+ imx uarts broken
@ 2017-05-09  4:18 Mika Penttilä
  2017-05-09  7:14 ` Uwe Kleine-König
  0 siblings, 1 reply; 4+ messages in thread
From: Mika Penttilä @ 2017-05-09  4:18 UTC (permalink / raw)
  To: LKML, u.kleine-koenig

Hi,

The following commit e61c38d85b7 makes the uarts on i.MX6 nonfunctional (no data transmitted or received). 
With e61c38d85b7 reverted the uarts work ok.

-------------------
commit e61c38d85b7392e033ee03bca46f1d6006156175
Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date:   Tue Apr 4 11:18:51 2017 +0200

    serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off
 
--------------------


--Mika

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [regression, bisected] 4.11+ imx uarts broken
  2017-05-09  4:18 [regression, bisected] 4.11+ imx uarts broken Mika Penttilä
@ 2017-05-09  7:14 ` Uwe Kleine-König
  2017-05-09  7:25   ` Mika Penttilä
  0 siblings, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2017-05-09  7:14 UTC (permalink / raw)
  To: Mika Penttilä; +Cc: linux-serial, kernel, linux-kernel

Hello Mika,

On Tue, May 09, 2017 at 07:18:09AM +0300, Mika Penttilä wrote:
> The following commit e61c38d85b7 makes the uarts on i.MX6 nonfunctional (no data transmitted or received). 
> With e61c38d85b7 reverted the uarts work ok.
> 
> -------------------
> commit e61c38d85b7392e033ee03bca46f1d6006156175
> Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Date:   Tue Apr 4 11:18:51 2017 +0200
> 
>     serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off
>  
> --------------------

are you operating the UART in DTE or DCE mode? Does this affect all
UARTs or only those that are not used in the bootloader?

Looking at the patch I wonder if setting IMX21_UCR3_RXDMUXSEL |
UCR3_ADNIMP is missing for you.

Can you please check which hunk of e61c38d85b73 is giving you problems?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [regression, bisected] 4.11+ imx uarts broken
  2017-05-09  7:14 ` Uwe Kleine-König
@ 2017-05-09  7:25   ` Mika Penttilä
  2017-05-09 14:31     ` Uwe Kleine-König
  0 siblings, 1 reply; 4+ messages in thread
From: Mika Penttilä @ 2017-05-09  7:25 UTC (permalink / raw)
  To: Uwe Kleine-König; +Cc: linux-serial, kernel, linux-kernel

On 05/09/2017 10:14 AM, Uwe Kleine-König wrote:
> Hello Mika,
> 
> On Tue, May 09, 2017 at 07:18:09AM +0300, Mika Penttilä wrote:
>> The following commit e61c38d85b7 makes the uarts on i.MX6 nonfunctional (no data transmitted or received). 
>> With e61c38d85b7 reverted the uarts work ok.
>>
>> -------------------
>> commit e61c38d85b7392e033ee03bca46f1d6006156175
>> Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Date:   Tue Apr 4 11:18:51 2017 +0200
>>
>>     serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off
>>  
>> --------------------
> 
> are you operating the UART in DTE or DCE mode? Does this affect all
> UARTs or only those that are not used in the bootloader?

I am operating in DCE mode. The debug/console uart works ok, but two others don't.

> 
> Looking at the patch I wonder if setting IMX21_UCR3_RXDMUXSEL |
> UCR3_ADNIMP is missing for you.
> 

Probably yes, but I can verify this later and get back to you.

> Can you please check which hunk of e61c38d85b73 is giving you problems?
> 
> Best regards
> Uwe
> 

--Mika

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [regression, bisected] 4.11+ imx uarts broken
  2017-05-09  7:25   ` Mika Penttilä
@ 2017-05-09 14:31     ` Uwe Kleine-König
  0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2017-05-09 14:31 UTC (permalink / raw)
  To: Mika Penttilä; +Cc: kernel, linux-serial, linux-kernel

On Tue, May 09, 2017 at 10:25:40AM +0300, Mika Penttilä wrote:
> On 05/09/2017 10:14 AM, Uwe Kleine-König wrote:
> > Hello Mika,
> > 
> > On Tue, May 09, 2017 at 07:18:09AM +0300, Mika Penttilä wrote:
> >> The following commit e61c38d85b7 makes the uarts on i.MX6 nonfunctional (no data transmitted or received). 
> >> With e61c38d85b7 reverted the uarts work ok.
> >>
> >> -------------------
> >> commit e61c38d85b7392e033ee03bca46f1d6006156175
> >> Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >> Date:   Tue Apr 4 11:18:51 2017 +0200
> >>
> >>     serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off
> >>  
> >> --------------------
> > 
> > are you operating the UART in DTE or DCE mode? Does this affect all
> > UARTs or only those that are not used in the bootloader?
> 
> I am operating in DCE mode. The debug/console uart works ok, but two others don't.
> 
> > 
> > Looking at the patch I wonder if setting IMX21_UCR3_RXDMUXSEL |
> > UCR3_ADNIMP is missing for you.
> > 
> 
> Probably yes, but I can verify this later and get back to you.

can you please test this patch:

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 33509b4beaec..2182548ff0e1 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -2193,9 +2193,14 @@ static int serial_imx_probe(struct platform_device *pdev)
 		 */
 		writel(IMX21_UCR3_RXDMUXSEL | UCR3_ADNIMP | UCR3_DSR,
 		       sport->port.membase + UCR3);
-
 	} else {
+		unsigned long ucr3 = UCR3_DSR;
+
+		if (!is_imx1_uart(sport))
+			ucr3 |= IMX21_UCR3_RXDMUXSEL | UCR3_ADNIMP;
+
 		writel(0, sport->port.membase + UFCR);
+		writel(ucr3, sport->port.membase + UCR3);
 	}
 
 	clk_disable_unprepare(sport->clk_ipg);

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-05-09 14:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-09  4:18 [regression, bisected] 4.11+ imx uarts broken Mika Penttilä
2017-05-09  7:14 ` Uwe Kleine-König
2017-05-09  7:25   ` Mika Penttilä
2017-05-09 14:31     ` Uwe Kleine-König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).