From: David Ahern <dsahern@gmail.com>
To: Petr Vorel <petr.vorel@gmail.com>
Cc: Heiko Thiery <heiko.thiery@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stephen@networkplumber.org, Dmitry Yakunin <zeil@yandex-team.ru>
Subject: Re: [PATCH iproute2-next v3] lib/fs: fix issue when {name,open}_to_handle_at() is not implemented
Date: Sat, 15 May 2021 12:26:12 -0600 [thread overview]
Message-ID: <a20600f9-25e0-c2e4-079e-9aca1178e409@gmail.com> (raw)
In-Reply-To: <YJ/+C+FVEIRnnJBq@pevik>
On 5/15/21 10:59 AM, Petr Vorel wrote:
> Hi David,
>> On 5/14/21 6:20 AM, Petr Vorel wrote:
>
>>>>> This causes compile failures if anyone is reusing a tree. It would be
>>>>> good to require config.mk to be updated if configure is newer.
>>>> Do you mean the config.mk should have a dependency to configure in the
>>>> Makefile? Wouldn't that be better as a separate patch?
>>> I guess it should be a separate patch. I'm surprised it wasn't needed before.
>
>
>
>> yes, it should be a separate patch, but it needs to precede this one.
>
>> This worked for me last weekend; I'll send it when I get a chance.
>
>> diff --git a/Makefile b/Makefile
>> index 19bd163e2e04..5bc11477ab7a 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -60,7 +60,7 @@ SUBDIRS=lib ip tc bridge misc netem genl tipc devlink
>> rdma dcb man vdpa
>> LIBNETLINK=../lib/libutil.a ../lib/libnetlink.a
>> LDLIBS += $(LIBNETLINK)
>
>> -all: config.mk
>> +all: config
>> @set -e; \
>> for i in $(SUBDIRS); \
>> do echo; echo $$i; $(MAKE) -C $$i; done
>> @@ -80,8 +80,10 @@ all: config.mk
>> @echo "Make Arguments:"
>> @echo " V=[0|1] - set build verbosity level"
>
>> -config.mk:
>> - sh configure $(KERNEL_INCLUDE)
>> +config:
>> + @if [ ! -f config.mk -o configure -nt config.mk ]; then \
>> + sh configure $(KERNEL_INCLUDE); \
>> + fi
>
>> install: all
>> install -m 0755 -d $(DESTDIR)$(SBINDIR)
>
> Thanks a lot, please send it.
>
> I know this is only a fragment, but:
> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
>
> -nt is supported by dash and busybox sh.
>
That helps. My concern was all the sh variants.
next prev parent reply other threads:[~2021-05-15 18:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 6:49 [PATCH iproute2-next v3] lib/fs: fix issue when {name,open}_to_handle_at() is not implemented Heiko Thiery
2021-05-08 8:59 ` Petr Vorel
2021-05-09 22:20 ` David Ahern
2021-05-14 10:22 ` Heiko Thiery
2021-05-14 12:20 ` Petr Vorel
2021-05-14 14:10 ` David Ahern
2021-05-15 16:59 ` Petr Vorel
2021-05-15 18:26 ` David Ahern [this message]
2021-05-15 16:58 ` Petr Vorel
2021-05-17 14:45 ` David Ahern
2021-05-17 17:36 ` Petr Vorel
2021-05-18 1:51 ` David Ahern
2021-05-18 7:24 ` Heiko Thiery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a20600f9-25e0-c2e4-079e-9aca1178e409@gmail.com \
--to=dsahern@gmail.com \
--cc=heiko.thiery@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petr.vorel@gmail.com \
--cc=stephen@networkplumber.org \
--cc=zeil@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).