From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94499C4332F for ; Tue, 1 Nov 2022 21:49:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229695AbiKAVt1 (ORCPT ); Tue, 1 Nov 2022 17:49:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229528AbiKAVtY (ORCPT ); Tue, 1 Nov 2022 17:49:24 -0400 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F260A26D6 for ; Tue, 1 Nov 2022 14:49:22 -0700 (PDT) Received: by mail-io1-xd2f.google.com with SMTP id p184so13521581iof.11 for ; Tue, 01 Nov 2022 14:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HejXL+J+QIXG9aHFC0KatU8gI5T0S5HF7LycLEhYP4k=; b=XLf9q+YrCpSEojPiWImV+o706LQsz4Os76EOGQVTew1FOVpxlUxe35X0D2L7oB1Q/9 jK/dn/Fu2f7d5Y+UcN2IJg579s78sTn/J8gLb+Zu/5T+GFkonpTle7ch8HvdxsLgn6IG AJGAJKmnFena6VCJCjNReK7oyjMu/bZF5gXC4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HejXL+J+QIXG9aHFC0KatU8gI5T0S5HF7LycLEhYP4k=; b=RDQaB+kH4UP9yMQ8umE/+97QBInALcpnXfYD8nd1cdwUwlwaHqpHQEt7OHJcfowicW Fhiyh8oLmgZ/5jelcZHBIw3IiuqBOKtutHzZH7b+CJTx811MKxNhxzs/rcBAdyz7qWTy fmPjVwF9PJ8BcXH0GMVsUtJ3+uMNjxF7PbAg+sy7Nbss8vzZSlwidUsEObZRWWe1jDbz +rXoGsPCy7XX0M3VYjxVD6yXJp4ytAGjPnv+6XL1GD0RaPxtNv1awxHxRC5QD10yFj/D NdD5RmANyiqHTUANYV/1HqXDgpHLKSsRtaW4fOLFu5Un6EmqjUnXrLN+IM1zkl7GJMoS lk/A== X-Gm-Message-State: ACrzQf3Z5qM31YZ+9fkv6emIQ6m4p5bIrB6JqZjdC+1KhrWzBdGf/cgi vED5c4gIFme79EjD7wzWyB93jg== X-Google-Smtp-Source: AMsMyM6/m1cWkL+Pw6gKRxAuWst0ALy4aPYsPZTBDrZ3EqaBRU9Qibe+PqUodJI1JL0JjikvxtZvrQ== X-Received: by 2002:a02:94cf:0:b0:363:4a26:8cff with SMTP id x73-20020a0294cf000000b003634a268cffmr13638400jah.286.1667339362369; Tue, 01 Nov 2022 14:49:22 -0700 (PDT) Received: from [172.22.22.4] ([98.61.227.136]) by smtp.googlemail.com with ESMTPSA id t11-20020a6bc30b000000b006bc53dd917fsm4327045iof.51.2022.11.01.14.49.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 14:49:21 -0700 (PDT) Message-ID: Date: Tue, 1 Nov 2022 16:49:20 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 11/30] greybus: svc: Use kstrtobool() instead of strtobool() Content-Language: en-US To: Christophe JAILLET , Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, greybus-dev@lists.linaro.org References: From: Alex Elder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/1/22 4:13 PM, Christophe JAILLET wrote: > strtobool() is the same as kstrtobool(). > However, the latter is more used within the kernel. > > In order to remove strtobool() and slightly simplify kstrtox.h, switch to > the other function name. > > While at it, include the corresponding header file () > > Signed-off-by: Christophe JAILLET Looks OK to me. Reviewed-by: Alex Elder > --- > This patch is part of a serie that axes all usages of strtobool(). > Each patch can be applied independently from the other ones. > > The last patch of the serie removes the definition of strtobool(). > > You may not be in copy of the cover letter. So, if needed, it is available > at [1]. > > [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/ > --- > drivers/greybus/svc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/greybus/svc.c b/drivers/greybus/svc.c > index 56d2b44d6fef..16cced80867a 100644 > --- a/drivers/greybus/svc.c > +++ b/drivers/greybus/svc.c > @@ -7,6 +7,7 @@ > */ > > #include > +#include > #include > #include > > @@ -83,7 +84,7 @@ static ssize_t watchdog_store(struct device *dev, > int retval; > bool user_request; > > - retval = strtobool(buf, &user_request); > + retval = kstrtobool(buf, &user_request); > if (retval) > return retval; >